Mercurial > mplayer.hg
diff osdep/getch2.h @ 17566:f580a7755ac5
Patch by Stefan Huehner / stefan % huehner ! org \
patch replaces '()' for the correct '(void)' in function
declarations/prototypes which have no parameters. The '()' syntax tell
thats there is a variable list of arguments, so that the compiler cannot
check this. The extra CFLAG '-Wstrict-declarations' shows those cases.
Comments about a similar patch applied to ffmpeg:
That in C++ these mean the same, but in ANSI C the semantics are
different; function() is an (obsolete) K&R C style forward declaration,
it basically means that the function can have any number and any types
of parameters, effectively completely preventing the compiler from doing
any sort of type checking. -- Erik Slagter
Defining functions with unspecified arguments is allowed but bad.
With arguments unspecified the compiler can't report an error/warning
if the function is called with incorrect arguments. -- M\ns Rullg\rd
author | rathann |
---|---|
date | Thu, 09 Feb 2006 14:08:03 +0000 |
parents | 11459d1ff17c |
children | 5385740067a1 |
line wrap: on
line diff
--- a/osdep/getch2.h Thu Feb 09 10:23:51 2006 +0000 +++ b/osdep/getch2.h Thu Feb 09 14:08:03 2006 +0000 @@ -9,14 +9,14 @@ extern char * erase_to_end_of_line; /* Get screen-size using IOCTL call. */ -extern void get_screen_size(); +extern void get_screen_size(void); /* Load key definitions from the TERMCAP database. 'termtype' can be NULL */ extern int load_termcap(char *termtype); /* Enable and disable STDIN line-buffering */ -extern void getch2_enable(); -extern void getch2_disable(); +extern void getch2_enable(void); +extern void getch2_disable(void); /* Read a character or a special key code (see keycodes.h) */ extern int getch2(int halfdelay_time);