Mercurial > mplayer.hg
diff osdep/timer-lx.c @ 17566:f580a7755ac5
Patch by Stefan Huehner / stefan % huehner ! org \
patch replaces '()' for the correct '(void)' in function
declarations/prototypes which have no parameters. The '()' syntax tell
thats there is a variable list of arguments, so that the compiler cannot
check this. The extra CFLAG '-Wstrict-declarations' shows those cases.
Comments about a similar patch applied to ffmpeg:
That in C++ these mean the same, but in ANSI C the semantics are
different; function() is an (obsolete) K&R C style forward declaration,
it basically means that the function can have any number and any types
of parameters, effectively completely preventing the compiler from doing
any sort of type checking. -- Erik Slagter
Defining functions with unspecified arguments is allowed but bad.
With arguments unspecified the compiler can't report an error/warning
if the function is called with incorrect arguments. -- M\ns Rullg\rd
author | rathann |
---|---|
date | Thu, 09 Feb 2006 14:08:03 +0000 |
parents | 08cac43f1e38 |
children | 1f956f8f881e |
line wrap: on
line diff
--- a/osdep/timer-lx.c Thu Feb 09 10:23:51 2006 +0000 +++ b/osdep/timer-lx.c Thu Feb 09 14:08:03 2006 +0000 @@ -29,7 +29,7 @@ } // Returns current time in microseconds -unsigned int GetTimer(){ +unsigned int GetTimer(void){ struct timeval tv; struct timezone tz; // float s; @@ -39,7 +39,7 @@ } // Returns current time in milliseconds -unsigned int GetTimerMS(){ +unsigned int GetTimerMS(void){ struct timeval tv; struct timezone tz; // float s; @@ -51,7 +51,7 @@ static unsigned int RelativeTime=0; // Returns time spent between now and last call in seconds -float GetRelativeTime(){ +float GetRelativeTime(void){ unsigned int t,r; t=GetTimer(); // t*=16;printf("time=%ud\n",t); @@ -61,7 +61,7 @@ } // Initialize timer, must be called at least once at start -void InitTimer(){ +void InitTimer(void){ GetRelativeTime(); }