diff vidix/drivers/savage_vid.c @ 17566:f580a7755ac5

Patch by Stefan Huehner / stefan % huehner ! org \ patch replaces '()' for the correct '(void)' in function declarations/prototypes which have no parameters. The '()' syntax tell thats there is a variable list of arguments, so that the compiler cannot check this. The extra CFLAG '-Wstrict-declarations' shows those cases. Comments about a similar patch applied to ffmpeg: That in C++ these mean the same, but in ANSI C the semantics are different; function() is an (obsolete) K&R C style forward declaration, it basically means that the function can have any number and any types of parameters, effectively completely preventing the compiler from doing any sort of type checking. -- Erik Slagter Defining functions with unspecified arguments is allowed but bad. With arguments unspecified the compiler can't report an error/warning if the function is called with incorrect arguments. -- M���\ns Rullg���\rd

--- a/vidix/drivers/savage_vid.c	Thu Feb 09 10:23:51 2006 +0000
+++ b/vidix/drivers/savage_vid.c	Thu Feb 09 14:08:03 2006 +0000
@@ -82,7 +82,7 @@
 /* CR69[0] = 1 : Mem-mapped regs */
 #define USE_MM_FOR_PRI_STREAM_OLD   0x01
 
-void SavageStreamsOn();
+void SavageStreamsOn(void);
 
 /*
  * There are two different streams engines used in the Savage line.
@@ -323,7 +323,7 @@
 	{ PCI_CHIP_PROSAVAGE_DDRK	, 			S3_PROSAVAGE },
 };
 
-void SavageSetColorOld()
+void SavageSetColorOld(void)
 {
 
 
@@ -360,7 +360,7 @@
   }
 }
 
-void SavageSetColorKeyOld()
+void SavageSetColorKeyOld(void)
 {
     int red, green, blue;
 
@@ -421,8 +421,8 @@
 
 
 static void
-SavageDisplayVideoOld(
-){
+SavageDisplayVideoOld(void)
+{
     int vgaCRIndex, vgaCRReg, vgaIOBase;
     unsigned int ssControl;
     int cr92;
@@ -528,7 +528,7 @@
 
 }
 
-void SavageInitStreamsOld()
+void SavageInitStreamsOld(void)
 {
     /*unsigned long jDelta;*/
     unsigned long format = 0;
@@ -582,7 +582,7 @@
 }
 
 void 
-SavageStreamsOn()
+SavageStreamsOn(void)
 {
      unsigned char jStreamsControl;
      unsigned short vgaCRIndex = 0x3d0 + 4;
@@ -726,7 +726,7 @@
 }
 
 
-void SavageStreamsOff()
+void SavageStreamsOff(void)
 {
     unsigned char jStreamsControl;
     unsigned short vgaCRIndex = 0x3d0 + 4;