Mercurial > mplayer.hg
diff gui/interface.h @ 24086:f5b32d12b691
remove gconvert_uri_to_filename() and use url_unescape_string() instead.
reasons:
* gconvert strdup()s the original string, but it may exit without returning or freeing it.
* gconvert returns the original pointer when no % escaping is done. It is then free()ed and used in that state.
* gconvert doesn't consider that % may be at the end of the string and could continue parsing past the end.
* gconvert would try to free() pointer that iconv() have modified.
* gconvert would try to convert filenames from utf-8 to iso8859-1.
Seems like no other DnD programs convert to utf-8 and/or honors CHARSET.
Not converting seems to work best. Fix it if problem arises.
author | iive |
---|---|
date | Mon, 20 Aug 2007 14:17:43 +0000 |
parents | 3f0d00abc073 |
children | 76f5d8892c04 |
line wrap: on
line diff
--- a/gui/interface.h Mon Aug 20 09:28:44 2007 +0000 +++ b/gui/interface.h Mon Aug 20 14:17:43 2007 +0000 @@ -210,7 +210,6 @@ extern void * gtkSet( int cmd,float param, void * vparam ); -extern char * gconvert_uri_to_filename( char * str ); extern char * gstrdup( const char * str ); extern int gstrcmp( const char * a,const char * b ); extern void gfree( void ** p );