view DOCS/tech/patches.txt @ 4689:61f4b8fd380e

Fixing "quake" by direct waiting of vsync. ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ (I don't why - but SMART_SWITCH is always disabled on my card) Benchmarks: [SRC] VIDEO: [DIV3] 624x356 24bpp 24.00 fps 497.3 kbps (60.7 kbyte/s) [DEST] 1024x768@32 70fps (-xvidix -fs -zoom) -vc ffdivx -double: BENCHMARKs: V: 3.838s VO: 7.305s A: 0.555s Sys: 18.264s = 29.962s BENCHMARK%: V: 12.8110% VO: 24.3808% A: 1.8518% Sys: 60.9564% = 100.0000% total video time: 11.143s -vc ffdivx -nodouble: BENCHMARKs: V: 3.846s VO: 1.668s A: 0.539s Sys: 23.869s = 29.922s BENCHMARK%: V: 12.8525% VO: 5.5744% A: 1.8015% Sys: 79.7716% = 100.0000% total video time: 5.514s -vc divxds -double (direct rendering) BENCHMARKs: V: 8.275s VO: 5.750s A: 0.532s Sys: 15.414s = 29.971s BENCHMARK%: V: 27.6115% VO: 19.1850% A: 1.7737% Sys: 51.4298% = 100.0000% total video time: 14.070s -vc divxds -nodouble (direct rendering) BENCHMARKs: V: 7.353s VO: 0.002s A: 0.521s Sys: 22.083s = 29.958s BENCHMARK%: V: 24.5433% VO: 0.0052% A: 1.7382% Sys: 73.7133% = 100.0000% total video time: 7.355s Unfortunately we have dramatic lost of performance (100%) :(

Sending patches:
~~~~~~~~~~~~~~~~
Note: We know these rules are hard, but it's hard to maintain such
big and complex project, so you should accept our rules. We have no
time for fixing buggy, broken or old patches!

1. Always make patch for the CVS version.
   We do not accept patches for old versions or releases.

2. Make unified diffs ('diff -Naur' or 'cvs diff -u')

3. Test functionality of your patch. We'll *refuse* it if it breaks
   something, even if it extends other features!

4. Read your patch. We'll *refuse* it if it changes indent of the
   code or it does tab/space or other cosmetical changes!

5. Comment parts what really needs it (has tricky side-effects etc).
   Commenting trivial code not requires. Comments must be english!
   
6. Do not ask for CVS write access at first time. If you contributed
   1 or more nice, acceptable patches and they need maintaining or
   you want to be mplayer developer, you'll get CVS write access.
   
7. Subscribe to the mplayer-dev-eng list (don't worry, it's low traffic)
   and send your patch there as base64-encoded attachment (use gzip or
   bzip2 *only* if it's really big or if you know that your mailer messes
   up (re-format) text attachments).
   Subject line should be: '[PATCH] very short description of the patch'.
   In the mail, describe in a few sentences what (and why) are the changes.
   If you made independent changes, try to send them as separate patches.

Thank you!

A'rpi