view DOCS/tech/patches.txt @ 6998:83a386e88f9e

Applied patch by Andras Mohari <mayday at varoshaza . nagyatad . hu> * Reduces the number of '!' chars... * Removes unnecessary spaces before ':' and '!' chars. * Changes the title of Appendix X to 'MPlayer skin format'. * Improves(?) wording in some cases. * Adds CODE tags around some options and filenames. Plus some further wording fixes by me, two dangling links and converted a few ASCII unordered lists into proper HTML ones.

Sending patches:
~~~~~~~~~~~~~~~~
Note: We know these rules are hard, but it's hard to maintain such a
big and complex project, so you should accept our rules. We have no
time for fixing buggy, broken or old patches!

1. Always make patches for the CVS version.
   We do not accept patches for old versions or releases.

2. Make unified diffs ('diff -Naur' or 'cvs diff -u').

3. Test the functionality of your patch. We'll *refuse* it if it breaks
   something, even if it extends other features!

4. Read your patch. We'll *refuse* it if it changes indentation of the
   code or if it does tab/space conversion or other cosmetical changes!

5. Comment parts that really need it (tricky side-effects etc).
   Commenting trivial code not required. Comments must be English!
   
6. Do not ask for CVS write access at first time. If you contributed
   1 or more nice, acceptable patches and they need maintaining or
   you want to be an mplayer developer, you'll get CVS write access.
   
7. Subscribe to the mplayer-dev-eng list (don't worry, it's low traffic)
   and send your patch there as base64-encoded attachment (use gzip or
   bzip2 *only* if it's really big or if you know that your mailer messes
   up (reformats) text attachments).
   Subject line should be: '[PATCH] very short description of the patch'.
   In the mail, describe in a few sentences what you change and why.
   If you made independent changes, try to send them as separate patches.

Thank you!

A'rpi