Mercurial > mplayer.hg
view libdha/kernelhelper/dhahelper.h @ 17566:f580a7755ac5
Patch by Stefan Huehner / stefan % huehner ! org \
patch replaces '()' for the correct '(void)' in function
declarations/prototypes which have no parameters. The '()' syntax tell
thats there is a variable list of arguments, so that the compiler cannot
check this. The extra CFLAG '-Wstrict-declarations' shows those cases.
Comments about a similar patch applied to ffmpeg:
That in C++ these mean the same, but in ANSI C the semantics are
different; function() is an (obsolete) K&R C style forward declaration,
it basically means that the function can have any number and any types
of parameters, effectively completely preventing the compiler from doing
any sort of type checking. -- Erik Slagter
Defining functions with unspecified arguments is allowed but bad.
With arguments unspecified the compiler can't report an error/warning
if the function is called with incorrect arguments. -- M\ns Rullg\rd
author | rathann |
---|---|
date | Thu, 09 Feb 2006 14:08:03 +0000 |
parents | 0165fc26bd12 |
children |
line wrap: on
line source
/* Direct Hardware Access kernel helper (C) 2002 Alex Beregszaszi <alex@fsn.hu> */ #ifndef DHAHELPER_H #define DHAHELPER_H #include <linux/ioctl.h> /* feel free to change */ #define DEFAULT_MAJOR 180 #define API_VERSION 0x1 typedef struct dhahelper_port_s { #define PORT_OP_READ 1 #define PORT_OP_WRITE 2 int operation; int size; int addr; int value; } dhahelper_port_t; typedef struct dhahelper_memory_s { #define MEMORY_OP_MAP 1 #define MEMORY_OP_UNMAP 2 int operation; int start; int offset; int size; int ret; #define MEMORY_FLAG_NOCACHE 1 int flags; } dhahelper_memory_t; typedef struct dhahelper_mtrr_s { #define MTRR_OP_ADD 1 #define MTRR_OP_DEL 2 int operation; int start; int size; int type; } dhahelper_mtrr_t; typedef struct dhahelper_pci_s { #define PCI_OP_READ 1 #define PCI_OP_WRITE 1 int operation; int bus; int dev; int func; int cmd; int size; int ret; } dhahelper_pci_t; #define DHAHELPER_GET_VERSION _IOW('D', 0, int) #define DHAHELPER_PORT _IOWR('D', 1, dhahelper_port_t) #define DHAHELPER_MEMORY _IOWR('D', 2, dhahelper_memory_t) #define DHAHELPER_MTRR _IOWR('D', 3, dhahelper_mtrr_t) #define DHAHELPER_PCI _IOWR('D', 4, dhahelper_pci_t) #endif /* DHAHELPER_H */