Mercurial > mplayer.hg
view libmpcodecs/ad_internal.h @ 24086:f5b32d12b691
remove gconvert_uri_to_filename() and use url_unescape_string() instead.
reasons:
* gconvert strdup()s the original string, but it may exit without returning or freeing it.
* gconvert returns the original pointer when no % escaping is done. It is then free()ed and used in that state.
* gconvert doesn't consider that % may be at the end of the string and could continue parsing past the end.
* gconvert would try to free() pointer that iconv() have modified.
* gconvert would try to convert filenames from utf-8 to iso8859-1.
Seems like no other DnD programs convert to utf-8 and/or honors CHARSET.
Not converting seems to work best. Fix it if problem arises.
author | iive |
---|---|
date | Mon, 20 Aug 2007 14:17:43 +0000 |
parents | f29d31547c31 |
children | 6ac1ece1f9fe |
line wrap: on
line source
#include "codec-cfg.h" #include "libaf/af_format.h" #include "stream/stream.h" #include "libmpdemux/demuxer.h" #include "libmpdemux/stheader.h" #include "ad.h" extern int audio_output_channels; static int init(sh_audio_t *sh); static int preinit(sh_audio_t *sh); static void uninit(sh_audio_t *sh); static int control(sh_audio_t *sh,int cmd,void* arg, ...); static int decode_audio(sh_audio_t *sh,unsigned char *buffer,int minlen,int maxlen); #define LIBAD_EXTERN(x) ad_functions_t mpcodecs_ad_##x = {\ &info,\ preinit,\ init,\ uninit,\ control,\ decode_audio\ };