# HG changeset patch # User ib # Date 1310387523 0 # Node ID 0c42fbe235d36e00bcd190b904650f7231c2b854 # Parent 72adb79f5a16b3932c935acecb1868aef1332bba Fix segmentation fault. In case a subtitle codepage or subtitle font encoding is given that does not match any of the encodings the GUI knows about, the preferences dialog crashes. diff -r 72adb79f5a16 -r 0c42fbe235d3 gui/ui/gtk/preferences.c --- a/gui/ui/gtk/preferences.c Mon Jul 11 11:19:44 2011 +0000 +++ b/gui/ui/gtk/preferences.c Mon Jul 11 12:32:03 2011 +0000 @@ -177,8 +177,6 @@ { "cp874", MSGTR_PREFERENCES_FontEncoding20 }, { NULL,NULL } }; -char * lCEncoding = NULL; -char * lSEncoding = NULL; #endif static int old_audio_driver = 0; @@ -324,8 +322,7 @@ int i; for ( i=0;lEncoding[i].name;i++ ) if ( !gstrcmp( sub_cp,lEncoding[i].name ) ) break; - if ( lEncoding[i].name ) lSEncoding=lEncoding[i].comment; - gtk_entry_set_text( GTK_ENTRY( ESubEncoding ),lSEncoding ); + if ( lEncoding[i].name ) gtk_entry_set_text( GTK_ENTRY( ESubEncoding ),lEncoding[i].comment ); } #endif @@ -344,8 +341,7 @@ int i; for ( i=0;lEncoding[i].name;i++ ) if ( !gstrcmp( subtitle_font_encoding,lEncoding[i].name ) ) break; - if ( lEncoding[i].name ) lCEncoding=lEncoding[i].comment; - gtk_entry_set_text( GTK_ENTRY( EFontEncoding ),lCEncoding ); + if ( lEncoding[i].name ) gtk_entry_set_text( GTK_ENTRY( EFontEncoding ),lEncoding[i].comment ); } switch ( subtitle_autoscale ) {