# HG changeset patch # User reimar # Date 1269373533 0 # Node ID 0d0f53c47bd80fe395d6b13256c53436419279b7 # Parent fbb65a2153c6c95ed64f9770a3b4f575c8629b96 Make http_read_response fail if parsing the response failed. Avoids possible crashes since other code assumes http_hdr->protocol is a valid string if it succeeds. diff -r fbb65a2153c6 -r 0d0f53c47bd8 stream/network.c --- a/stream/network.c Tue Mar 23 19:40:37 2010 +0000 +++ b/stream/network.c Tue Mar 23 19:45:33 2010 +0000 @@ -299,7 +299,10 @@ } http_response_append( http_hdr, response, i ); } while( !http_is_header_entire( http_hdr ) ); - http_response_parse( http_hdr ); + if (http_response_parse( http_hdr ) < 0) { + http_free( http_hdr ); + return NULL; + } return http_hdr; }