# HG changeset patch # User nicodvb # Date 1172927791 0 # Node ID 11e7787eb78bed01ed5603b86b58f3520a870aa8 # Parent 963d93b2fe7c7395b75560ea1624d6aa67109a6d replaced 1 instances of sprintf() with snprintf(); patch by njkain gmail com. This patch is intended to render code easier to audit against buffer oveflows diff -r 963d93b2fe7c -r 11e7787eb78b stream/stream_dvd.c --- a/stream/stream_dvd.c Sat Mar 03 13:10:31 2007 +0000 +++ b/stream/stream_dvd.c Sat Mar 03 13:16:31 2007 +0000 @@ -795,10 +795,11 @@ /* Dynamic DVD drive selection on Darwin */ if(!strcmp(dvd_device, "/dev/rdiskN")) { int i; - char *temp_device = malloc(strlen(dvd_device)+1); + size_t len = strlen(dvd_device); + char *temp_device = malloc(len); for (i = 1; i < 10; i++) { - sprintf(temp_device, "/dev/rdisk%d", i); + snprintf(temp_device, len, "/dev/rdisk%d", i); dvd = DVDOpen(temp_device); if(!dvd) { mp_msg(MSGT_OPEN,MSGL_ERR,MSGTR_CantOpenDVD,temp_device);