# HG changeset patch # User michael # Date 1224946828 0 # Node ID 3ebf88c5eb3dcd25d678f4502585fc9e3153bda8 # Parent 0215eb4439cc4a53ba1ecaa615642d54ab74eea5 Do not attempt to use the unscaled yuv2rgb converter when height is odd because it will overflow the buffer by 1 line. This might have been exploitable. diff -r 0215eb4439cc -r 3ebf88c5eb3d libswscale/swscale.c --- a/libswscale/swscale.c Sat Oct 25 13:13:17 2008 +0000 +++ b/libswscale/swscale.c Sat Oct 25 15:00:28 2008 +0000 @@ -2312,7 +2312,7 @@ #ifdef CONFIG_GPL /* yuv2bgr */ if ((srcFormat==PIX_FMT_YUV420P || srcFormat==PIX_FMT_YUV422P) && (isBGR(dstFormat) || isRGB(dstFormat)) - && !(flags & SWS_ACCURATE_RND)) + && !(flags & SWS_ACCURATE_RND) && !(dstH&1)) { c->swScale= yuv2rgb_get_func_ptr(c); }