# HG changeset patch # User nicodvb # Date 1194033988 0 # Node ID 74ae008380940d2d6ca362bc7dfe2224872b676c # Parent 55c96e8711985b3c2c08c60375e470250b4fdb2c prevent unlikely memleak diff -r 55c96e871198 -r 74ae00838094 libmpdemux/muxer_mpeg.c --- a/libmpdemux/muxer_mpeg.c Fri Nov 02 19:52:22 2007 +0000 +++ b/libmpdemux/muxer_mpeg.c Fri Nov 02 20:06:28 2007 +0000 @@ -2348,17 +2348,20 @@ if(s->b_buffer_size - s->b_buffer_len < len) { + void *tmp; + if(s->b_buffer_len > SIZE_MAX - len) { mp_msg(MSGT_MUXER, MSGL_FATAL, "\nFATAL! couldn't realloc, integer overflow\n"); return; } - s->b_buffer = realloc(s->b_buffer, len + s->b_buffer_len); - if(s->b_buffer == NULL) + tmp = realloc(s->b_buffer, len + s->b_buffer_len); + if(!tmp) { mp_msg(MSGT_MUXER, MSGL_FATAL, "\nFATAL! couldn't realloc %d bytes\n", len + s->b_buffer_len); return; } + s->b_buffer = tmp; s->b_buffer_size = len + s->b_buffer_len; mp_msg(MSGT_MUXER, MSGL_DBG2, "REALLOC(%d) bytes to AUDIO backbuffer\n", s->b_buffer_size);