# HG changeset patch
# User rguyom
# Date 1037538066 0
# Node ID 8ea6ba1e6c0bf4b54178b862c9db5b8b524d7348
# Parent  393f1350b6e8080463a167e68fc25d68459ea0db
Implements [min|max]_[i|p]quantizer.
Better default for min_key_interval.

diff -r 393f1350b6e8 -r 8ea6ba1e6c0b DOCS/mplayer.1
--- a/DOCS/mplayer.1	Sun Nov 17 12:39:00 2002 +0000
+++ b/DOCS/mplayer.1	Sun Nov 17 13:01:06 2002 +0000
@@ -2534,10 +2534,16 @@
 period to reach the required average
 .IPs rc_buffer=<value>
 size of the rate control buffer
-.IPs min_quantizer=<value>
+.IPs min_quantizer=<1-31>
 minimum quantizer (default=2)
-.IPs max_quantizer=<value>
+.IPs max_quantizer=<1-31>
 maximum quantizer (default=31)
+.IPs min_iquantizer=<1-31>
+.IPs min_pquantizer=<1-31>
+minimum quantizer for I & P frames (2pass only, default=2)
+.IPs max_iquantizer=<1-31>
+.IPs max_pquantizer=<1-31>
+maximum quantizer for I & P frames (2pass only, default=31)
 .IPs min_key_interval=<value>
 minimum interval between key frames (2pass only, default=0)
 .IPs max_key_interval=<value>
diff -r 393f1350b6e8 -r 8ea6ba1e6c0b libmpcodecs/ve_xvid.c
--- a/libmpcodecs/ve_xvid.c	Sun Nov 17 12:39:00 2002 +0000
+++ b/libmpcodecs/ve_xvid.c	Sun Nov 17 13:01:06 2002 +0000
@@ -59,13 +59,17 @@
 static int xvidenc_rc_averaging_period = -1;
 static int xvidenc_rc_buffer = -1;
 static int xvidenc_min_quantizer = 2;
-static int xvidenc_max_quantizer = -1;
-static int xvidenc_min_key_interval = 0;
+static int xvidenc_max_quantizer = 31;
+static int xvidenc_min_iquantizer = -1;
+static int xvidenc_max_iquantizer = -1;
+static int xvidenc_min_pquantizer = -1;
+static int xvidenc_max_pquantizer = -1;
+static int xvidenc_min_key_interval = -1;
 static int xvidenc_max_key_interval = -1;
 static int xvidenc_mpeg_quant = 0;
 static int xvidenc_mod_quant = 0;
 static int xvidenc_lumi_mask = 0;
-static int xvidenc_keyframe_boost = 0;
+static int xvidenc_keyframe_boost = -1;
 static int xvidenc_kfthreshold = -1;
 static int xvidenc_kfreduction = -1;
 static int xvidenc_fixed_quant = 0;
@@ -83,6 +87,10 @@
     { "rc_buffer", &xvidenc_rc_buffer, CONF_TYPE_INT, 0, 0, 0, NULL},
     { "min_quantizer", &xvidenc_min_quantizer, CONF_TYPE_INT, CONF_RANGE, 1, 31, NULL},
     { "max_quantizer", &xvidenc_max_quantizer, CONF_TYPE_INT, CONF_RANGE, 1, 31, NULL},
+    { "min_iquantizer", &xvidenc_min_iquantizer, CONF_TYPE_INT, CONF_RANGE, 1, 31, NULL},
+    { "max_iquantizer", &xvidenc_max_iquantizer, CONF_TYPE_INT, CONF_RANGE, 1, 31, NULL},
+    { "min_pquantizer", &xvidenc_min_pquantizer, CONF_TYPE_INT, CONF_RANGE, 1, 31, NULL},
+    { "max_pquantizer", &xvidenc_max_pquantizer, CONF_TYPE_INT, CONF_RANGE, 1, 31, NULL},
     { "min_key_interval", &xvidenc_min_key_interval, CONF_TYPE_INT, 0, 0, 0, NULL}, /* for XVID_MODE_2PASS_2 */
     { "max_key_interval", &xvidenc_max_key_interval, CONF_TYPE_INT, 0, 0, 0, NULL},
     { "mpeg_quant", &xvidenc_mpeg_quant, CONF_TYPE_FLAG, 0, 0, 1, NULL},
@@ -137,12 +145,17 @@
     enc_param.rc_reaction_delay_factor = xvidenc_rc_reaction_delay_factor;
     enc_param.rc_averaging_period = xvidenc_rc_averaging_period;
     enc_param.rc_buffer = xvidenc_rc_buffer;
+    if (xvidenc_min_quantizer >= xvidenc_max_quantizer) {
+	mp_msg (MSGT_MENCODER, MSGL_INFO, 
+		"min_quantizer (%d) must be less than max_quantizer (%d)\n",
+		xvidenc_min_quantizer, xvidenc_max_quantizer);
+	return 0;
+    }
     enc_param.min_quantizer = xvidenc_min_quantizer;
     enc_param.max_quantizer = xvidenc_max_quantizer;
-    if( xvidenc_max_key_interval > 0 )
-	enc_param.max_key_interval = xvidenc_max_key_interval;
-    else
-	enc_param.max_key_interval = 10 * enc_param.fbase / enc_param.fincr;
+    if( xvidenc_max_key_interval <= 0 )
+	xvidenc_max_key_interval = 10 * enc_param.fbase / enc_param.fincr;
+    enc_param.max_key_interval = xvidenc_max_key_interval;
     switch (xvid_encore(NULL, XVID_ENC_CREATE, &enc_param, NULL)) {
     case XVID_ERR_FAIL:
 	mp_msg(MSGT_MENCODER,MSGL_ERR, "xvid: encoder creation failed\n");
@@ -212,6 +225,44 @@
     // initialize VBR engine
     // =====================
     vbrSetDefaults(&fp->vbr_state);
+    if (xvidenc_min_key_interval < 0)
+	xvidenc_min_key_interval = fp->vbr_state.min_key_interval;
+    if (xvidenc_min_iquantizer < 0)
+	xvidenc_min_iquantizer = fp->vbr_state.min_iquant;
+    if (xvidenc_max_iquantizer < 0)
+	xvidenc_max_iquantizer = fp->vbr_state.max_iquant;
+    if (xvidenc_min_pquantizer < 0)
+	xvidenc_min_pquantizer = fp->vbr_state.min_pquant;
+    if (xvidenc_max_pquantizer < 0)
+	xvidenc_max_pquantizer = fp->vbr_state.max_pquant;
+
+    // min/max validation
+    if (xvidenc_min_key_interval > xvidenc_max_key_interval) {
+	mp_msg (MSGT_MENCODER, MSGL_ERR, 
+		"min_key_interval (%d) must be less than max_key_interval (%d)\n",
+		xvidenc_min_key_interval, xvidenc_max_key_interval);
+	return 0;
+    }
+    if (xvidenc_min_quantizer >= xvidenc_max_quantizer) {
+	mp_msg (MSGT_MENCODER, MSGL_ERR, 
+		"min_quantizer (%d) must be less than max_quantizer (%d)\n",
+		xvidenc_min_quantizer, xvidenc_max_quantizer);
+	return 0;
+    }
+    if (xvidenc_min_iquantizer >= xvidenc_max_iquantizer) {
+	mp_msg (MSGT_MENCODER, MSGL_ERR, 
+		"min_iquantizer (%d) must be less than max_iquantizer (%d)\n",
+		xvidenc_min_iquantizer, xvidenc_max_iquantizer);
+	return 0;
+    }
+    if (xvidenc_min_pquantizer >= xvidenc_max_pquantizer) {
+	mp_msg (MSGT_MENCODER, MSGL_ERR, 
+		"min_pquantizer (%d) must be less than max_pquantizer (%d)\n",
+		xvidenc_min_pquantizer, xvidenc_max_pquantizer);
+	return 0;
+    }
+
+    // pass
     if (xvidenc_pass == 0) {
 	if (xvidenc_fixed_quant >= 1) {
 	    fp->vbr_state.mode = VBR_MODE_FIXED_QUANT;
@@ -225,21 +276,26 @@
 	fp->vbr_state.mode = VBR_MODE_2PASS_2;
     else
 	return -1;
+
+    // misc
     fp->vbr_state.fps = (double)enc_param.fbase / enc_param.fincr;
     fp->vbr_state.filename = passtmpfile;
     fp->vbr_state.desired_bitrate = enc_param.rc_bitrate;
-    fp->vbr_state.min_iquant = fp->vbr_state.min_pquant = enc_param.min_quantizer;
-    fp->vbr_state.max_iquant = fp->vbr_state.max_pquant = enc_param.max_quantizer;
-    if (xvidenc_keyframe_boost)
+    fp->vbr_state.min_iquant = xvidenc_min_iquantizer >= 1 ? xvidenc_min_iquantizer : xvidenc_min_quantizer;
+    fp->vbr_state.max_iquant = xvidenc_max_iquantizer >= 1 ? xvidenc_max_iquantizer : xvidenc_max_quantizer;
+    fp->vbr_state.min_pquant = xvidenc_min_pquantizer >= 1 ? xvidenc_min_pquantizer : xvidenc_min_quantizer;
+    fp->vbr_state.max_pquant = xvidenc_max_pquantizer >= 1 ? xvidenc_max_pquantizer : xvidenc_max_quantizer;
+    if (xvidenc_keyframe_boost >= 0)
 	fp->vbr_state.keyframe_boost = xvidenc_keyframe_boost;
     if (xvidenc_kfthreshold >= 0)
 	fp->vbr_state.kftreshold = xvidenc_kfthreshold;
     if (xvidenc_kfreduction >= 0)
 	fp->vbr_state.kfreduction = xvidenc_kfreduction;
-    if (xvidenc_min_key_interval)
+    if (xvidenc_min_key_interval >= 0)
 	fp->vbr_state.min_key_interval = xvidenc_min_key_interval;
     fp->vbr_state.max_key_interval = enc_param.max_key_interval;
     fp->vbr_state.debug = xvidenc_debug;
+
     vbrInit(&fp->vbr_state);
 
     return 1;