# HG changeset patch # User diego # Date 1286800437 0 # Node ID 914208d188b9bf9b74a17bfd242866b4948a2b49 # Parent 98fda5253e8066f941780a5aeca35f290338314b Remove #warning preprocessor directives or replace them by suitable comments. The #warning preprocessor directive is non-standard and not available with all compilers. Furthermore, the warnings it causes are noisy and have not led to getting any of the underlying issues fixed in the space of a decade. diff -r 98fda5253e80 -r 914208d188b9 codec-cfg.c --- a/codec-cfg.c Sun Oct 10 11:20:57 2010 +0000 +++ b/codec-cfg.c Mon Oct 11 12:33:57 2010 +0000 @@ -391,14 +391,14 @@ } #if 0 -#warning codec->driver == 4;... <- this should not be put in here... -#warning Where are they defined ???????????? +//FIXME: codec->driver == 4;... <- this should not be put in here... +//FIXME: Where are they defined ???????????? if (!c->dll && (c->driver == 4 || (c->driver == 2 && type == TYPE_VIDEO))) { mp_msg(MSGT_CODECCFG,MSGL_ERR,MSGTR_CodecNeedsDLL, c->name); return 0; } -#warning Can guid.f1 be 0? How does one know that it was not given? +// FIXME: Can guid.f1 be 0? How does one know that it was not given? // if (!(codec->flags & CODECS_FLAG_AUDIO) && codec->driver == 4) if (type == TYPE_VIDEO) diff -r 98fda5253e80 -r 914208d188b9 libmpdemux/demux_viv.c --- a/libmpdemux/demux_viv.c Sun Oct 10 11:20:57 2010 +0000 +++ b/libmpdemux/demux_viv.c Mon Oct 11 12:33:57 2010 +0000 @@ -324,7 +324,7 @@ if (c == 0x82) { /* ok, this works, but pts calculating from header is required! */ -#warning "Calculate PTS from picture header!" + /* FIXME: "Calculate PTS from picture header!" */ prefix = 1; c = stream_read_char(demux->stream); mp_msg(MSGT_DEMUX, MSGL_V, "packet 0x82(pos=%u) chunk=%x\n", diff -r 98fda5253e80 -r 914208d188b9 loader/dshow/DS_VideoDecoder.c --- a/loader/dshow/DS_VideoDecoder.c Sun Oct 10 11:20:57 2010 +0000 +++ b/loader/dshow/DS_VideoDecoder.c Mon Oct 11 12:33:57 2010 +0000 @@ -687,7 +687,7 @@ IHidden* hidden=(IHidden*)((int)m_pDS_Filter->m_pFilter+0xb8); if (strcmp(name, "Quality") == 0) { -#warning NOT SURE + // NOT SURE int r = hidden->vt->GetSmth2(hidden, &value); if (value >= 10) value -= 10; @@ -715,7 +715,7 @@ Debug printf("No such interface\n"); return -1; } -#warning FIXME + // FIXME int recordpar[30]; recordpar[0]=0x7c; recordpar[1]=fccIV50; diff -r 98fda5253e80 -r 914208d188b9 loader/ext.c --- a/loader/ext.c Sun Oct 10 11:20:57 2010 +0000 +++ b/loader/ext.c Mon Oct 11 12:33:57 2010 +0000 @@ -473,7 +473,7 @@ } if(str->state==0) { -#warning FIXME + // FIXME if( ((unsigned)address >= (unsigned)str->address) && ((unsigned)address+size<=(unsigned)str->address+str->mapping_size) && (type & MEM_COMMIT)) diff -r 98fda5253e80 -r 914208d188b9 loader/pe_image.c --- a/loader/pe_image.c Sun Oct 10 11:20:57 2010 +0000 +++ b/loader/pe_image.c Mon Oct 11 12:33:57 2010 +0000 @@ -292,7 +292,7 @@ if (characteristics_detection && !pe_imp->u.Characteristics) break; -//#warning FIXME: here we should fill imports + /* FIXME: here we should fill imports */ TRACE("Loading imports for %s.dll\n", name); if (pe_imp->u.OriginalFirstThunk != 0) { @@ -452,7 +452,7 @@ file_size=lseek(handle, 0, SEEK_END); lseek(handle, 0, SEEK_SET); -//#warning fix CreateFileMappingA + // fix CreateFileMappingA mapping = CreateFileMappingA( handle, NULL, PAGE_READONLY | SEC_COMMIT, 0, 0, NULL ); if (!mapping) diff -r 98fda5253e80 -r 914208d188b9 loader/vfl.c --- a/loader/vfl.c Sun Oct 10 11:20:57 2010 +0000 +++ b/loader/vfl.c Mon Oct 11 12:33:57 2010 +0000 @@ -218,7 +218,7 @@ /* FIXME: correct? */ // CloseDriver(whic->hdrv,0,0); DrvClose(whic->hdrv); -//#warning FIXME: DrvClose + /* FIXME: DrvClose */ free(whic); return 0; } diff -r 98fda5253e80 -r 914208d188b9 loader/win32.c --- a/loader/win32.c Sun Oct 10 11:20:57 2010 +0000 +++ b/loader/win32.c Mon Oct 11 12:33:57 2010 +0000 @@ -1735,7 +1735,7 @@ static long WINAPI expMultiByteToWideChar(long v1, long v2, char* s1, long siz1, short* s2, int siz2) { -#warning FIXME + /* FIXME */ int i; int result; if(s2==0) @@ -3190,7 +3190,7 @@ } static int WINAPI expGetCurrentThread(void) { -#warning FIXME! + /* FIXME! */ dbgprintf("GetCurrentThread() => %x\n", 0xcfcf9898); return 0xcfcf9898; } diff -r 98fda5253e80 -r 914208d188b9 stream/stream_radio.c --- a/stream/stream_radio.c Sun Oct 10 11:20:57 2010 +0000 +++ b/stream/stream_radio.c Mon Oct 11 12:33:57 2010 +0000 @@ -51,7 +51,6 @@ #ifdef CONFIG_RADIO_V4L #include -#warning "V4L is deprecated and will be removed in future" #endif #endif // !IOCTL_BT848_H_NAME diff -r 98fda5253e80 -r 914208d188b9 vidix/s3_vid.c --- a/vidix/s3_vid.c Sun Oct 10 11:20:57 2010 +0000 +++ b/vidix/s3_vid.c Mon Oct 11 12:33:57 2010 +0000 @@ -385,7 +385,7 @@ format = 7 << 24; break; } -//#warning enable this again + // FIXME: enable this again OUTREG (PSTREAM_FBSIZE_REG, info->screen_y * info->screen_x * (info->bpp >> 3)); OUTREG (PSTREAM_WINDOW_START_REG, OS_XY (0, 0)); OUTREG (PSTREAM_WINDOW_SIZE_REG, OS_WH (info->screen_x, info->screen_y));