# HG changeset patch # User reimar # Date 1264258663 0 # Node ID 915be5c7a30cb949cf0196ace96c3b1b856fad8c # Parent 48c51ebbe42180ac0dfc4916079b8ed29db2a840 Make sure that a qstride of 0 (intentional or not) does not completely break the code (crash if malloc(0) != NULL, otherwise wrong qscales used for B-frames). diff -r 48c51ebbe421 -r 915be5c7a30c libmpcodecs/vf_fspp.c --- a/libmpcodecs/vf_fspp.c Sat Jan 23 12:27:13 2010 +0000 +++ b/libmpcodecs/vf_fspp.c Sat Jan 23 14:57:43 2010 +0000 @@ -533,9 +533,15 @@ vf->priv->mpeg2= mpi->qscale_type; if(mpi->pict_type != 3 && mpi->qscale && !vf->priv->qp){ - if(!vf->priv->non_b_qp) - vf->priv->non_b_qp= malloc(mpi->qstride * ((mpi->h + 15) >> 4)); - fast_memcpy(vf->priv->non_b_qp, mpi->qscale, mpi->qstride * ((mpi->h + 15) >> 4)); + int w = mpi->qstride; + int h = (mpi->h + 15) >> 4; + if (!w) { + w = (mpi->w + 15) >> 4; + h = 1; + } + if(!vf->priv->non_b_qp) + vf->priv->non_b_qp= malloc(w*h); + fast_memcpy(vf->priv->non_b_qp, mpi->qscale, w*h); } if(vf->priv->log2_count || !(mpi->flags&MP_IMGFLAG_DIRECT)){ char *qp_tab= vf->priv->non_b_qp; diff -r 48c51ebbe421 -r 915be5c7a30c libmpcodecs/vf_spp.c --- a/libmpcodecs/vf_spp.c Sat Jan 23 12:27:13 2010 +0000 +++ b/libmpcodecs/vf_spp.c Sat Jan 23 14:57:43 2010 +0000 @@ -480,9 +480,15 @@ vf->priv->mpeg2= mpi->qscale_type; if(mpi->pict_type != 3 && mpi->qscale && !vf->priv->qp){ + int w = mpi->qstride; + int h = (mpi->h + 15) >> 4; + if (!w) { + w = (mpi->w + 15) >> 4; + h = 1; + } if(!vf->priv->non_b_qp) - vf->priv->non_b_qp= malloc(mpi->qstride * ((mpi->h + 15) >> 4)); - fast_memcpy(vf->priv->non_b_qp, mpi->qscale, mpi->qstride * ((mpi->h + 15) >> 4)); + vf->priv->non_b_qp= malloc(w*h); + fast_memcpy(vf->priv->non_b_qp, mpi->qscale, w*h); } if(vf->priv->log2_count || !(mpi->flags&MP_IMGFLAG_DIRECT)){ char *qp_tab= vf->priv->non_b_qp;