# HG changeset patch # User cehoyos # Date 1186560635 0 # Node ID e1adad4d52496402473a2e6ee8fd2ce51235e21d # Parent f5677f116d4e8295393489fa965f70c5dab66ec4 bbox[n] and spu->scaled_start_row are unsigned, comparison with 0 is pointless. diff -r f5677f116d4e -r e1adad4d5249 spudec.c --- a/spudec.c Wed Aug 08 00:35:40 2007 +0000 +++ b/spudec.c Wed Aug 08 08:10:35 2007 +0000 @@ -659,7 +659,6 @@ case 1: if (sub_pos < 50) { bbox[2] = dys*sub_pos/100 - spu->height * scaley / 0x200; - if (bbox[2] < 0) bbox[2] = 0; bbox[3] = bbox[2] + spu->height; } else { bbox[3] = dys*sub_pos/100 + spu->height * scaley / 0x200; @@ -669,7 +668,6 @@ break; case 2: bbox[2] = dys*sub_pos/100 - spu->height * scaley / 0x100; - if (bbox[2] < 0) bbox[2] = 0; bbox[3] = bbox[2] + spu->height; break; default: /* -1 */ @@ -1077,7 +1075,6 @@ case 1: spu->scaled_start_row = dys*sub_pos/100 - spu->scaled_height/2; if (sub_pos < 50) { - if (spu->scaled_start_row < 0) spu->scaled_start_row = 0; } else { if (spu->scaled_start_row + spu->scaled_height > dys) spu->scaled_start_row = dys - spu->scaled_height; @@ -1085,7 +1082,6 @@ break; case 2: spu->scaled_start_row = dys*sub_pos/100 - spu->scaled_height; - if (spu->scaled_start_row < 0) spu->scaled_start_row = 0; break; } draw_alpha(spu->scaled_start_col, spu->scaled_start_row, spu->scaled_width, spu->scaled_height,