# HG changeset patch # User reimar # Date 1238268094 0 # Node ID f4f2524c356b3850a02a6945a6d383c2e3a32fae # Parent 54d4e18aa1f4a7a3c39960fd80b6a12cfed040b4 Initialize all structs to 0 before using them. This is consistent with the remaining code (which uses e.g. calloc) and makes it easier to extend the structs in the future. As a side effect it fixes several valgrind errors in hashmap_hash/hashmap_key_compare caused by padding in the structures, but it is not a correct fix for that issue. diff -r 54d4e18aa1f4 -r f4f2524c356b libass/ass_render.c --- a/libass/ass_render.c Sat Mar 28 18:53:26 2009 +0000 +++ b/libass/ass_render.c Sat Mar 28 19:21:34 2009 +0000 @@ -455,6 +455,7 @@ cur_top = top-by; // Query cache + memset(&hk, 0, sizeof(hk)); memcpy(&hk.a, last_hash, sizeof(*last_hash)); memcpy(&hk.b, hash, sizeof(*hash)); hk.aw = aw; @@ -1429,6 +1430,7 @@ int error; glyph_hash_val_t* val; glyph_hash_key_t key; + memset(&key, 0, sizeof(key)); key.font = render_context.font; key.size = render_context.font_size; key.ch = symbol; @@ -2166,6 +2168,7 @@ for (i = 0; i < text_info.length; ++i) get_bitmap_glyph(text_info.glyphs + i); + memset(event_images, 0, sizeof(*event_images)); event_images->top = device_y - d6_to_int(text_info.lines[0].asc); event_images->height = d6_to_int(text_info.height); event_images->detect_collisions = render_context.detect_collisions;