Mercurial > mplayer.hg

changeset 27227:2de688c15263

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Add a comment on shift vs. division
author reimar
date Fri, 11 Jul 2008 19:00:49 +0000
parents 847ed11ede5e
children 860c265b08e8
files libmpcodecs/ad_msadpcm.c
diffstat 1 files changed, 3 insertions(+), 0 deletions(-) [+]
line wrap: on
line diff
--- a/libmpcodecs/ad_msadpcm.c	Fri Jul 11 18:59:03 2008 +0000
+++ b/libmpcodecs/ad_msadpcm.c	Fri Jul 11 19:00:49 2008 +0000
@@ -171,6 +171,9 @@
     upper_nibble ^= 1;
     SE_4BIT(snibble);
 
+    // should this really be a division and not a shift?
+    // coefficients were originally scaled by for, which might have
+    // been an optimization for 8-bit CPUs _if_ a shift is correct
     predictor = (
       ((sample1[current_channel] * coeff1[current_channel]) +
        (sample2[current_channel] * coeff2[current_channel])) / 64) +