Mercurial > mplayer.hg

changeset 3150:8dae87740d33

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
bad malloc+strcpy => strdup
author arpi
date Tue, 27 Nov 2001 00:42:39 +0000
parents fc5a2369696e
children 790a27fc64f1
files libmpdemux/demuxer.c
diffstat 1 files changed, 6 insertions(+), 10 deletions(-) [+]
line wrap: on
line diff
--- a/libmpdemux/demuxer.c	Tue Nov 27 00:12:27 2001 +0000
+++ b/libmpdemux/demuxer.c	Tue Nov 27 00:42:39 2001 +0000
@@ -2,6 +2,7 @@
 
 #include <stdio.h>
 #include <stdlib.h>
+#include <string.h>
 #include <unistd.h>
 
 #include <sys/types.h>
@@ -654,8 +655,7 @@
 	    mp_msg(MSGT_DEMUX, MSGL_WARN, "Demuxer info->name already present\n!");
 	    return(0);
 	}
-	info->name = malloc(strlen(param));
-	strcpy(info->name, param);
+	info->name = strdup(param);
 	return(1);
     }
 
@@ -666,8 +666,7 @@
 	    mp_msg(MSGT_DEMUX, MSGL_WARN, "Demuxer info->author already present\n!");
 	    return(0);
 	}
-	info->author = malloc(strlen(param));
-	strcpy(info->author, param);
+	info->author = strdup(param);
 	return(1);
     }
 
@@ -678,8 +677,7 @@
 	    mp_msg(MSGT_DEMUX, MSGL_WARN, "Demuxer info->encoder already present\n!");
 	    return(0);
 	}
-	info->encoder = malloc(strlen(param));
-	strcpy(info->encoder, param);
+	info->encoder = strdup(param);
 	return(1);
     }
 
@@ -690,8 +688,7 @@
 	    mp_msg(MSGT_DEMUX, MSGL_WARN, "Demuxer info->comments already present\n!");
 	    return(0);
 	}
-	info->comments = malloc(strlen(param));
-	strcpy(info->comments, param);
+	info->comments = strdup(param);
 	return(1);
     }
 
@@ -702,8 +699,7 @@
 	    mp_msg(MSGT_DEMUX, MSGL_WARN, "Demuxer info->copyright already present\n!");
 	    return(0);
 	}
-	info->copyright = malloc(strlen(param));
-	strcpy(info->copyright, param);
+	info->copyright = strdup(param);
 	return(1);
     }