pidgin-twitter: pidgin-twitter.c comparison

comparison pidgin-twitter.c @ 80:e0bf37c105eb

work in progress one hash table code: - introduced icon_data structure to accommodate every icon related data. - added a common function remove_marks_func() which removes icon request mark. this function ought to be called from g_hash_table_foreach(). - added another new function cancel_fetch_func(), to clean up fetch requests at unload. this function also to be called from g_hash_table_foreach().

author	Yoshiki Yazawa <yaz@cc.rim.or.jp>
date	Tue, 01 Jul 2008 18:20:48 +0900
parents	a4a6c7b204c9
children	f1163f2e4920

comparison

equal deleted inserted replaced

-:a4a6c7b204c9
+:e0bf37c105eb
 /*
 * Pidgin-Twitter plugin.
 *
 * This program is free software; you can redistribute it and/or
 * modify it under the terms of the GNU General Public License as
 #include "pidgin-twitter.h"
 /* globals */
 static GRegex *regp[7];
 static gboolean suppress_oops = FALSE;
-static GHashTable *icon_id_by_user;
+static GHashTable *icon_data_by_user = NULL;
-static GList *requested_users = NULL;
-static GList *requestings = NULL;
+typedef struct icon_data {
-static GHashTable *icon_mark_list_by_user;
+gint icon_id;        // image id
+gboolean requested;  // TRUE if download icon has been requested
+GList *request_list; // marker list
+PurpleUtilFetchUrlData *fetch_data;          // icon fetch data
+} icon_data;
 /* this function is a modified clone of purple_markup_strip_html() */
 static char *
 strip_html_markup(const char *str)
 {
 time_t time;
 } twitter_message_t;
 static void
 post_status_with_api_cb(PurpleUtilFetchUrlData *url_data, gpointer user_data,
 const gchar *url_text, size_t len,
 const gchar *error_message)
 {
 twitter_message_t *tm = (struct twitter_message *)user_data;
 gchar *msg = NULL;
 char *p1 = NULL, *p2 = NULL;
 int error = 1;
 PurpleConversation *conv;
 conv = purple_find_conversation_with_account(PURPLE_CONV_TYPE_ANY,
 "twitter@twitter.com",
 tm->account);
 if (!conv) {
 twitter_debug("failed to get conversation\n");
 goto fin;
 }
 if ((strncmp(url_text, "HTTP/1.0", strlen("HTTP/1.0")) == 0
 || strncmp(url_text, "HTTP/1.1", strlen("HTTP/1.1")) == 0)) {
 p1 = strchr(url_text, ' ');
 if (p1) {
 p1++;
 p2 = strchr(p1, ' ');
 if (p2)
 p2++;
 p2 = NULL;
 }
 }
 code = atoi(p1);
 if (code == 200) {
 error = 0;
 } else {
 switch (code) {
 case 400:
 case 503:
 msg = g_strdup("Twitter is extremely crowded. "
 "Try again later.");
 break;
 default:
 msg = g_strdup_printf("Unknown error. (%d %s)",
 code, p2 ? p2 : "");
 break;
 }
 }
 }
 m = g_strdup_printf("%s: %s", screen_name, tm->status);
 else
 m = "";
 purple_conv_im_write(conv->u.im,
 purple_account_get_username(tm->account),
 m, PURPLE_MESSAGE_SEND, tm->time);
 g_free(m);
 } else {
 gchar *m;
 m = g_strdup_printf("%s<BR>%s",
 msg, tm->status);
 /* FIXME: too strong. it should be more smart */
 purple_conv_im_write(conv->u.im,
 purple_account_get_username(tm->account),
 m, PURPLE_MESSAGE_ERROR, time(NULL));
 g_free(m);
 }
 fin:
 if (msg)
 g_free(msg);
 if (tm) {
 if (tm->status)
 g_free(tm->status);
 g_free(tm);
 }
 post_status_with_api(PurpleAccount *account, char **buffer)
 {
 char *request, *status, *header;
 const char *url_encoded = purple_url_encode(*buffer);
 char *basic_auth, *basic_auth_encoded;
 twitter_message_t *tm;
 const char *screen_name = purple_prefs_get_string(OPT_SCREEN_NAME);
 const char *password = purple_prefs_get_string(OPT_PASSWORD);
 twitter_debug("tm.account: %s\n",
 purple_account_get_username(account));
 if (!screen_name || !password || !screen_name[0] || !password[0]) {
 twitter_debug("screen_name or password is empty\n");
 return;
 tm->account = account;
 tm->status = g_strdup(*buffer);
 tm->time = time(NULL);
 basic_auth = g_strdup_printf("%s:%s", screen_name, password);
 basic_auth_encoded = purple_base64_encode((unsigned char *)basic_auth,
 strlen(basic_auth));
 g_free(basic_auth);
 status = g_strdup_printf(TWITTER_STATUS_FORMAT, url_encoded);
 header = g_strdup_printf(TWITTER_STATUS_POST, basic_auth_encoded,
-strlen(status));
+(int)strlen(status));
 request = g_strconcat(header, status, TWITTER_STATUS_TERMINATOR, NULL);
 purple_util_fetch_url_request(TWITTER_BASE_URL, FALSE,
 NULL, TRUE, request, TRUE,
 g_free(header);
 g_free(basic_auth_encoded);
 g_free(status);
 g_free(request);
 }
 static gboolean
 sending_im_cb(PurpleAccount *account, char *recipient, char **buffer,
 void *data)
 gtk_widget_queue_draw(pidgin_conv_get_window(gtkconv)->window);
 }
 static void
+remove_marks_func(gpointer key, gpointer value, gpointer user_data)
+{
+icon_data *data = (icon_data *)value;
+GtkTextBuffer *text_buffer = (GtkTextBuffer *)user_data;
+GList *mark_list = NULL;
+GList *current;
+if(data && data->request_list)
+mark_list = data->request_list;
+/* remove the marks in its GtkTextBuffers */
+for(current = g_list_first(mark_list); current;
+current = g_list_next(current)) {
+GtkTextMark *current_mark = current->data;
+GtkTextBuffer *current_text_buffer = gtk_text_mark_get_buffer(
+current_mark);
+if(!current_text_buffer)
+continue;
+if(text_buffer) {
+if(current_text_buffer == text_buffer) {
+/* the mark will be freed in this function */
+gtk_text_buffer_delete_mark(current_text_buffer,
+current_mark);
+current->data = NULL;
+}
+}
+else {
+gtk_text_buffer_delete_mark(current_text_buffer, current_mark);
+current->data = NULL;
+}
+} /* end of for */
+mark_list = g_list_remove_all(mark_list, NULL);
+data->request_list = mark_list;
+}
+static void
 delete_requested_icon_marks(PidginConversation *conv) {
 GtkTextBuffer *text_buffer = gtk_text_view_get_buffer(
 GTK_TEXT_VIEW(conv->imhtml));
-GList *user_name_list = g_hash_table_get_keys(icon_mark_list_by_user);
-GList *current_user;
+g_hash_table_foreach(icon_data_by_user,
+(GHFunc)remove_marks_func,
-for(current_user = g_list_first(user_name_list); current_user;
+(gpointer)text_buffer);
-current_user = g_list_next(current_user)) {
-gchar *user_name = current_user->data;
-GList *mark_list = g_hash_table_lookup(icon_mark_list_by_user,
-user_name);
-/* delete the marks in the buffer that will be closed. */
-GList *current = g_list_first(mark_list);
-while(current) {
-GtkTextMark *mark = current->data;
-GList *next = g_list_next(current);
-if(gtk_text_mark_get_buffer(mark) == text_buffer) {
-/* the mark will be freed in the function */
-gtk_text_buffer_delete_mark(text_buffer, mark);
-mark_list = g_list_delete_link(mark_list, current);
-}
-current = next;
-}
-/* Does not replace the old key */
-g_hash_table_insert(icon_mark_list_by_user,
-g_strdup(user_name), mark_list);
-}
-g_list_free(user_name_list);
 }
 static void
 attach_to_window(void)
 {
 conv_list = conv_list->next) {
 PidginConversation *conv = conv_list->data;
 PurpleConversation *purple_conv = conv->active_conv;
 if(purple_conv && is_twitter_conv(purple_conv)) {
 GtkIMHtml *current_imhtml = GTK_IMHTML(conv->imhtml);
 GtkTextBuffer *current_buffer = gtk_text_view_get_buffer(
 GTK_TEXT_VIEW(current_imhtml));
 if(current_buffer == gtk_text_mark_get_buffer(requested_mark)) {
 target_imhtml = current_imhtml;
 gtk_text_buffer_get_iter_at_mark(target_buffer,
 &inserting_point, requested_mark);
 /* insert icon */
-icon_id = GPOINTER_TO_INT(g_hash_table_lookup(icon_id_by_user, user_name));
+icon_data *data = (icon_data *)g_hash_table_lookup(icon_data_by_user, user_name);
+if(data)
+icon_id = data->icon_id;
+else
+icon_id = 0;
 if(!icon_id) {
 return;
 }
 /* insert icon actually */
 gtk_imhtml_insert_image_at_iter(target_imhtml, icon_id, &inserting_point);
 gtk_text_buffer_delete_mark(target_buffer, requested_mark);
+requested_mark = NULL;
 }
 static void
 insert_requested_icon(const gchar *user_name)
 {
-GList *mark_list = g_hash_table_lookup(icon_mark_list_by_user, user_name);
+icon_data *data = (icon_data *)g_hash_table_lookup(icon_data_by_user, user_name);
+GList *mark_list = NULL;
-g_list_foreach(mark_list, (GFunc) insert_icon_at_mark, (gchar *)user_name);
-g_hash_table_remove(icon_mark_list_by_user, user_name);
+if(data)
-g_list_free(mark_list);
+mark_list = data->request_list;
+if(mark_list) {
+g_list_foreach(mark_list, (GFunc) insert_icon_at_mark, (gchar *)user_name);
+mark_list = g_list_remove_all(mark_list, NULL);
+g_list_free(mark_list);
+data->request_list = NULL;
+}
 }
 static void
 got_icon_cb(PurpleUtilFetchUrlData *url_data, gpointer user_data,
 const gchar *url_text, gsize len, const gchar *error_message)
 {
 gchar *user_name = (gchar *)user_data;
 int icon_id;
+icon_data *data = NULL;
 twitter_debug("called\n");
-requestings = g_list_remove(requestings, url_data);
+data = (icon_data *)g_hash_table_lookup(icon_data_by_user, user_name);
+if(data && data->fetch_data) {
+data->fetch_data = NULL;
+}
 /* Return if user's icon had already been downloaded or
 * the download is failure. */
-if(g_hash_table_lookup(icon_id_by_user, user_name) || !url_text) {
+if((data && data->icon_id) || !url_text) { //xxx
 if(!url_text) {
 twitter_debug("downloading %s's icon was failure : %s\n",
 user_name, error_message);
 }
 else {
 twitter_debug("%s's icon has already been downloaded\n", user_name);
 }
-GList *deleting = g_list_find_custom(requested_users,
+data->requested = FALSE;
-user_name, (GCompareFunc) strcmp);
-if(deleting) {
-g_free(deleting->data);
-requested_users = g_list_delete_link(requested_users, deleting);
-}
 g_free(user_name);
 return;
 }
 icon_id = purple_imgstore_add_with_id(g_memdup(url_text, len), len,
 user_name);
-g_hash_table_insert(icon_id_by_user,
+if(!data) {
-g_strdup(user_name),GINT_TO_POINTER(icon_id));
+data = g_new0(icon_data, 1);
+}
+data->icon_id = icon_id;
+g_hash_table_insert(icon_data_by_user,
+g_strdup(user_name), data);
 const gchar *dirname = purple_prefs_get_string(OPT_ICON_DIR);
 /* store retrieved image to a file in icon dir */
 if(ensure_path_exists(dirname)) {
 static void
 request_icon(const char *user_name)
 {
 gchar *url = NULL;
-PurpleUtilFetchUrlData *fetch_data = NULL;
 /* look local icon cache for the requested icon */
 gchar *filename = NULL;
 gchar *path = NULL;
-gint icon_id;
+icon_data *data = NULL;
+data = (icon_data *)g_hash_table_lookup(icon_data_by_user, user_name);
+if(!data) {
+data = g_new0(icon_data, 1);
+g_hash_table_insert(icon_data_by_user,
+g_strdup(user_name), data);
+}
 /* if img has been registerd, just return */
-icon_id = GPOINTER_TO_INT(g_hash_table_lookup(icon_id_by_user, user_name));
+if(data->icon_id)
-if(icon_id) {
 return;
-}
+/* check if saved file exists */
 filename = g_strdup_printf("%s.gif", user_name);
 path = g_build_filename(
 purple_prefs_get_string(OPT_ICON_DIR), filename, NULL);
 if(!g_file_test(path, G_FILE_TEST_EXISTS)) {
 g_free(path);
 path = g_build_filename(
 purple_prefs_get_string(OPT_ICON_DIR), filename, NULL);
 }
 /* build image from file, if file exists */
 if(g_file_test(path, G_FILE_TEST_EXISTS)) {
-gchar *data = NULL;
+gchar *imgdata = NULL;
 size_t len;
 GError *err = NULL;
-if (!g_file_get_contents(path, &data, &len, &err)) {
+if (!g_file_get_contents(path, &imgdata, &len, &err)) {
 twitter_debug("Error reading %s: %s\n",
 path, err->message);
 g_error_free(err);
 }
-icon_id = purple_imgstore_add_with_id(data, len, path);
+data->icon_id = purple_imgstore_add_with_id(imgdata, len, path);
-g_hash_table_insert(icon_id_by_user, g_strdup(user_name), GINT_TO_POINTER(icon_id));
 g_free(filename);
 g_free(path);
+twitter_debug("icon data has been loaded from file\n");
 insert_requested_icon(user_name);
 return;
 }
 /* Return if user's icon has been requested already. */
-if(g_list_find_custom(requested_users, user_name, (GCompareFunc)strcmp)) {
+if(data->requested)
 return;
-}
+else
+data->requested = TRUE;
-requested_users = g_list_append(requested_users, g_strdup(user_name));
 /* Create the URL of the user's icon.
 * See http://twitter.g.hatena.ne.jp/ikko615/20080107/1199703400
 */
 url = g_strdup_printf("http://img.twitty.jp/twitter/user/%s/m.gif",
 user_name);
-fetch_data = purple_util_fetch_url(url, TRUE, NULL, TRUE,
+data->fetch_data = purple_util_fetch_url(url, TRUE, NULL, TRUE,
 got_icon_cb, g_strdup(user_name));
-g_free(url);
+g_free(url); url = NULL;
-requestings = g_list_append(requestings, fetch_data);
 twitter_debug("request %s's icon\n", user_name);
 }
 static void
 mark_icon_for_user(GtkTextMark *mark, const gchar *user_name)
 {
-GList *mark_list = g_hash_table_lookup(icon_mark_list_by_user, user_name);
+icon_data *data = NULL;
+data = (icon_data *)g_hash_table_lookup(icon_data_by_user, user_name);
+if(!data) {
+data = g_new0(icon_data, 1);
+g_hash_table_insert(icon_data_by_user,
+g_strdup(user_name), data);
+}
+GList *mark_list = data->request_list;
 mark_list = g_list_append(mark_list, mark);
-g_hash_table_replace(icon_mark_list_by_user,
+data->request_list = mark_list;
-g_strdup(user_name), mark_list);
 }
 static void
 displayed_im_cb(PurpleAccount *account, const char *who, char *message,
 PurpleConversation *conv, PurpleMessageFlags flags)
 /* get GtkTextIter of the last line */
 gtk_text_buffer_get_iter_at_line(text_buffer, &inserting_point,
 gtk_text_buffer_get_line_count(text_buffer) - 1);
-icon_id = GPOINTER_TO_INT(g_hash_table_lookup(icon_id_by_user, user_name));
+icon_data *data = NULL;
+data = g_hash_table_lookup(icon_data_by_user, user_name);
+if(data)
+icon_id = data->icon_id;
+else
+icon_id = 0;
 /* If the user's icon has not been downloaded,
 * mark the message and request the icon. */
 if(!icon_id) {
-twitter_debug("%s's icon has not been downloaded.\n", user_name);
+twitter_debug("%s's icon is not in memory.\n", user_name);
 mark_icon_for_user(gtk_text_buffer_create_mark(
 text_buffer, NULL, &inserting_point, FALSE),
 user_name);
 /* request to attach icon to the buffer */
 request_icon(user_name);
 regp[PSEUDO]    = g_regex_new(P_PSEUDO,  G_REGEX_RAW, 0, NULL);
 regp[USER]      = g_regex_new(P_USER, 0, 0, NULL);
 regp[USER_FIRST_LINE] = g_regex_new(P_USER_FIRST_LINE, 0, 0, NULL);
 regp[USER_FORMATTED]  = g_regex_new(P_USER_FORMATTED, G_REGEX_RAW, 0, NULL);
-/* hash table for user's icons */
+icon_data_by_user = g_hash_table_new_full(g_str_hash, g_str_equal,
-icon_id_by_user = g_hash_table_new_full(g_str_hash, g_str_equal,
+g_free, NULL);
-g_free, NULL);
-/* hash table for a list of marks that are alternative icons */
-icon_mark_list_by_user = g_hash_table_new_full(g_str_hash, g_str_equal,
-g_free, NULL);
 /* attach counter to the existing twitter window */
 if(purple_prefs_get_bool(OPT_COUNTER)) {
 attach_to_window();
 }
 return TRUE;
 }
+static void
+cancel_fetch_func(gpointer key, gpointer value, gpointer user_data)
+{
+icon_data *data = (icon_data *)value;
+if(!data)
+return;
+if(data->fetch_data) {
+purple_util_fetch_url_cancel(data->fetch_data);
+data->fetch_data = NULL;
+}
+if(data->request_list) {
+twitter_debug("somehow, request_list != NULL\n");
+}
+return;
+}
 static gboolean
 unload_plugin(PurplePlugin *plugin)
 {
-GList *list, *current;
 twitter_debug("called\n");
 /* disconnect from signal */
 purple_signal_disconnect(purple_conversations_get_handle(),
 "writing-im-msg",
 g_regex_unref(regp[PSEUDO]);
 g_regex_unref(regp[USER]);
 g_regex_unref(regp[USER_FIRST_LINE]);
 g_regex_unref(regp[USER_FORMATTED]);
-/* remove the hash table of marks that are alternative icons */
+/* remove mark list in each hash entry */
-list = g_hash_table_get_values(icon_mark_list_by_user);
+g_hash_table_foreach(icon_data_by_user, (GHFunc)remove_marks_func, NULL);
-for(current = g_list_first(list); current;
-current = g_list_next(current)) {
-GList *mark_list = current->data;
-GList *current_mark_list;
-/* remove the marks in its GtkTextBuffers */
-for(current_mark_list = g_list_first(mark_list); current_mark_list;
-current_mark_list = g_list_next(current_mark_list)) {
-GtkTextMark *current_mark = current_mark_list->data;
-GtkTextBuffer *text_buffer = gtk_text_mark_get_buffer(
-current_mark);
-if(text_buffer) {
-/* the mark will be freed in this function */
-gtk_text_buffer_delete_mark(text_buffer, current_mark);
-}
-}
-g_list_free(mark_list);
-}
-g_list_free(list);
-g_hash_table_destroy(icon_mark_list_by_user);
 /* cancel request that has not been finished yet */
-for(list = g_list_first(requestings); list; list = g_list_next(list)) {
+g_hash_table_foreach(icon_data_by_user, (GHFunc)cancel_fetch_func, NULL);
-purple_util_fetch_url_cancel(list->data);
-}
+/* destroy hash table for icon_data */
-g_list_free(requestings);
+g_hash_table_destroy(icon_data_by_user); //XXX all memory freed? --yaz
-requestings = NULL;
-/* destroy hash table for icons */
-g_hash_table_destroy(icon_id_by_user);
-for(list = g_list_first(requested_users); list; list = g_list_next(list)) {
-g_free(list->data);
-}
-g_list_free(requested_users);
-requested_users = NULL;
 /* detach from twitter window */
 detach_from_window();
 return TRUE;

Mercurial > pidgin-twitter

comparison pidgin-twitter.c @ 80:e0bf37c105eb