pidgin-twitter: pidgin-twitter.c comparison

comparison pidgin-twitter.c @ 107:eb77d409c235

- do neither save nor cache icon image if pixbuf can not be obtained. - now icon size can be specified in prefs.xml. - tweaked configuration dialog.

author	Yoshiki Yazawa <yaz@honeyplanet.jp>
date	Tue, 15 Jul 2008 12:32:06 +0900
parents	084e1c6de8ca
children	01b6613a075a

comparison

equal deleted inserted replaced

-:a132905cece6
+:eb77d409c235
 twitter_debug("request %s's icon\n", user_name);
 }
 }
+static GdkPixbuf *
+make_scaled_pixbuf(const gchar *url_text, gsize len)
+{
+/* make pixbuf */
+GdkPixbufLoader *loader;
+GdkPixbuf *src = NULL, *dest = NULL;
+gint size;
+g_return_val_if_fail(url_text != NULL, NULL);
+g_return_val_if_fail(len > 0, NULL);
+loader = gdk_pixbuf_loader_new();
+gdk_pixbuf_loader_write(loader, (guchar *)url_text, len, NULL);
+gdk_pixbuf_loader_close(loader, NULL);
+src = gdk_pixbuf_loader_get_pixbuf(loader);
+if(!src)
+return NULL;
+size = purple_prefs_get_int(OPT_ICON_SIZE);
+if(size == 0)
+size = 48; /* twitter icon size */
+dest = gdk_pixbuf_scale_simple(src, size, size, GDK_INTERP_HYPER);
+gdk_pixbuf_unref (src);
+return dest;
+}
 static void
 got_icon_cb(PurpleUtilFetchUrlData *url_data, gpointer user_data,
 const gchar *url_text, gsize len, const gchar *error_message)
 {
 got_icon_data *gotdata = (got_icon_data *)user_data;
 gint service = gotdata->service;
 gint icon_id;
 icon_data *data = NULL;
 GHashTable *hash = NULL;
+GdkPixbuf *pixbuf = NULL;
+const gchar *dirname = NULL;
 twitter_debug("called: service = %d\n", service);
 switch(service) {
 case twitter_service:
 if(!url_text) {
 twitter_debug("downloading %s's icon failed : %s\n",
 user_name, error_message);
 if(data)
 data->requested = FALSE;
-g_free(gotdata->user_name);
+goto fin_got_icon_cb;
-g_free(gotdata);
 return;
 }
 if(data) {
 /* remove download request */
 /* return if user's icon had been downloaded */
 if(data->icon_id > 0) {
 twitter_debug("%s's icon has already been downloaded\n",
 user_name);
-g_free(gotdata->user_name);
+goto fin_got_icon_cb;
-g_free(gotdata);
 return;
 }
 }
-/* make pixbuf */
+pixbuf = make_scaled_pixbuf(url_text, len);
-GdkPixbufLoader *loader = gdk_pixbuf_loader_new();
-gdk_pixbuf_loader_write(loader, (guchar *)url_text, len, NULL);
+if(!pixbuf)
-gdk_pixbuf_loader_close(loader, NULL);
+goto fin_got_icon_cb;
-GdkPixbuf *src  = gdk_pixbuf_loader_get_pixbuf(loader);
-GdkPixbuf *dest = gdk_pixbuf_scale_simple(src, 48, 48,
-GDK_INTERP_HYPER);
-gdk_pixbuf_unref (src);
 icon_id =
-purple_imgstore_add_with_id(dest,
+purple_imgstore_add_with_id(pixbuf,
-gdk_pixbuf_get_rowstride(dest) *
+gdk_pixbuf_get_rowstride(pixbuf) *
-gdk_pixbuf_get_height(dest),
+gdk_pixbuf_get_height(pixbuf),
 user_name);
 if(!data) {
 twitter_debug("allocate icon_data (shouldn't be called)\n");
 data = g_new0(icon_data, 1);
 }
 data->icon_id = icon_id;
 if(hash)
 g_hash_table_insert(hash, g_strdup(user_name), data);
-const gchar *dirname = purple_prefs_get_string(OPT_ICON_DIR);
+dirname = purple_prefs_get_string(OPT_ICON_DIR);
 /* store retrieved image to a file in icon dir */
 if(ensure_path_exists(dirname)) {
 gchar *filename = NULL;
 gchar *path = NULL;
-//        FILE *fp = NULL;
 switch(service) {
 case twitter_service:
 filename = g_strdup_printf("%s_twitter.gif", user_name);
 break;
 twitter_debug("Downloading %s's icon has been complete.(icon_id = %d)\n",
 user_name, icon_id);
 /* Insert the icon to messages that had been received. */
 insert_requested_icon(user_name, service);
+fin_got_icon_cb:
 g_free(gotdata->user_name);
 g_free(gotdata);
 }
 static void
 request_icon(const char *user_name, gint service)
 {
 gchar *url = NULL;
 /* look local icon cache for the requested icon */
-gchar *filename = NULL;
 gchar *path = NULL;
 icon_data *data = NULL;
 GHashTable *hash = NULL;
 const gchar *suffix = NULL;
 if(data->icon_id > 0)
 return;
 /* check if saved file exists */
 if(suffix) {
+gchar *filename = NULL;
 filename = g_strdup_printf("%s_%s.gif", user_name, suffix);
 path = g_build_filename(
 purple_prefs_get_string(OPT_ICON_DIR), filename, NULL);
 if(!g_file_test(path, G_FILE_TEST_EXISTS)) {
 g_free(path);
 filename = g_strdup_printf("%s_%s.png", user_name, suffix);
 path = g_build_filename(
 purple_prefs_get_string(OPT_ICON_DIR), filename, NULL);
 }
+g_free(filename);
 }
 twitter_debug("path = %s\n", path);
 /* build image from file, if file exists */
 if(g_file_test(path, G_FILE_TEST_EXISTS)) {
 gchar *imgdata = NULL;
 size_t len;
 GError *err = NULL;
+GdkPixbuf *pixbuf = NULL;
 if (!g_file_get_contents(path, &imgdata, &len, &err)) {
 twitter_debug("Error reading %s: %s\n",
 path, err->message);
 g_error_free(err);
 }
-/* make pixbuf */
+pixbuf = make_scaled_pixbuf(imgdata, len);
-GdkPixbufLoader *loader = gdk_pixbuf_loader_new();
-gdk_pixbuf_loader_write(loader, (guchar *)imgdata, len, NULL);
+if(pixbuf) {
-gdk_pixbuf_loader_close(loader, NULL);
+data->icon_id =
-GdkPixbuf *src  = gdk_pixbuf_loader_get_pixbuf(loader);
+purple_imgstore_add_with_id(pixbuf,
-GdkPixbuf *dest = gdk_pixbuf_scale_simple(src, 48, 48,
+gdk_pixbuf_get_rowstride(pixbuf) *
-GDK_INTERP_HYPER);
+gdk_pixbuf_get_height(pixbuf),
-gdk_pixbuf_unref (src);
+user_name);
-data->icon_id =
-purple_imgstore_add_with_id(dest,
+twitter_debug("icon data has been loaded from file\n");
-gdk_pixbuf_get_rowstride(dest) *
+insert_requested_icon(user_name, service);
-gdk_pixbuf_get_height(dest),
+}
-user_name);
-g_free(filename);
 g_free(path);
-twitter_debug("icon data has been loaded from file\n");
-insert_requested_icon(user_name, service);
 return;
 }
 /* Return if user's icon has been requested already. */
 if(data->requested)
 /* create gtk elements for the plugin preferences */
 PurplePluginPref *pref;
 PurplePluginPrefFrame *frame = purple_plugin_pref_frame_new();
 /************************/
-/* translatione heading */
+/* user config heading */
+/************************/
+pref = purple_plugin_pref_new_with_label("User Account");
+purple_plugin_pref_frame_add(frame, pref);
+/* screenname configurations */
+pref = purple_plugin_pref_new_with_name_and_label(OPT_SCREEN_NAME,
+"Screen Name");
+purple_plugin_pref_frame_add(frame, pref);
+pref = purple_plugin_pref_new_with_name_and_label(OPT_PASSWORD,
+"Password");
+purple_plugin_pref_set_masked(pref, TRUE);
+purple_plugin_pref_frame_add(frame, pref);
+/************************/
+/* translation heading */
 /************************/
 pref = purple_plugin_pref_new_with_label("Translation Configurations");
 purple_plugin_pref_frame_add(frame, pref);
 /* translation settings */
 pref = purple_plugin_pref_new_with_name_and_label(OPT_TRANSLATE_CHANNEL,
 "Translate channel name to link (wassr only)");
 purple_plugin_pref_frame_add(frame, pref);
-/*************************/
+/***********************/
-/* miscellaneous heading */
+/* GUI config heading */
-/*************************/
+/***********************/
-pref = purple_plugin_pref_new_with_label("Miscellaneous Configurations");
+pref = purple_plugin_pref_new_with_label("GUI Configurations");
+purple_plugin_pref_frame_add(frame, pref);
+/* show icon */
+pref = purple_plugin_pref_new_with_name_and_label(OPT_SHOW_ICON,
+"Show icons in conversation");
+purple_plugin_pref_frame_add(frame, pref);
+#if 0
+/* icon size */
+pref = purple_plugin_pref_new_with_name_and_label(OPT_ICON_SIZE,
+"Icon size in pixel");
+	purple_plugin_pref_set_bounds(pref, 16, 128);
+purple_plugin_pref_frame_add(frame, pref);
+/* XXX should invalidate pixbufs in memory --yaz */
+#endif
+/* show text counter  */
+pref = purple_plugin_pref_new_with_name_and_label(OPT_COUNTER,
+"Show text counter widget");
+purple_plugin_pref_frame_add(frame, pref);
+purple_prefs_connect_callback(plugin, OPT_COUNTER,
+counter_prefs_cb, NULL);
+/****************************/
+/* advanced config heading */
+/****************************/
+pref = purple_plugin_pref_new_with_label("Advanced Configurations");
 purple_plugin_pref_frame_add(frame, pref);
 /* escape pseudo command setting */
 pref = purple_plugin_pref_new_with_name_and_label(OPT_ESCAPE_PSEUDO,
 "Escape pseudo command string");
 purple_plugin_pref_frame_add(frame, pref);
-/* show text counter  */
-pref = purple_plugin_pref_new_with_name_and_label(OPT_COUNTER,
-"Show text counter");
-purple_plugin_pref_frame_add(frame, pref);
-purple_prefs_connect_callback(plugin, OPT_COUNTER, counter_prefs_cb, NULL);
 /* suppress oops message */
 pref = purple_plugin_pref_new_with_name_and_label(OPT_SUPPRESS_OOPS,
 "Suppress oops message");
 purple_plugin_pref_frame_add(frame, pref);
-/* show icon */
-pref = purple_plugin_pref_new_with_name_and_label(OPT_SHOW_ICON,
+/* notification setting */
-"Show icon");
+pref =
-purple_plugin_pref_frame_add(frame, pref);
+purple_plugin_pref_new_with_name_and_label(OPT_PREVENT_NOTIFICATION,
+"Do not notify incoming message");
+purple_plugin_pref_frame_add(frame, pref);
-/*****************/
+/******************/
 /* sound heading */
-/*****************/
+/******************/
 pref = purple_plugin_pref_new_with_label("Sound Configurations");
 purple_plugin_pref_frame_add(frame, pref);
 /* sound settings for recipient */
 pref = purple_plugin_pref_new_with_name_and_label(OPT_PLAYSOUND_RECIPIENT,
 purple_plugin_pref_add_choice(pref, "Chat Leave", GINT_TO_POINTER(6));
 purple_plugin_pref_add_choice(pref, "Chat You Say", GINT_TO_POINTER(7));
 purple_plugin_pref_add_choice(pref, "Chat Someone Say", GINT_TO_POINTER(8));
 purple_plugin_pref_add_choice(pref, "Pounce Default", GINT_TO_POINTER(9));
 purple_plugin_pref_add_choice(pref, "Chat Nick Said", GINT_TO_POINTER(10));
+purple_plugin_pref_frame_add(frame, pref);
-purple_plugin_pref_frame_add(frame, pref);
+/****************/
-/************************/
+/* API heading */
-/* notification heading */
+/****************/
-/************************/
+pref = purple_plugin_pref_new_with_label("API Based Post Configuration");
-pref = purple_plugin_pref_new_with_label("Notification Configuration");
+purple_plugin_pref_frame_add(frame, pref);
-purple_plugin_pref_frame_add(frame, pref);
+/* post configuration */
-/* notification setting */
-pref = purple_plugin_pref_new_with_name_and_label(OPT_PREVENT_NOTIFICATION,
-"Prevent notifications of incoming messages");
-purple_plugin_pref_frame_add(frame, pref);
-/* API based post */
-pref = purple_plugin_pref_new_with_label("API Based Post");
-purple_plugin_pref_frame_add(frame, pref);
 pref = purple_plugin_pref_new_with_name_and_label(OPT_API_BASE_POST,
-"Post Status with API");
+"Post Status via API");
 purple_plugin_pref_frame_add(frame, pref);
-pref = purple_plugin_pref_new_with_name_and_label(OPT_SCREEN_NAME,
-"Screen Name");
-purple_plugin_pref_frame_add(frame, pref);
-pref = purple_plugin_pref_new_with_name_and_label(OPT_PASSWORD,
-"Password");
-purple_plugin_pref_set_masked(pref, TRUE);
-purple_plugin_pref_frame_add(frame, pref);
 return frame;
 }
 static PurplePluginUiInfo pref_info = {
 purple_prefs_add_bool(OPT_SHOW_ICON, TRUE);
 purple_prefs_add_bool(OPT_API_BASE_POST, FALSE);
 purple_prefs_add_string(OPT_SCREEN_NAME, EMPTY);
 purple_prefs_add_string(OPT_PASSWORD, EMPTY);
+purple_prefs_add_int(OPT_ICON_SIZE, 48);
 }
 PURPLE_INIT_PLUGIN(pidgin_twitter, init_plugin, info)

Mercurial > pidgin-twitter

comparison pidgin-twitter.c @ 107:eb77d409c235