annotate .cvsignore @ 11719:109ee3bfeac5

[gaim-migrate @ 14010] SF Patch #1333770 from corfe83 "Many times in gaim we use the function g_slist_remove(list,node->data) to remove an element from a GSList. If we already have the pointer to the node we want to delete, it is faster to send it the pointer to the node to delete rather than the data of the node (we can do this by calling g_slist_delete_link(list,node)). This change was made while looking at glib's documentation and the code in glib's gslist.c. This is because as the remove/delete function traverses each node in the list, it doesn't need to spend an extra memory access to retrieve the data for each element in the node it is traversing and then compare, it can simply compare the pointer. In my tests outside of gaim, this makes a big difference if the node you are deleting is at a high index in the list. However, even if you're deleting the first node, it about breaks even. So, I've found each case in gaim where we are calling g_slist_remove, and we already have the pointer to the appropriate node to delete (this is often the case when we're doing a for or while loop on a GSList). I've then replaced it with the appropriate call to g_slist_delete_link. I, however, didn't do this in situations where we are explicitly removing the first element in the list, because in those situations it is an unnecessary change. There should be no difference in behavior, but just in case I've tried running it with valgrind, which reports the same number of memory leaks after my patch as before my patch. Of course, I can't guarantee that my normal behavior on gaim is hitting all the functions I've changed, but in general testing it Works For Me (tm)." As with the last patch, this one may not have a practical performance impact (or maybe it does, I have no idea), but it's not worse for any case. Given two ways of doing things where one is always at least as fast and may be faster under some cases, I like to prefer that faster way. This doesn't make the code any uglier, so I'm applying. committer: Tailor Script <tailor@pidgin.im>
author Richard Laager <rlaager@wiktel.com>
date Sat, 22 Oct 2005 20:48:18 +0000
parents c398f55ce5c7
children b0ad08e1d492
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
1893
3b956bf94751 [gaim-migrate @ 1903]
Rob Flynn <gaim@robflynn.com>
parents:
diff changeset
1 config.h
3b956bf94751 [gaim-migrate @ 1903]
Rob Flynn <gaim@robflynn.com>
parents:
diff changeset
2 libtool
3b956bf94751 [gaim-migrate @ 1903]
Rob Flynn <gaim@robflynn.com>
parents:
diff changeset
3 config.status
3b956bf94751 [gaim-migrate @ 1903]
Rob Flynn <gaim@robflynn.com>
parents:
diff changeset
4 intl
3b956bf94751 [gaim-migrate @ 1903]
Rob Flynn <gaim@robflynn.com>
parents:
diff changeset
5 ABOUT-NLS
5048
cb320b74a0dd [gaim-migrate @ 5396]
Luke Schierer <lschiere@pidgin.im>
parents: 4704
diff changeset
6 compile
1893
3b956bf94751 [gaim-migrate @ 1903]
Rob Flynn <gaim@robflynn.com>
parents:
diff changeset
7 config.guess
3b956bf94751 [gaim-migrate @ 1903]
Rob Flynn <gaim@robflynn.com>
parents:
diff changeset
8 config.sub
4558
d22814243d13 [gaim-migrate @ 4839]
Christian Hammond <chipx86@chipx86.com>
parents: 4427
diff changeset
9 Doxyfile
1893
3b956bf94751 [gaim-migrate @ 1903]
Rob Flynn <gaim@robflynn.com>
parents:
diff changeset
10 ltconfig
3b956bf94751 [gaim-migrate @ 1903]
Rob Flynn <gaim@robflynn.com>
parents:
diff changeset
11 ltmain.sh
3b956bf94751 [gaim-migrate @ 1903]
Rob Flynn <gaim@robflynn.com>
parents:
diff changeset
12 install-sh
3b956bf94751 [gaim-migrate @ 1903]
Rob Flynn <gaim@robflynn.com>
parents:
diff changeset
13 missing
3b956bf94751 [gaim-migrate @ 1903]
Rob Flynn <gaim@robflynn.com>
parents:
diff changeset
14 aclocal.m4
3b956bf94751 [gaim-migrate @ 1903]
Rob Flynn <gaim@robflynn.com>
parents:
diff changeset
15 configure
3b956bf94751 [gaim-migrate @ 1903]
Rob Flynn <gaim@robflynn.com>
parents:
diff changeset
16 config.h.in
3b956bf94751 [gaim-migrate @ 1903]
Rob Flynn <gaim@robflynn.com>
parents:
diff changeset
17 stamp-h.in
3b956bf94751 [gaim-migrate @ 1903]
Rob Flynn <gaim@robflynn.com>
parents:
diff changeset
18 Makefile.in
3b956bf94751 [gaim-migrate @ 1903]
Rob Flynn <gaim@robflynn.com>
parents:
diff changeset
19 config.log
3b956bf94751 [gaim-migrate @ 1903]
Rob Flynn <gaim@robflynn.com>
parents:
diff changeset
20 config.cache
3b956bf94751 [gaim-migrate @ 1903]
Rob Flynn <gaim@robflynn.com>
parents:
diff changeset
21 Makefile
3b956bf94751 [gaim-migrate @ 1903]
Rob Flynn <gaim@robflynn.com>
parents:
diff changeset
22 stamp-h
3b956bf94751 [gaim-migrate @ 1903]
Rob Flynn <gaim@robflynn.com>
parents:
diff changeset
23 gaim.spec
2168
74947d32d3c6 [gaim-migrate @ 2178]
Eric Warmenhoven <eric@warmenhoven.org>
parents: 1894
diff changeset
24 depcomp
74947d32d3c6 [gaim-migrate @ 2178]
Eric Warmenhoven <eric@warmenhoven.org>
parents: 1894
diff changeset
25 stamp-h1
3358
092594c175ff [gaim-migrate @ 3377]
Christian Hammond <chipx86@chipx86.com>
parents: 3356
diff changeset
26 autom4te*.cache
3356
8647a5b37b5c [gaim-migrate @ 3375]
Christian Hammond <chipx86@chipx86.com>
parents: 3355
diff changeset
27 configure.2.1x
3358
092594c175ff [gaim-migrate @ 3377]
Christian Hammond <chipx86@chipx86.com>
parents: 3356
diff changeset
28 confdefs.h
092594c175ff [gaim-migrate @ 3377]
Christian Hammond <chipx86@chipx86.com>
parents: 3356
diff changeset
29 *.swp
3702
d82147d95f6b [gaim-migrate @ 3833]
Rob Flynn <gaim@robflynn.com>
parents: 3358
diff changeset
30 win32-install-dir
3703
286e44e665e1 [gaim-migrate @ 3834]
Rob Flynn <gaim@robflynn.com>
parents: 3702
diff changeset
31 .temp-gettextize
4704
56c70997fe5c [gaim-migrate @ 5015]
Nathan Walp <nwalp@pidgin.im>
parents: 4558
diff changeset
32 m4
9365
f61c37936a41 [gaim-migrate @ 10173]
Ethan Blanton <elb@pidgin.im>
parents: 9138
diff changeset
33 gaim.pc
10362
c398f55ce5c7 [gaim-migrate @ 11580]
Tim Ringenbach <marv@pidgin.im>
parents: 9365
diff changeset
34 *.apspec