Mercurial > pidgin.yaz
annotate Makefile.am @ 11719:109ee3bfeac5
[gaim-migrate @ 14010]
SF Patch #1333770 from corfe83
"Many times in gaim we use the function
g_slist_remove(list,node->data) to remove an element
from a GSList. If we already have the pointer to the
node we want to delete, it is faster to send it the
pointer to the node to delete rather than the data of
the node (we can do this by calling
g_slist_delete_link(list,node)). This change was made
while looking at glib's documentation and the code in
glib's gslist.c.
This is because as the remove/delete function traverses
each node in the list, it doesn't need to spend an
extra memory access to retrieve the data for each
element in the node it is traversing and then compare,
it can simply compare the pointer. In my tests outside
of gaim, this makes a big difference if the node you
are deleting is at a high index in the list. However,
even if you're deleting the first node, it about breaks
even.
So, I've found each case in gaim where we are calling
g_slist_remove, and we already have the pointer to the
appropriate node to delete (this is often the case when
we're doing a for or while loop on a GSList). I've then
replaced it with the appropriate call to
g_slist_delete_link. I, however, didn't do this in
situations where we are explicitly removing the first
element in the list, because in those situations it is
an unnecessary change.
There should be no difference in behavior, but just in
case I've tried running it with valgrind, which reports
the same number of memory leaks after my patch as
before my patch. Of course, I can't guarantee that my
normal behavior on gaim is hitting all the functions
I've changed, but in general testing it Works For Me (tm)."
As with the last patch, this one may not have a practical performance impact (or maybe it does, I have no idea), but it's not worse for any case. Given two ways of doing things where one is always at least as fast and may be faster under some cases, I like to prefer that faster way. This doesn't make the code any uglier, so I'm applying.
committer: Tailor Script <tailor@pidgin.im>
author | Richard Laager <rlaager@wiktel.com> |
---|---|
date | Sat, 22 Oct 2005 20:48:18 +0000 |
parents | 616feca04ada |
children | f8cd06753755 |
rev | line source |
---|---|
4554
fbf9f873abfc
[gaim-migrate @ 4834]
Christian Hammond <chipx86@chipx86.com>
parents:
3726
diff
changeset
|
1 EXTRA_DIST = \ |
7960 | 2 COPYRIGHT \ |
6198
fcc28f5dd0c8
[gaim-migrate @ 6684]
Herman Bloggs <hermanator12002@yahoo.com>
parents:
6187
diff
changeset
|
3 Doxyfile.in \ |
9364 | 4 gaim.pc.in \ |
6198
fcc28f5dd0c8
[gaim-migrate @ 6684]
Herman Bloggs <hermanator12002@yahoo.com>
parents:
6187
diff
changeset
|
5 gaim.spec.in \ |
10362 | 6 gaim.apspec.in \ |
6198
fcc28f5dd0c8
[gaim-migrate @ 6684]
Herman Bloggs <hermanator12002@yahoo.com>
parents:
6187
diff
changeset
|
7 gaim.desktop \ |
7601
6d59800ace03
[gaim-migrate @ 8223]
Herman Bloggs <hermanator12002@yahoo.com>
parents:
7231
diff
changeset
|
8 gaim-installer.nsi \ |
6198
fcc28f5dd0c8
[gaim-migrate @ 6684]
Herman Bloggs <hermanator12002@yahoo.com>
parents:
6187
diff
changeset
|
9 HACKING \ |
6246 | 10 PROGRAMMING_NOTES \ |
6198
fcc28f5dd0c8
[gaim-migrate @ 6684]
Herman Bloggs <hermanator12002@yahoo.com>
parents:
6187
diff
changeset
|
11 setup-gettext \ |
fcc28f5dd0c8
[gaim-migrate @ 6684]
Herman Bloggs <hermanator12002@yahoo.com>
parents:
6187
diff
changeset
|
12 ChangeLog.win32 \ |
fcc28f5dd0c8
[gaim-migrate @ 6684]
Herman Bloggs <hermanator12002@yahoo.com>
parents:
6187
diff
changeset
|
13 config.h.mingw \ |
fcc28f5dd0c8
[gaim-migrate @ 6684]
Herman Bloggs <hermanator12002@yahoo.com>
parents:
6187
diff
changeset
|
14 Makefile.mingw \ |
fcc28f5dd0c8
[gaim-migrate @ 6684]
Herman Bloggs <hermanator12002@yahoo.com>
parents:
6187
diff
changeset
|
15 README.mingw \ |
fcc28f5dd0c8
[gaim-migrate @ 6684]
Herman Bloggs <hermanator12002@yahoo.com>
parents:
6187
diff
changeset
|
16 VERSION \ |
9137
63565de253af
[gaim-migrate @ 9921]
Christian Hammond <chipx86@chipx86.com>
parents:
9099
diff
changeset
|
17 VERSION.in \ |
6198
fcc28f5dd0c8
[gaim-migrate @ 6684]
Herman Bloggs <hermanator12002@yahoo.com>
parents:
6187
diff
changeset
|
18 plugins/win32/transparency/Makefile.mingw \ |
fcc28f5dd0c8
[gaim-migrate @ 6684]
Herman Bloggs <hermanator12002@yahoo.com>
parents:
6187
diff
changeset
|
19 plugins/win32/transparency/win2ktrans.c \ |
6411
0d0bdf0bf6d2
[gaim-migrate @ 6917]
Herman Bloggs <hermanator12002@yahoo.com>
parents:
6246
diff
changeset
|
20 plugins/win32/winprefs/gtkappbar.c \ |
0d0bdf0bf6d2
[gaim-migrate @ 6917]
Herman Bloggs <hermanator12002@yahoo.com>
parents:
6246
diff
changeset
|
21 plugins/win32/winprefs/gtkappbar.h \ |
6198
fcc28f5dd0c8
[gaim-migrate @ 6684]
Herman Bloggs <hermanator12002@yahoo.com>
parents:
6187
diff
changeset
|
22 plugins/win32/winprefs/Makefile.mingw \ |
fcc28f5dd0c8
[gaim-migrate @ 6684]
Herman Bloggs <hermanator12002@yahoo.com>
parents:
6187
diff
changeset
|
23 plugins/win32/winprefs/winprefs.c \ |
fcc28f5dd0c8
[gaim-migrate @ 6684]
Herman Bloggs <hermanator12002@yahoo.com>
parents:
6187
diff
changeset
|
24 po/Makefile.mingw |
0 | 25 |
9364 | 26 gaimincludedir=$(includedir)/gaim |
27 gaiminclude_HEADERS = config.h | |
28 | |
29 pkgconfigdir = $(libdir)/pkgconfig | |
30 pkgconfig_DATA = gaim.pc | |
31 | |
3449
8c6950b6eb82
[gaim-migrate @ 3493]
Christian Hammond <chipx86@chipx86.com>
parents:
3439
diff
changeset
|
32 dist-hook: gaim.spec |
8c6950b6eb82
[gaim-migrate @ 3493]
Christian Hammond <chipx86@chipx86.com>
parents:
3439
diff
changeset
|
33 cp gaim.spec $(distdir) |
8c6950b6eb82
[gaim-migrate @ 3493]
Christian Hammond <chipx86@chipx86.com>
parents:
3439
diff
changeset
|
34 |
6701
b7e113a59b51
[gaim-migrate @ 7227]
Christian Hammond <chipx86@chipx86.com>
parents:
6596
diff
changeset
|
35 distcheck-hook: plugins/perl/common/Gaim.pm |
b7e113a59b51
[gaim-migrate @ 7227]
Christian Hammond <chipx86@chipx86.com>
parents:
6596
diff
changeset
|
36 # cp plugins/perl/common/Gaim.pm $(distdir)/plugins/perl/common |
b7e113a59b51
[gaim-migrate @ 7227]
Christian Hammond <chipx86@chipx86.com>
parents:
6596
diff
changeset
|
37 |
5253
2c9de5ae24a0
[gaim-migrate @ 5625]
Christian Hammond <chipx86@chipx86.com>
parents:
4564
diff
changeset
|
38 appsdir = $(datadir)/applications |
2c9de5ae24a0
[gaim-migrate @ 5625]
Christian Hammond <chipx86@chipx86.com>
parents:
4564
diff
changeset
|
39 apps_DATA = gaim.desktop |
327 | 40 |
11147
616feca04ada
[gaim-migrate @ 13226]
Gary Kramlich <grim@reaperworld.com>
parents:
11050
diff
changeset
|
41 SUBDIRS = doc intl m4macros pixmaps plugins po sounds src |
4554
fbf9f873abfc
[gaim-migrate @ 4834]
Christian Hammond <chipx86@chipx86.com>
parents:
3726
diff
changeset
|
42 |
6596
dcb336f3d9a6
[gaim-migrate @ 7120]
Christian Hammond <chipx86@chipx86.com>
parents:
6411
diff
changeset
|
43 docs: Doxyfile |
10925
993db24dae16
[gaim-migrate @ 12696]
Gary Kramlich <grim@reaperworld.com>
parents:
10362
diff
changeset
|
44 if HAVE_DOXYGEN |
993db24dae16
[gaim-migrate @ 12696]
Gary Kramlich <grim@reaperworld.com>
parents:
10362
diff
changeset
|
45 @echo "Running doxygen..." |
4554
fbf9f873abfc
[gaim-migrate @ 4834]
Christian Hammond <chipx86@chipx86.com>
parents:
3726
diff
changeset
|
46 @doxygen |
10925
993db24dae16
[gaim-migrate @ 12696]
Gary Kramlich <grim@reaperworld.com>
parents:
10362
diff
changeset
|
47 else |
993db24dae16
[gaim-migrate @ 12696]
Gary Kramlich <grim@reaperworld.com>
parents:
10362
diff
changeset
|
48 @echo "doxygen was not found during configure. Aborting." |
993db24dae16
[gaim-migrate @ 12696]
Gary Kramlich <grim@reaperworld.com>
parents:
10362
diff
changeset
|
49 @echo; |
993db24dae16
[gaim-migrate @ 12696]
Gary Kramlich <grim@reaperworld.com>
parents:
10362
diff
changeset
|
50 endif |