Mercurial > pidgin.yaz
annotate autogen.sh @ 11719:109ee3bfeac5
[gaim-migrate @ 14010]
SF Patch #1333770 from corfe83
"Many times in gaim we use the function
g_slist_remove(list,node->data) to remove an element
from a GSList. If we already have the pointer to the
node we want to delete, it is faster to send it the
pointer to the node to delete rather than the data of
the node (we can do this by calling
g_slist_delete_link(list,node)). This change was made
while looking at glib's documentation and the code in
glib's gslist.c.
This is because as the remove/delete function traverses
each node in the list, it doesn't need to spend an
extra memory access to retrieve the data for each
element in the node it is traversing and then compare,
it can simply compare the pointer. In my tests outside
of gaim, this makes a big difference if the node you
are deleting is at a high index in the list. However,
even if you're deleting the first node, it about breaks
even.
So, I've found each case in gaim where we are calling
g_slist_remove, and we already have the pointer to the
appropriate node to delete (this is often the case when
we're doing a for or while loop on a GSList). I've then
replaced it with the appropriate call to
g_slist_delete_link. I, however, didn't do this in
situations where we are explicitly removing the first
element in the list, because in those situations it is
an unnecessary change.
There should be no difference in behavior, but just in
case I've tried running it with valgrind, which reports
the same number of memory leaks after my patch as
before my patch. Of course, I can't guarantee that my
normal behavior on gaim is hitting all the functions
I've changed, but in general testing it Works For Me (tm)."
As with the last patch, this one may not have a practical performance impact (or maybe it does, I have no idea), but it's not worse for any case. Given two ways of doing things where one is always at least as fast and may be faster under some cases, I like to prefer that faster way. This doesn't make the code any uglier, so I'm applying.
committer: Tailor Script <tailor@pidgin.im>
author | Richard Laager <rlaager@wiktel.com> |
---|---|
date | Sat, 22 Oct 2005 20:48:18 +0000 |
parents | d881871490dd |
children | e67993da8a22 |
rev | line source |
---|---|
2275
f7bf34a3b535
[gaim-migrate @ 2285]
Eric Warmenhoven <eric@warmenhoven.org>
parents:
2177
diff
changeset
|
1 #!/bin/sh |
1863 | 2 |
3414
4149e5e36eb9
[gaim-migrate @ 3433]
Christian Hammond <chipx86@chipx86.com>
parents:
3413
diff
changeset
|
3 SETUP_GETTEXT=./setup-gettext |
3388
83314a9985ef
[gaim-migrate @ 3407]
Christian Hammond <chipx86@chipx86.com>
parents:
3174
diff
changeset
|
4 |
3414
4149e5e36eb9
[gaim-migrate @ 3433]
Christian Hammond <chipx86@chipx86.com>
parents:
3413
diff
changeset
|
5 ($SETUP_GETTEXT --gettext-tool) < /dev/null > /dev/null 2>&1 || { |
4149e5e36eb9
[gaim-migrate @ 3433]
Christian Hammond <chipx86@chipx86.com>
parents:
3413
diff
changeset
|
6 echo; |
4149e5e36eb9
[gaim-migrate @ 3433]
Christian Hammond <chipx86@chipx86.com>
parents:
3413
diff
changeset
|
7 echo "You must have gettext installed to compile Gaim"; |
4149e5e36eb9
[gaim-migrate @ 3433]
Christian Hammond <chipx86@chipx86.com>
parents:
3413
diff
changeset
|
8 echo; |
4149e5e36eb9
[gaim-migrate @ 3433]
Christian Hammond <chipx86@chipx86.com>
parents:
3413
diff
changeset
|
9 exit; |
1863 | 10 } |
11 | |
12 (libtoolize --version) < /dev/null > /dev/null 2>&1 || { | |
13 echo; | |
14 echo "You must have libtool installed to compile Gaim"; | |
15 echo; | |
16 exit; | |
17 } | |
18 | |
19 (automake --version) < /dev/null > /dev/null 2>&1 || { | |
20 echo; | |
21 echo "You must have automake installed to compile Gaim"; | |
22 echo; | |
23 exit; | |
24 } | |
25 | |
26 (autoconf --version) < /dev/null > /dev/null 2>&1 || { | |
27 echo; | |
28 echo "You must have autoconf installed to compile Gaim"; | |
29 echo; | |
30 exit; | |
31 } | |
32 | |
33 echo "Generating configuration files for Gaim, please wait...." | |
34 echo; | |
35 | |
3444
d5bb9c7b6e0a
[gaim-migrate @ 3485]
Christian Hammond <chipx86@chipx86.com>
parents:
3414
diff
changeset
|
36 # Backup the po/ChangeLog. This should prevent the annoying |
d5bb9c7b6e0a
[gaim-migrate @ 3485]
Christian Hammond <chipx86@chipx86.com>
parents:
3414
diff
changeset
|
37 # gettext ChangeLog modifications. |
d5bb9c7b6e0a
[gaim-migrate @ 3485]
Christian Hammond <chipx86@chipx86.com>
parents:
3414
diff
changeset
|
38 |
d5bb9c7b6e0a
[gaim-migrate @ 3485]
Christian Hammond <chipx86@chipx86.com>
parents:
3414
diff
changeset
|
39 cp -p po/ChangeLog po/ChangeLog.save |
d5bb9c7b6e0a
[gaim-migrate @ 3485]
Christian Hammond <chipx86@chipx86.com>
parents:
3414
diff
changeset
|
40 |
1863 | 41 echo "Running gettextize, please ignore non-fatal messages...." |
3414
4149e5e36eb9
[gaim-migrate @ 3433]
Christian Hammond <chipx86@chipx86.com>
parents:
3413
diff
changeset
|
42 $SETUP_GETTEXT |
3407
02a10c03e3e1
[gaim-migrate @ 3426]
Christian Hammond <chipx86@chipx86.com>
parents:
3405
diff
changeset
|
43 |
3444
d5bb9c7b6e0a
[gaim-migrate @ 3485]
Christian Hammond <chipx86@chipx86.com>
parents:
3414
diff
changeset
|
44 # Restore the po/ChangeLog file. |
d5bb9c7b6e0a
[gaim-migrate @ 3485]
Christian Hammond <chipx86@chipx86.com>
parents:
3414
diff
changeset
|
45 mv po/ChangeLog.save po/ChangeLog |
d5bb9c7b6e0a
[gaim-migrate @ 3485]
Christian Hammond <chipx86@chipx86.com>
parents:
3414
diff
changeset
|
46 |
1863 | 47 echo "Running libtoolize, please ignore non-fatal messages...." |
2754
642413968b03
[gaim-migrate @ 2767]
Eric Warmenhoven <eric@warmenhoven.org>
parents:
2415
diff
changeset
|
48 echo n | libtoolize --copy --force || exit; |
2162
a464da684307
[gaim-migrate @ 2172]
Eric Warmenhoven <eric@warmenhoven.org>
parents:
2157
diff
changeset
|
49 |
3566
1496be1c345c
[gaim-migrate @ 3661]
Christian Hammond <chipx86@chipx86.com>
parents:
3505
diff
changeset
|
50 # Add other directories to this list if people continue to experience |
1496be1c345c
[gaim-migrate @ 3661]
Christian Hammond <chipx86@chipx86.com>
parents:
3505
diff
changeset
|
51 # brokennesses ... Obviously the real answer is for them to fix it |
1496be1c345c
[gaim-migrate @ 3661]
Christian Hammond <chipx86@chipx86.com>
parents:
3505
diff
changeset
|
52 # themselves, but for Luke's sake we have this. |
1496be1c345c
[gaim-migrate @ 3661]
Christian Hammond <chipx86@chipx86.com>
parents:
3505
diff
changeset
|
53 for dir in "/usr/local/share/aclocal" \ |
1496be1c345c
[gaim-migrate @ 3661]
Christian Hammond <chipx86@chipx86.com>
parents:
3505
diff
changeset
|
54 "/opt/gnome-1.4/share/aclocal" |
1496be1c345c
[gaim-migrate @ 3661]
Christian Hammond <chipx86@chipx86.com>
parents:
3505
diff
changeset
|
55 do |
1496be1c345c
[gaim-migrate @ 3661]
Christian Hammond <chipx86@chipx86.com>
parents:
3505
diff
changeset
|
56 if test -d $dir ; then |
1496be1c345c
[gaim-migrate @ 3661]
Christian Hammond <chipx86@chipx86.com>
parents:
3505
diff
changeset
|
57 ACLOCAL_FLAGS="$ACLOCAL_FLAGS -I $dir" |
1496be1c345c
[gaim-migrate @ 3661]
Christian Hammond <chipx86@chipx86.com>
parents:
3505
diff
changeset
|
58 fi |
1496be1c345c
[gaim-migrate @ 3661]
Christian Hammond <chipx86@chipx86.com>
parents:
3505
diff
changeset
|
59 done |
3505 | 60 |
4564 | 61 aclocal $ACLOCAL_FLAGS || exit; |
2754
642413968b03
[gaim-migrate @ 2767]
Eric Warmenhoven <eric@warmenhoven.org>
parents:
2415
diff
changeset
|
62 autoheader || exit; |
2770
24ebd5e321e4
[gaim-migrate @ 2783]
Eric Warmenhoven <eric@warmenhoven.org>
parents:
2754
diff
changeset
|
63 automake --add-missing --copy; |
2754
642413968b03
[gaim-migrate @ 2767]
Eric Warmenhoven <eric@warmenhoven.org>
parents:
2415
diff
changeset
|
64 autoconf || exit; |
642413968b03
[gaim-migrate @ 2767]
Eric Warmenhoven <eric@warmenhoven.org>
parents:
2415
diff
changeset
|
65 automake || exit; |
1863 | 66 ./configure $@ |
67 |