annotate gaim.desktop @ 11719:109ee3bfeac5

[gaim-migrate @ 14010] SF Patch #1333770 from corfe83 "Many times in gaim we use the function g_slist_remove(list,node->data) to remove an element from a GSList. If we already have the pointer to the node we want to delete, it is faster to send it the pointer to the node to delete rather than the data of the node (we can do this by calling g_slist_delete_link(list,node)). This change was made while looking at glib's documentation and the code in glib's gslist.c. This is because as the remove/delete function traverses each node in the list, it doesn't need to spend an extra memory access to retrieve the data for each element in the node it is traversing and then compare, it can simply compare the pointer. In my tests outside of gaim, this makes a big difference if the node you are deleting is at a high index in the list. However, even if you're deleting the first node, it about breaks even. So, I've found each case in gaim where we are calling g_slist_remove, and we already have the pointer to the appropriate node to delete (this is often the case when we're doing a for or while loop on a GSList). I've then replaced it with the appropriate call to g_slist_delete_link. I, however, didn't do this in situations where we are explicitly removing the first element in the list, because in those situations it is an unnecessary change. There should be no difference in behavior, but just in case I've tried running it with valgrind, which reports the same number of memory leaks after my patch as before my patch. Of course, I can't guarantee that my normal behavior on gaim is hitting all the functions I've changed, but in general testing it Works For Me (tm)." As with the last patch, this one may not have a practical performance impact (or maybe it does, I have no idea), but it's not worse for any case. Given two ways of doing things where one is always at least as fast and may be faster under some cases, I like to prefer that faster way. This doesn't make the code any uglier, so I'm applying. committer: Tailor Script <tailor@pidgin.im>
author Richard Laager <rlaager@wiktel.com>
date Sat, 22 Oct 2005 20:48:18 +0000
parents 57e3e958ff49
children 391acec18e46
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
325
9e7d74bc5474 [gaim-migrate @ 335]
Rob Flynn <gaim@robflynn.com>
parents:
diff changeset
1 [Desktop Entry]
3726
d85208a99af2 [gaim-migrate @ 3862]
Luke Schierer <lschiere@pidgin.im>
parents: 3364
diff changeset
2 Encoding=UTF-8
10971
57e3e958ff49 [gaim-migrate @ 12796]
Mark Doliner <mark@kingant.net>
parents: 10938
diff changeset
3 Categories=Application;Network;
57e3e958ff49 [gaim-migrate @ 12796]
Mark Doliner <mark@kingant.net>
parents: 10938
diff changeset
4 Comment=Send instant messages over multiple protocols
57e3e958ff49 [gaim-migrate @ 12796]
Mark Doliner <mark@kingant.net>
parents: 10938
diff changeset
5 Comment[da]=Send beskeder over flere protokoller
57e3e958ff49 [gaim-migrate @ 12796]
Mark Doliner <mark@kingant.net>
parents: 10938
diff changeset
6 Comment[de]=Multi-Protokoll Instant Messenger Client
57e3e958ff49 [gaim-migrate @ 12796]
Mark Doliner <mark@kingant.net>
parents: 10938
diff changeset
7 Comment[es]=Cliente de mensajería instantánea multiprotocolo
57e3e958ff49 [gaim-migrate @ 12796]
Mark Doliner <mark@kingant.net>
parents: 10938
diff changeset
8 Comment[fr]=Client de messagerie instantanée multiprotocole
57e3e958ff49 [gaim-migrate @ 12796]
Mark Doliner <mark@kingant.net>
parents: 10938
diff changeset
9 Comment[hu]=Többprotokollos üzenőkliens
57e3e958ff49 [gaim-migrate @ 12796]
Mark Doliner <mark@kingant.net>
parents: 10938
diff changeset
10 Comment[it]=Client multiprotocollo per messaggi immediati
57e3e958ff49 [gaim-migrate @ 12796]
Mark Doliner <mark@kingant.net>
parents: 10938
diff changeset
11 Comment[ko]=다중 프로토콜 메신저
57e3e958ff49 [gaim-migrate @ 12796]
Mark Doliner <mark@kingant.net>
parents: 10938
diff changeset
12 Comment[nb]=Send lynmeldinger over flere protokoller
57e3e958ff49 [gaim-migrate @ 12796]
Mark Doliner <mark@kingant.net>
parents: 10938
diff changeset
13 Comment[nl]=Multi-protocol programma voor expresberichten
57e3e958ff49 [gaim-migrate @ 12796]
Mark Doliner <mark@kingant.net>
parents: 10938
diff changeset
14 Comment[pl]=Komunikator internetowy obsługujący kilka protokołów
57e3e958ff49 [gaim-migrate @ 12796]
Mark Doliner <mark@kingant.net>
parents: 10938
diff changeset
15 Comment[pt_BR]=Cliente multi-protocolo de mensagens
57e3e958ff49 [gaim-migrate @ 12796]
Mark Doliner <mark@kingant.net>
parents: 10938
diff changeset
16 Comment[pt]=Envie mensagens instantâneas sobre vários protocolos
57e3e958ff49 [gaim-migrate @ 12796]
Mark Doliner <mark@kingant.net>
parents: 10938
diff changeset
17 Comment[sl]=Večprotokolni odjemalec za neposredno sporočanje
57e3e958ff49 [gaim-migrate @ 12796]
Mark Doliner <mark@kingant.net>
parents: 10938
diff changeset
18 Comment[sq]=Dërgoni mesazhe të atypëratyshëm protokollesh të ndryshëm
57e3e958ff49 [gaim-migrate @ 12796]
Mark Doliner <mark@kingant.net>
parents: 10938
diff changeset
19 Comment[sv]=Sänder snabbmeddelande över många protokoll
57e3e958ff49 [gaim-migrate @ 12796]
Mark Doliner <mark@kingant.net>
parents: 10938
diff changeset
20 Comment[zh_CN]=通过多种协议发送即时消息
57e3e958ff49 [gaim-migrate @ 12796]
Mark Doliner <mark@kingant.net>
parents: 10938
diff changeset
21 GenericName=Internet Messenger
57e3e958ff49 [gaim-migrate @ 12796]
Mark Doliner <mark@kingant.net>
parents: 10938
diff changeset
22 GenericName[da]=Internet beskeder
57e3e958ff49 [gaim-migrate @ 12796]
Mark Doliner <mark@kingant.net>
parents: 10938
diff changeset
23 GenericName[fr]=Messagerie instantanée
57e3e958ff49 [gaim-migrate @ 12796]
Mark Doliner <mark@kingant.net>
parents: 10938
diff changeset
24 GenericName[hu]=IM
57e3e958ff49 [gaim-migrate @ 12796]
Mark Doliner <mark@kingant.net>
parents: 10938
diff changeset
25 GenericName[it]=Internet Messenger
57e3e958ff49 [gaim-migrate @ 12796]
Mark Doliner <mark@kingant.net>
parents: 10938
diff changeset
26 GenericName[ko]=메신저
57e3e958ff49 [gaim-migrate @ 12796]
Mark Doliner <mark@kingant.net>
parents: 10938
diff changeset
27 GenericName[nb]=Lynmeldingsklient
57e3e958ff49 [gaim-migrate @ 12796]
Mark Doliner <mark@kingant.net>
parents: 10938
diff changeset
28 GenericName[nl]=Expresberichten
57e3e958ff49 [gaim-migrate @ 12796]
Mark Doliner <mark@kingant.net>
parents: 10938
diff changeset
29 GenericName[pl]=Komunikator Internetowy
57e3e958ff49 [gaim-migrate @ 12796]
Mark Doliner <mark@kingant.net>
parents: 10938
diff changeset
30 GenericName[pt_BR]=Mensageiro da Internet Gaim
57e3e958ff49 [gaim-migrate @ 12796]
Mark Doliner <mark@kingant.net>
parents: 10938
diff changeset
31 GenericName[pt]=Mensageiro Internet
57e3e958ff49 [gaim-migrate @ 12796]
Mark Doliner <mark@kingant.net>
parents: 10938
diff changeset
32 GenericName[sl]=Spletni sel
57e3e958ff49 [gaim-migrate @ 12796]
Mark Doliner <mark@kingant.net>
parents: 10938
diff changeset
33 GenericName[sq]=Lajmësjellës Internet
57e3e958ff49 [gaim-migrate @ 12796]
Mark Doliner <mark@kingant.net>
parents: 10938
diff changeset
34 GenericName[sv]=Meddelandeklient
57e3e958ff49 [gaim-migrate @ 12796]
Mark Doliner <mark@kingant.net>
parents: 10938
diff changeset
35 GenericName[zh_CN]=互联网通讯程序
9338
32d7a35a72d3 [gaim-migrate @ 10146]
Mark Doliner <mark@kingant.net>
parents: 9298
diff changeset
36 Name=Gaim Internet Messenger
10539
5a50946954dd [gaim-migrate @ 11900]
Mark Doliner <mark@kingant.net>
parents: 9844
diff changeset
37 Name[da]=Gaim - internet beskeder
9349
dcda780e9ea6 [gaim-migrate @ 10157]
Luke Schierer <lschiere@pidgin.im>
parents: 9345
diff changeset
38 Name[de]=Gaim Internet Messenger
9344
30454a103cd6 [gaim-migrate @ 10152]
Luke Schierer <lschiere@pidgin.im>
parents: 9338
diff changeset
39 Name[fr]=Gaim Messagerie Instantanée
10821
5533f3131582 [gaim-migrate @ 12480]
Mark Doliner <mark@kingant.net>
parents: 10539
diff changeset
40 Name[hu]=Gaim IM
9361
0f4d49677f84 [gaim-migrate @ 10169]
Luke Schierer <lschiere@pidgin.im>
parents: 9357
diff changeset
41 Name[it]=Gaim Internet Messenger
10539
5a50946954dd [gaim-migrate @ 11900]
Mark Doliner <mark@kingant.net>
parents: 9844
diff changeset
42 Name[ko]=게임 메신저
10971
57e3e958ff49 [gaim-migrate @ 12796]
Mark Doliner <mark@kingant.net>
parents: 10938
diff changeset
43 Name[nb]=Gaim lynmeldingsklient
10539
5a50946954dd [gaim-migrate @ 11900]
Mark Doliner <mark@kingant.net>
parents: 9844
diff changeset
44 Name[nl]=Gaim - Expresberichten
9355
59afa74ecebb [gaim-migrate @ 10163]
Luke Schierer <lschiere@pidgin.im>
parents: 9349
diff changeset
45 Name[pl]=Komunikator Internetowy Gaim
10971
57e3e958ff49 [gaim-migrate @ 12796]
Mark Doliner <mark@kingant.net>
parents: 10938
diff changeset
46 Name[pt]=Mensageiro Internet Gaim
9844
6c421922e143 [gaim-migrate @ 10722]
Luke Schierer <lschiere@pidgin.im>
parents: 9842
diff changeset
47 Name[sl]=Gaim - spletni sel
10971
57e3e958ff49 [gaim-migrate @ 12796]
Mark Doliner <mark@kingant.net>
parents: 10938
diff changeset
48 Name[sq]=Lajmësjellësi Internet Gaim
10539
5a50946954dd [gaim-migrate @ 11900]
Mark Doliner <mark@kingant.net>
parents: 9844
diff changeset
49 Name[sv]=Gaim Internet Messenger
10971
57e3e958ff49 [gaim-migrate @ 12796]
Mark Doliner <mark@kingant.net>
parents: 10938
diff changeset
50 Name[zh_CN]=Gaim 互联网通讯程序
3726
d85208a99af2 [gaim-migrate @ 3862]
Luke Schierer <lschiere@pidgin.im>
parents: 3364
diff changeset
51 Exec=gaim
3364
d4c260bb5b6b [gaim-migrate @ 3383]
Sean Egan <seanegan@gmail.com>
parents: 3246
diff changeset
52 Icon=gaim.png
10971
57e3e958ff49 [gaim-migrate @ 12796]
Mark Doliner <mark@kingant.net>
parents: 10938
diff changeset
53 StartupNotify=true
3726
d85208a99af2 [gaim-migrate @ 3862]
Luke Schierer <lschiere@pidgin.im>
parents: 3364
diff changeset
54 Terminal=false
325
9e7d74bc5474 [gaim-migrate @ 335]
Rob Flynn <gaim@robflynn.com>
parents:
diff changeset
55 Type=Application