annotate pidgin/pidgin-2-uninstalled.pc.in @ 31652:258fec7797b9

Attempt to fix a crash I've seen a few times. I think it happens if you have a conversation window open with a MySpace buddy, then your MySpace account goes offline. We apparently call the prpl's status_text prpl function to get the status text for the buddy, but the connection is offline. I don't know if that's something we SHOULD do or not... but other prpl's seem to handle this, at least. 1. Use buddy->account instead of buddy->account->gc->proto_data->account, since the former should always exist and later doesn't exist if the account is offline. This was leading to a null pointer dereference. 2. Pass FALSE to msim_get_user_from_buddy() so that it will stop creating an MsimUser struct if one doesn't exist. Creating it didn't accomplish anything, and I feel like it might never get freed if the account is already offline. 3. Put the checks for user->headline and user->display_name in a big if condition, so we won't try to grab that info if user is NULL
author Mark Doliner <mark@kingant.net>
date Mon, 14 Feb 2011 01:01:37 +0000
parents a52831eada67
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
29735
a52831eada67 Add pidgin-2 and purple-2 .pc variants
Will Thompson <will.thompson@collabora.co.uk>
parents:
diff changeset
1 prefix=@prefix@
a52831eada67 Add pidgin-2 and purple-2 .pc variants
Will Thompson <will.thompson@collabora.co.uk>
parents:
diff changeset
2 exec_prefix=@exec_prefix@
a52831eada67 Add pidgin-2 and purple-2 .pc variants
Will Thompson <will.thompson@collabora.co.uk>
parents:
diff changeset
3 libdir=@libdir@
a52831eada67 Add pidgin-2 and purple-2 .pc variants
Will Thompson <will.thompson@collabora.co.uk>
parents:
diff changeset
4 includedir=@includedir@
a52831eada67 Add pidgin-2 and purple-2 .pc variants
Will Thompson <will.thompson@collabora.co.uk>
parents:
diff changeset
5 datarootdir=@datarootdir@
a52831eada67 Add pidgin-2 and purple-2 .pc variants
Will Thompson <will.thompson@collabora.co.uk>
parents:
diff changeset
6 datadir=@datadir@
a52831eada67 Add pidgin-2 and purple-2 .pc variants
Will Thompson <will.thompson@collabora.co.uk>
parents:
diff changeset
7 sysconfdir=@sysconfdir@
a52831eada67 Add pidgin-2 and purple-2 .pc variants
Will Thompson <will.thompson@collabora.co.uk>
parents:
diff changeset
8
a52831eada67 Add pidgin-2 and purple-2 .pc variants
Will Thompson <will.thompson@collabora.co.uk>
parents:
diff changeset
9 abs_srcdir=@abs_srcdir@
a52831eada67 Add pidgin-2 and purple-2 .pc variants
Will Thompson <will.thompson@collabora.co.uk>
parents:
diff changeset
10 abs_builddir=@abs_builddir@
a52831eada67 Add pidgin-2 and purple-2 .pc variants
Will Thompson <will.thompson@collabora.co.uk>
parents:
diff changeset
11
a52831eada67 Add pidgin-2 and purple-2 .pc variants
Will Thompson <will.thompson@collabora.co.uk>
parents:
diff changeset
12 abs_top_srcdir=@abs_top_srcdir@
a52831eada67 Add pidgin-2 and purple-2 .pc variants
Will Thompson <will.thompson@collabora.co.uk>
parents:
diff changeset
13 abs_top_builddir=@abs_top_builddir@
a52831eada67 Add pidgin-2 and purple-2 .pc variants
Will Thompson <will.thompson@collabora.co.uk>
parents:
diff changeset
14
a52831eada67 Add pidgin-2 and purple-2 .pc variants
Will Thompson <will.thompson@collabora.co.uk>
parents:
diff changeset
15 plugindir=${libdir}/pidgin
a52831eada67 Add pidgin-2 and purple-2 .pc variants
Will Thompson <will.thompson@collabora.co.uk>
parents:
diff changeset
16
a52831eada67 Add pidgin-2 and purple-2 .pc variants
Will Thompson <will.thompson@collabora.co.uk>
parents:
diff changeset
17 Name: Pidgin
a52831eada67 Add pidgin-2 and purple-2 .pc variants
Will Thompson <will.thompson@collabora.co.uk>
parents:
diff changeset
18 Description: Pidgin is a GTK2-based instant messenger application.
a52831eada67 Add pidgin-2 and purple-2 .pc variants
Will Thompson <will.thompson@collabora.co.uk>
parents:
diff changeset
19 Version: @VERSION@
a52831eada67 Add pidgin-2 and purple-2 .pc variants
Will Thompson <will.thompson@collabora.co.uk>
parents:
diff changeset
20 Requires: gtk+-2.0 purple
a52831eada67 Add pidgin-2 and purple-2 .pc variants
Will Thompson <will.thompson@collabora.co.uk>
parents:
diff changeset
21 Cflags: -I${abs_top_srcdir}