Mercurial > pidgin.yaz
annotate finch/gntprefs.c @ 16628:36981d83b20c
Fix a crash when removing a per-account icon. Here's my explanation:
21:45:22 rlaager: Since we're not saving the buddy icon path to disk (which, as I mentioned earlier, only exists because of QQ), we end up with that being NULL, which is fine.
21:46:08 rlaager: Where fine = fine, as long as we don't care about QQ and if we do, my changes didn't change that behavior, so it's no worse. ;)
21:46:33 rlaager: The crash in the buddy icon code happens because filename is NULL. In that case, we can return, because the image_deleting_cb is only concerned with those PurpleStoredImages that were created by the buddy icon code. I'll commit the fix.
author | Richard Laager <rlaager@wiktel.com> |
---|---|
date | Sun, 29 Apr 2007 02:49:23 +0000 |
parents | ac0d07c7fd90 |
children | beb960114f7d |
rev | line source |
---|---|
15818 | 1 /** |
2 * @file gntprefs.c GNT Preferences API | |
16194
0f0832c13fcb
Rename the Doxygen group from gntui to finch and define the finch group
Richard Laager <rlaager@wiktel.com>
parents:
15871
diff
changeset
|
3 * @ingroup finch |
15818 | 4 * |
15871
66dff3dfdea6
Re-sed the copyright notices so they don't all talk about Purple.
Richard Laager <rlaager@wiktel.com>
parents:
15823
diff
changeset
|
5 * finch |
15818 | 6 * |
15871
66dff3dfdea6
Re-sed the copyright notices so they don't all talk about Purple.
Richard Laager <rlaager@wiktel.com>
parents:
15823
diff
changeset
|
7 * Finch is the legal property of its developers, whose names are too numerous |
15818 | 8 * to list here. Please refer to the COPYRIGHT file distributed with this |
9 * source distribution. | |
10 * | |
11 * This program is free software; you can redistribute it and/or modify | |
12 * it under the terms of the GNU General Public License as published by | |
13 * the Free Software Foundation; either version 2 of the License, or | |
14 * (at your option) any later version. | |
15 * | |
16 * This program is distributed in the hope that it will be useful, | |
17 * but WITHOUT ANY WARRANTY; without even the implied warranty of | |
18 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | |
19 * GNU General Public License for more details. | |
20 * | |
21 * You should have received a copy of the GNU General Public License | |
22 * along with this program; if not, write to the Free Software | |
23 * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA | |
24 */ | |
25 #include <prefs.h> | |
26 #include <savedstatuses.h> | |
27 | |
15823 | 28 #include "finch.h" |
15818 | 29 #include "gntprefs.h" |
30 #include "gntrequest.h" | |
31 | |
32 #include <string.h> | |
33 | |
34 static GList *freestrings; /* strings to be freed when the pref-window is closed */ | |
35 | |
36 void finch_prefs_init() | |
37 { | |
16427
4999bbc52881
Works for me! Renames prefs: /core to /purple, /gaim/gtk to /pidgin, /gaim/gnt to /finch
Sean Egan <seanegan@gmail.com>
parents:
16310
diff
changeset
|
38 purple_prefs_add_none("/finch"); |
4999bbc52881
Works for me! Renames prefs: /core to /purple, /gaim/gtk to /pidgin, /gaim/gnt to /finch
Sean Egan <seanegan@gmail.com>
parents:
16310
diff
changeset
|
39 |
4999bbc52881
Works for me! Renames prefs: /core to /purple, /gaim/gtk to /pidgin, /gaim/gnt to /finch
Sean Egan <seanegan@gmail.com>
parents:
16310
diff
changeset
|
40 purple_prefs_add_none("/finch/plugins"); |
4999bbc52881
Works for me! Renames prefs: /core to /purple, /gaim/gtk to /pidgin, /gaim/gnt to /finch
Sean Egan <seanegan@gmail.com>
parents:
16310
diff
changeset
|
41 purple_prefs_add_path_list("/finch/plugins/loaded", NULL); |
15818 | 42 |
16427
4999bbc52881
Works for me! Renames prefs: /core to /purple, /gaim/gtk to /pidgin, /gaim/gnt to /finch
Sean Egan <seanegan@gmail.com>
parents:
16310
diff
changeset
|
43 purple_prefs_add_none("/finch/conversations"); |
4999bbc52881
Works for me! Renames prefs: /core to /purple, /gaim/gtk to /pidgin, /gaim/gnt to /finch
Sean Egan <seanegan@gmail.com>
parents:
16310
diff
changeset
|
44 purple_prefs_add_bool("/finch/conversations/timestamps", TRUE); |
16573
ac0d07c7fd90
Pref migration for finch.
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
16442
diff
changeset
|
45 purple_prefs_add_bool("/finch/conversations/notify_typing", FALSE); |
ac0d07c7fd90
Pref migration for finch.
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
16442
diff
changeset
|
46 } |
ac0d07c7fd90
Pref migration for finch.
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
16442
diff
changeset
|
47 |
ac0d07c7fd90
Pref migration for finch.
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
16442
diff
changeset
|
48 void finch_prefs_update_old() |
ac0d07c7fd90
Pref migration for finch.
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
16442
diff
changeset
|
49 { |
ac0d07c7fd90
Pref migration for finch.
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
16442
diff
changeset
|
50 const char *str = NULL; |
ac0d07c7fd90
Pref migration for finch.
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
16442
diff
changeset
|
51 |
16427
4999bbc52881
Works for me! Renames prefs: /core to /purple, /gaim/gtk to /pidgin, /gaim/gnt to /finch
Sean Egan <seanegan@gmail.com>
parents:
16310
diff
changeset
|
52 purple_prefs_rename("/gaim/gnt", "/finch"); |
4999bbc52881
Works for me! Renames prefs: /core to /purple, /gaim/gtk to /pidgin, /gaim/gnt to /finch
Sean Egan <seanegan@gmail.com>
parents:
16310
diff
changeset
|
53 purple_prefs_rename("/purple/gnt", "/finch"); |
16573
ac0d07c7fd90
Pref migration for finch.
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
16442
diff
changeset
|
54 |
ac0d07c7fd90
Pref migration for finch.
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
16442
diff
changeset
|
55 if ((str = purple_prefs_get_string("/purple/away/idle_reporting")) && |
ac0d07c7fd90
Pref migration for finch.
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
16442
diff
changeset
|
56 strcmp(str, "gaim") == 0) |
ac0d07c7fd90
Pref migration for finch.
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
16442
diff
changeset
|
57 purple_prefs_set_string("/purple/away/idle_reporting", "purple"); |
15818 | 58 } |
59 | |
60 typedef struct | |
61 { | |
15823 | 62 PurplePrefType type; |
15818 | 63 const char *pref; |
64 const char *label; | |
65 GList *(*lv)(); /* If the value is to be selected from a number of choices */ | |
66 } Prefs; | |
67 | |
68 static GList * | |
69 get_log_options() | |
70 { | |
15823 | 71 return purple_log_logger_get_options(); |
15818 | 72 } |
73 | |
74 static GList * | |
75 get_idle_options() | |
76 { | |
77 GList *list = NULL; | |
78 list = g_list_append(list, "Based on keyboard use"); /* XXX: string freeze */ | |
79 list = g_list_append(list, "system"); | |
80 list = g_list_append(list, (char*)_("From last sent message")); | |
15823 | 81 list = g_list_append(list, "purple"); |
15818 | 82 list = g_list_append(list, (char*)_("Never")); |
83 list = g_list_append(list, "never"); | |
84 return list; | |
85 } | |
86 | |
87 static GList * | |
88 get_status_titles() | |
89 { | |
90 GList *list = NULL; | |
91 const GList *iter; | |
15823 | 92 for (iter = purple_savedstatuses_get_all(); iter; iter = iter->next) { |
15818 | 93 char *str; |
15823 | 94 if (purple_savedstatus_is_transient(iter->data)) |
15818 | 95 continue; |
15823 | 96 str = g_strdup_printf("%ld", purple_savedstatus_get_creation_time(iter->data)); |
97 list = g_list_append(list, (char*)purple_savedstatus_get_title(iter->data)); | |
15818 | 98 list = g_list_append(list, str); |
99 freestrings = g_list_prepend(freestrings, str); | |
100 } | |
101 return list; | |
102 } | |
103 | |
15823 | 104 static PurpleRequestField * |
15818 | 105 get_pref_field(Prefs *prefs) |
106 { | |
15823 | 107 PurpleRequestField *field = NULL; |
15818 | 108 |
109 if (prefs->lv == NULL) | |
110 { | |
111 switch (prefs->type) | |
112 { | |
15823 | 113 case PURPLE_PREF_BOOLEAN: |
114 field = purple_request_field_bool_new(prefs->pref, _(prefs->label), | |
115 purple_prefs_get_bool(prefs->pref)); | |
15818 | 116 break; |
15823 | 117 case PURPLE_PREF_INT: |
118 field = purple_request_field_int_new(prefs->pref, _(prefs->label), | |
119 purple_prefs_get_int(prefs->pref)); | |
15818 | 120 break; |
15823 | 121 case PURPLE_PREF_STRING: |
122 field = purple_request_field_string_new(prefs->pref, _(prefs->label), | |
123 purple_prefs_get_string(prefs->pref), FALSE); | |
15818 | 124 break; |
125 default: | |
126 break; | |
127 } | |
128 } | |
129 else | |
130 { | |
131 GList *list = prefs->lv(), *iter; | |
132 if (list) | |
15823 | 133 field = purple_request_field_list_new(prefs->pref, _(prefs->label)); |
15818 | 134 for (iter = list; iter; iter = iter->next) |
135 { | |
136 gboolean select = FALSE; | |
137 const char *data = iter->data; | |
138 int idata; | |
139 iter = iter->next; | |
140 switch (prefs->type) | |
141 { | |
15823 | 142 case PURPLE_PREF_BOOLEAN: |
15818 | 143 sscanf(iter->data, "%d", &idata); |
15823 | 144 if (purple_prefs_get_bool(prefs->pref) == idata) |
15818 | 145 select = TRUE; |
146 break; | |
15823 | 147 case PURPLE_PREF_INT: |
15818 | 148 sscanf(iter->data, "%d", &idata); |
15823 | 149 if (purple_prefs_get_int(prefs->pref) == idata) |
15818 | 150 select = TRUE; |
151 break; | |
15823 | 152 case PURPLE_PREF_STRING: |
153 if (strcmp(purple_prefs_get_string(prefs->pref), iter->data) == 0) | |
15818 | 154 select = TRUE; |
155 break; | |
156 default: | |
157 break; | |
158 } | |
15823 | 159 purple_request_field_list_add(field, data, iter->data); |
15818 | 160 if (select) |
15823 | 161 purple_request_field_list_add_selected(field, data); |
15818 | 162 } |
163 g_list_free(list); | |
164 } | |
165 return field; | |
166 } | |
167 | |
168 static Prefs blist[] = | |
169 { | |
16427
4999bbc52881
Works for me! Renames prefs: /core to /purple, /gaim/gtk to /pidgin, /gaim/gnt to /finch
Sean Egan <seanegan@gmail.com>
parents:
16310
diff
changeset
|
170 {PURPLE_PREF_BOOLEAN, "/finch/blist/idletime", N_("Show Idle Time"), NULL}, |
4999bbc52881
Works for me! Renames prefs: /core to /purple, /gaim/gtk to /pidgin, /gaim/gnt to /finch
Sean Egan <seanegan@gmail.com>
parents:
16310
diff
changeset
|
171 {PURPLE_PREF_BOOLEAN, "/finch/blist/showoffline", N_("Show Offline Buddies"), NULL}, |
15823 | 172 {PURPLE_PREF_NONE, NULL, NULL, NULL} |
15818 | 173 }; |
174 | |
175 static Prefs convs[] = | |
176 { | |
16427
4999bbc52881
Works for me! Renames prefs: /core to /purple, /gaim/gtk to /pidgin, /gaim/gnt to /finch
Sean Egan <seanegan@gmail.com>
parents:
16310
diff
changeset
|
177 {PURPLE_PREF_BOOLEAN, "/finch/conversations/timestamps", N_("Show Timestamps"), NULL}, |
4999bbc52881
Works for me! Renames prefs: /core to /purple, /gaim/gtk to /pidgin, /gaim/gnt to /finch
Sean Egan <seanegan@gmail.com>
parents:
16310
diff
changeset
|
178 {PURPLE_PREF_BOOLEAN, "/finch/conversations/notify_typing", N_("Notify buddies when you are typing"), NULL}, |
15823 | 179 {PURPLE_PREF_NONE, NULL, NULL, NULL} |
15818 | 180 }; |
181 | |
182 static Prefs logging[] = | |
183 { | |
16427
4999bbc52881
Works for me! Renames prefs: /core to /purple, /gaim/gtk to /pidgin, /gaim/gnt to /finch
Sean Egan <seanegan@gmail.com>
parents:
16310
diff
changeset
|
184 {PURPLE_PREF_STRING, "/purple/logging/format", N_("Log format"), get_log_options}, |
4999bbc52881
Works for me! Renames prefs: /core to /purple, /gaim/gtk to /pidgin, /gaim/gnt to /finch
Sean Egan <seanegan@gmail.com>
parents:
16310
diff
changeset
|
185 {PURPLE_PREF_BOOLEAN, "/purple/logging/log_ims", N_("Log IMs"), NULL}, |
4999bbc52881
Works for me! Renames prefs: /core to /purple, /gaim/gtk to /pidgin, /gaim/gnt to /finch
Sean Egan <seanegan@gmail.com>
parents:
16310
diff
changeset
|
186 {PURPLE_PREF_BOOLEAN, "/purple/logging/log_chats", N_("Log chats"), NULL}, |
4999bbc52881
Works for me! Renames prefs: /core to /purple, /gaim/gtk to /pidgin, /gaim/gnt to /finch
Sean Egan <seanegan@gmail.com>
parents:
16310
diff
changeset
|
187 {PURPLE_PREF_BOOLEAN, "/purple/logging/log_system", N_("Log status change events"), NULL}, |
15823 | 188 {PURPLE_PREF_NONE, NULL, NULL, NULL}, |
15818 | 189 }; |
190 | |
191 /* XXX: Translate after the freeze */ | |
192 static Prefs idle[] = | |
193 { | |
16427
4999bbc52881
Works for me! Renames prefs: /core to /purple, /gaim/gtk to /pidgin, /gaim/gnt to /finch
Sean Egan <seanegan@gmail.com>
parents:
16310
diff
changeset
|
194 {PURPLE_PREF_STRING, "/purple/away/idle_reporting", "Report Idle time", get_idle_options}, |
4999bbc52881
Works for me! Renames prefs: /core to /purple, /gaim/gtk to /pidgin, /gaim/gnt to /finch
Sean Egan <seanegan@gmail.com>
parents:
16310
diff
changeset
|
195 {PURPLE_PREF_BOOLEAN, "/purple/away/away_when_idle", "Change status when idle", NULL}, |
4999bbc52881
Works for me! Renames prefs: /core to /purple, /gaim/gtk to /pidgin, /gaim/gnt to /finch
Sean Egan <seanegan@gmail.com>
parents:
16310
diff
changeset
|
196 {PURPLE_PREF_INT, "/purple/away/mins_before_away", "Minutes before changing status", NULL}, |
4999bbc52881
Works for me! Renames prefs: /core to /purple, /gaim/gtk to /pidgin, /gaim/gnt to /finch
Sean Egan <seanegan@gmail.com>
parents:
16310
diff
changeset
|
197 {PURPLE_PREF_INT, "/purple/savedstatus/idleaway", "Change status to", get_status_titles}, |
15823 | 198 {PURPLE_PREF_NONE, NULL, NULL, NULL}, |
15818 | 199 }; |
200 | |
201 static void | |
202 free_strings() | |
203 { | |
204 g_list_foreach(freestrings, (GFunc)g_free, NULL); | |
205 g_list_free(freestrings); | |
206 freestrings = NULL; | |
207 } | |
208 | |
209 static void | |
15823 | 210 save_cb(void *data, PurpleRequestFields *allfields) |
15818 | 211 { |
16310
8c89913276b3
Implement the plugin-pref ui using the request api. The preferences for the core plugins can now be modified from Finch. And no new strings.
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
16194
diff
changeset
|
212 finch_request_save_in_prefs(data, allfields); |
15818 | 213 free_strings(); |
214 } | |
215 | |
216 static void | |
15823 | 217 add_pref_group(PurpleRequestFields *fields, const char *title, Prefs *prefs) |
15818 | 218 { |
15823 | 219 PurpleRequestField *field; |
220 PurpleRequestFieldGroup *group; | |
15818 | 221 int i; |
222 | |
15823 | 223 group = purple_request_field_group_new(title); |
224 purple_request_fields_add_group(fields, group); | |
15818 | 225 for (i = 0; prefs[i].pref; i++) |
226 { | |
227 field = get_pref_field(prefs + i); | |
228 if (field) | |
15823 | 229 purple_request_field_group_add_field(group, field); |
15818 | 230 } |
231 } | |
232 | |
233 void finch_prefs_show_all() | |
234 { | |
15823 | 235 PurpleRequestFields *fields; |
15818 | 236 |
15823 | 237 fields = purple_request_fields_new(); |
15818 | 238 |
239 add_pref_group(fields, _("Buddy List"), blist); | |
240 add_pref_group(fields, _("Conversations"), convs); | |
241 add_pref_group(fields, _("Logging"), logging); | |
242 add_pref_group(fields, _("Idle"), idle); | |
243 | |
15823 | 244 purple_request_fields(NULL, _("Preferences"), NULL, NULL, fields, |
16442
08db93bbd798
Added account, who, and conversation parameters to the request API calls, and updated all code to match. I can't compile the Perl module, so I'd appreciate it if someone who knows it would verify that this doesn't break Perl.
Evan Schoenberg <evan.s@dreskin.net>
parents:
16427
diff
changeset
|
245 _("Save"), G_CALLBACK(save_cb), _("Cancel"), free_strings, |
08db93bbd798
Added account, who, and conversation parameters to the request API calls, and updated all code to match. I can't compile the Perl module, so I'd appreciate it if someone who knows it would verify that this doesn't break Perl.
Evan Schoenberg <evan.s@dreskin.net>
parents:
16427
diff
changeset
|
246 NULL, NULL, NULL, |
08db93bbd798
Added account, who, and conversation parameters to the request API calls, and updated all code to match. I can't compile the Perl module, so I'd appreciate it if someone who knows it would verify that this doesn't break Perl.
Evan Schoenberg <evan.s@dreskin.net>
parents:
16427
diff
changeset
|
247 NULL); |
15818 | 248 } |
249 |