annotate doc/cmd-signals.dox @ 23995:85bed17fe5c1

The variable we use to keep track of the watcher of the ssl connection should be unsigned. This isn't really a problem in Pidgin, where we use glib's mainloop and GIOChannels because glib starts assigning the handle IDs sequentially starting from 1. But if an eventloop implementation ever returns a handle ID greater than the largest possible signed integer (2,147,483,647) then we won't be able to remove the watcher because purple_ssl_close() in sslconn.c only removes it if inpa > 0, and since it interprets inpa as a signed value then handles over 2,147,483,647 appear as negative numbers. I stumbled upon this when playing around with libevent, which can use epoll. My implementation generated a random handle ID which was sometimes greater than 2,147,483,647. I don't believe this breaks binary compatibility. And I don't think it breaks source compatibility, but I guess it might depend on what compiler you're using.
author Mark Doliner <mark@kingant.net>
date Thu, 04 Sep 2008 18:04:29 +0000
parents 1ca49b349037
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
23416
1ca49b349037 Document the command signals.
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
diff changeset
1 /** @page cmd-signals Command Signals
1ca49b349037 Document the command signals.
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
diff changeset
2 @signals
1ca49b349037 Document the command signals.
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
diff changeset
3 @signal cmd-added
1ca49b349037 Document the command signals.
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
diff changeset
4 @signal cmd-removed
1ca49b349037 Document the command signals.
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
diff changeset
5 @endsignals
1ca49b349037 Document the command signals.
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
diff changeset
6
1ca49b349037 Document the command signals.
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
diff changeset
7 @see cmds.h
1ca49b349037 Document the command signals.
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
diff changeset
8
1ca49b349037 Document the command signals.
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
diff changeset
9 @signaldef cmd-added
1ca49b349037 Document the command signals.
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
diff changeset
10 @signalproto
1ca49b349037 Document the command signals.
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
diff changeset
11 void (*cmd_added)(const char *command, PurpleCmdPriority priority,
1ca49b349037 Document the command signals.
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
diff changeset
12 PurpleCmdFlag flag);
1ca49b349037 Document the command signals.
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
diff changeset
13 @endsignalproto
1ca49b349037 Document the command signals.
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
diff changeset
14 @signaldesc
1ca49b349037 Document the command signals.
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
diff changeset
15 Emitted when a new command is added.
1ca49b349037 Document the command signals.
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
diff changeset
16 @param command The new command.
1ca49b349037 Document the command signals.
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
diff changeset
17 @param priority The priority of the new command.
1ca49b349037 Document the command signals.
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
diff changeset
18 @param flag The command flags.
1ca49b349037 Document the command signals.
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
diff changeset
19 @endsignaldef
1ca49b349037 Document the command signals.
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
diff changeset
20
1ca49b349037 Document the command signals.
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
diff changeset
21 @signaldef cmd-removed
1ca49b349037 Document the command signals.
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
diff changeset
22 @signalproto
1ca49b349037 Document the command signals.
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
diff changeset
23 void (*cmd_removed)(const char *command);
1ca49b349037 Document the command signals.
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
diff changeset
24 @endsignalproto
1ca49b349037 Document the command signals.
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
diff changeset
25 @signaldesc
1ca49b349037 Document the command signals.
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
diff changeset
26 Emitted when a command is removed.
1ca49b349037 Document the command signals.
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
diff changeset
27 @param command The removed command.
1ca49b349037 Document the command signals.
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
diff changeset
28 @endsignaldef
1ca49b349037 Document the command signals.
Sadrul Habib Chowdhury <imadil@gmail.com>
parents:
diff changeset
29 */