Mercurial > pidgin.yaz
annotate pidgin.desktop.in @ 23995:85bed17fe5c1
The variable we use to keep track of the watcher of the ssl connection
should be unsigned. This isn't really a problem in Pidgin, where we
use glib's mainloop and GIOChannels because glib starts assigning the
handle IDs sequentially starting from 1.
But if an eventloop implementation ever returns a handle ID greater
than the largest possible signed integer (2,147,483,647) then we
won't be able to remove the watcher because purple_ssl_close() in
sslconn.c only removes it if inpa > 0, and since it interprets inpa
as a signed value then handles over 2,147,483,647 appear as negative
numbers.
I stumbled upon this when playing around with libevent, which can
use epoll. My implementation generated a random handle ID which
was sometimes greater than 2,147,483,647.
I don't believe this breaks binary compatibility. And I don't think
it breaks source compatibility, but I guess it might depend on what
compiler you're using.
author | Mark Doliner <mark@kingant.net> |
---|---|
date | Thu, 04 Sep 2008 18:04:29 +0000 |
parents | ed4ea63c0b45 |
children | 394a6c9b592c 1694eb347a78 |
rev | line source |
---|---|
15479 | 1 [Desktop Entry] |
2 Encoding=UTF-8 | |
3 _Name=Pidgin Internet Messenger | |
4 _GenericName=Internet Messenger | |
5 _Comment=Send instant messages over multiple protocols | |
6 Exec=pidgin | |
16441
ed4ea63c0b45
pidgin.png -> pidgin, to always find appropriate sizes.
Hylke Bons <hylkebons@gmail.com>
parents:
15479
diff
changeset
|
7 Icon=pidgin |
15479 | 8 StartupNotify=true |
9 Terminal=false | |
10 Type=Application | |
11 Categories=Network;InstantMessaging; |