annotate pidgin.desktop.in @ 23995:85bed17fe5c1

The variable we use to keep track of the watcher of the ssl connection should be unsigned. This isn't really a problem in Pidgin, where we use glib's mainloop and GIOChannels because glib starts assigning the handle IDs sequentially starting from 1. But if an eventloop implementation ever returns a handle ID greater than the largest possible signed integer (2,147,483,647) then we won't be able to remove the watcher because purple_ssl_close() in sslconn.c only removes it if inpa > 0, and since it interprets inpa as a signed value then handles over 2,147,483,647 appear as negative numbers. I stumbled upon this when playing around with libevent, which can use epoll. My implementation generated a random handle ID which was sometimes greater than 2,147,483,647. I don't believe this breaks binary compatibility. And I don't think it breaks source compatibility, but I guess it might depend on what compiler you're using.
author Mark Doliner <mark@kingant.net>
date Thu, 04 Sep 2008 18:04:29 +0000
parents ed4ea63c0b45
children 394a6c9b592c 1694eb347a78
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
15479
d2a41819ba6a rename the .desktop file
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
1 [Desktop Entry]
d2a41819ba6a rename the .desktop file
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
2 Encoding=UTF-8
d2a41819ba6a rename the .desktop file
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
3 _Name=Pidgin Internet Messenger
d2a41819ba6a rename the .desktop file
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
4 _GenericName=Internet Messenger
d2a41819ba6a rename the .desktop file
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
5 _Comment=Send instant messages over multiple protocols
d2a41819ba6a rename the .desktop file
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
6 Exec=pidgin
16441
ed4ea63c0b45 pidgin.png -> pidgin, to always find appropriate sizes.
Hylke Bons <hylkebons@gmail.com>
parents: 15479
diff changeset
7 Icon=pidgin
15479
d2a41819ba6a rename the .desktop file
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
8 StartupNotify=true
d2a41819ba6a rename the .desktop file
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
9 Terminal=false
d2a41819ba6a rename the .desktop file
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
10 Type=Application
d2a41819ba6a rename the .desktop file
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
11 Categories=Network;InstantMessaging;