Mercurial > pidgin.yaz
annotate doc/plugin-signals.dox @ 32607:88a46649de3d
Remove a bogus short-circuit check intended to prevent downloading the same icon
every time a buddy logs in. There are three problems with the check:
* The fact that we already have an icon for the buddy doesn't mean it hasn't
changed on the server since we last downloaded.
* We should really be checking against the server-provided checksum, but we
don't know how to checksum the same way the server does.
* We no longer receive a checksum at the YMSG protocol level, so we'd have to
parse such a checksum out of the picture URL, which is going to be fragile
and seems just plain stupid to me.
It seems better to me all around to just axe the check and potentially waste
some bandwidth. If someone wants to figure out a bandwidth-saving fix for this,
feel free.
At any rate, this fixes #13050.
author | John Bailey <rekkanoryo@rekkanoryo.org> |
---|---|
date | Sun, 11 Sep 2011 04:18:46 +0000 |
parents | e0613cf8c493 |
children |
rev | line source |
---|---|
12053 | 1 /** @page plugin-signals Plugin Signals |
2 | |
3 @signals | |
4 @signal plugin-load | |
5 @signal plugin-unload | |
6 @endsignals | |
7 | |
20807
e0613cf8c493
Add some links from signal documentation back to the documentation for the
Will Thompson <will.thompson@collabora.co.uk>
parents:
16183
diff
changeset
|
8 @see plugin.h |
e0613cf8c493
Add some links from signal documentation back to the documentation for the
Will Thompson <will.thompson@collabora.co.uk>
parents:
16183
diff
changeset
|
9 |
12053 | 10 <hr> |
11 | |
12 @signaldef plugin-load | |
13 @signalproto | |
16183
8cf53d7a0887
Update the Doxygen signals documentation to match the new struct names.
Richard Laager <rlaager@wiktel.com>
parents:
12053
diff
changeset
|
14 void (*plugin_load)(PurplePlugin *plugin); |
12053 | 15 @endsignalproto |
16 @signaldesc | |
17 Emitted when a plugin is loaded. | |
18 @param plugin The plugin that was loaded. | |
19 @endsignaldef | |
20 | |
21 @signaldef plugin-unload | |
22 @signalproto | |
16183
8cf53d7a0887
Update the Doxygen signals documentation to match the new struct names.
Richard Laager <rlaager@wiktel.com>
parents:
12053
diff
changeset
|
23 void (*plugin_unload)(PurplePlugin *plugin); |
12053 | 24 @endsignalproto |
25 @signaldesc | |
26 Emitted when a plugin is unloaded. | |
27 @param plugin The plugin that was unloaded. | |
28 @endsignaldef | |
29 | |
30 */ | |
20807
e0613cf8c493
Add some links from signal documentation back to the documentation for the
Will Thompson <will.thompson@collabora.co.uk>
parents:
16183
diff
changeset
|
31 // vim: syntax=c.doxygen tw=75 et |