annotate libpurple/dbus-maybe.h @ 22393:dfe4a3e3336a

serv_got_joined_chat() emits "chat-joined" but it also calls purple_conversation_new() which emits "conversation-created", so attaching to both signals would make create_conv and attach_signals to be called twice, leaking the list of signal ids: ==30871== 67 (43 direct, 24 indirect) bytes in 3 blocks are definitely lost in loss record 94 of 265 ==30871== at 0x4006A6E: malloc (vg_replace_malloc.c:207) ==30871== by 0xA1CAF5: g_malloc (in /lib/libglib-2.0.so.0.1400.6) ==30871== by 0xA31B3A: g_slice_alloc (in /lib/libglib-2.0.so.0.1400.6) ==30871== by 0xA32D9A: g_slist_append (in /lib/libglib-2.0.so.0.1400.6) ==30871== by 0x4F1CA4A: attach_signals (notify.c:321) ==30871== by 0x4F1CDCA: conv_created (notify.c:388) Credit goes to Andrew Gaul for sending me this valgrind trace, blame me if this breaks anything.

/* This file contains macros that wrap calls to the purple dbus module.
   These macros call the appropriate functions if the build includes
   dbus support and do nothing otherwise.  See "dbus-server.h" for
   documentation.  */

#ifndef _PURPLE_DBUS_MAYBE_H_
#define _PURPLE_DBUS_MAYBE_H_

#ifdef HAVE_DBUS

#include "dbus-server.h"

/* this provides a type check */
#define PURPLE_DBUS_REGISTER_POINTER(ptr, type) { \
    type *typed_ptr = ptr; \
    purple_dbus_register_pointer(typed_ptr, PURPLE_DBUS_TYPE(type));	\
}
#define PURPLE_DBUS_UNREGISTER_POINTER(ptr) purple_dbus_unregister_pointer(ptr)

#else  /* !HAVE_DBUS */

#define PURPLE_DBUS_REGISTER_POINTER(ptr, type) 
#define PURPLE_DBUS_UNREGISTER_POINTER(ptr)
#define DBUS_EXPORT

#endif	/* HAVE_DBUS */

#endif