Mercurial > pidgin.yaz

comparison ChangeLog @ 32040:06ed9020b784

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
jabber: Treat empty <group/> elements as "Buddies", not "" This ultimately led to duplicates in the list, because we had one entry in the GSList as "", and one as NULL, both of which are invalid group names, which resulted in the core blithely replacing them with "Buddies" and generating duplicates. I've tested with and without, and can reproduce the issues without the change. Log: <item subscription='both' name='person' jid='person@example.com'><group></group><group></group></item> (19:32:23) jabber: jabber_roster_parse(): Removing person@example.com from group 'Buddies' on the local list (19:32:23) GLib: g_string_append: assertion `val != NULL' failed (19:32:23) jabber: jabber_roster_parse(): Adding person@example.com to groups: , (19:32:23) g_log: purple_find_group: assertion `(name != NULL) && (*name != '\0')' failed (19:32:23) g_log: purple_group_new: assertion `name != NULL' failed (19:32:23) g_log: purple_blist_add_group: assertion `group != NULL' failed (19:32:23) g_log: purple_find_group: assertion `(name != NULL) && (*name != '\0')' failed (19:32:23) g_log: purple_group_new: assertion `*name != '\0'' failed (19:32:23) g_log: purple_blist_add_group: assertion `group != NULL' failed Since I had to look it up, purple_blist_add_buddy replaces (group == NULL) with "Buddies".
author Paul Aurich <paul@darkrain42.org>
date Wed, 11 May 2011 01:58:03 +0000
parents 4c1e9b7b56d0
children bfb4b66953b4
comparison
equal deleted inserted replaced
32039:2b289a184dc2 32040:06ed9020b784
90 XMPP: 90 XMPP:
91 * Remember the previously entered user directory when searching. 91 * Remember the previously entered user directory when searching.
92 (Keith Moyer) (#12451) 92 (Keith Moyer) (#12451)
93 * Correctly handle a buddy's unsetting his/her vCard-based avatar. 93 * Correctly handle a buddy's unsetting his/her vCard-based avatar.
94 (Matthew W.S. Bell) (#13370) 94 (Matthew W.S. Bell) (#13370)
95 * Squash one more situation that resulted in duplicate entries in
96 the roster (this one where the server reports the buddy as being
97 in the same (empty) group. (Reported by Danny Mayer)
95 98
96 Plugins: 99 Plugins:
97 * The Voice/Video Settings plugin now includes the ability to test 100 * The Voice/Video Settings plugin now includes the ability to test
98 microphone settings. (Jakub Adam) (#13182) 101 microphone settings. (Jakub Adam) (#13182)
99 * Fix a crash when handling some saved settings in the Voice/Video 102 * Fix a crash when handling some saved settings in the Voice/Video