Mercurial > pidgin.yaz
comparison libpurple/protocols/jabber/message.c @ 28515:191bb5bf2fc5
Don't crash when receiving an error iq response when trying fetch a custom
smiley (will happen if a client not supporting BoB sends XHTML-IM containing
cid: images).
Thanks to Florob, Waqas and Darkrain for finding and hinting about this :)
| author | Marcus Lundblad <ml@update.uu.se> |
|---|---|
| date | Mon, 31 Aug 2009 20:07:34 +0000 |
| parents | faf98a4b27d8 |
| children | 612402e064cb e8717ca47d25 fba8dd643796 508bd30ee8ba |
comparison
equal
deleted
inserted
replaced
| 28511:86e6df9a0c80 | 28515:191bb5bf2fc5 |
|---|---|
| 491 const gchar *alt = ref->alt; | 491 const gchar *alt = ref->alt; |
| 492 xmlnode *data_element = xmlnode_get_child(packet, "data"); | 492 xmlnode *data_element = xmlnode_get_child(packet, "data"); |
| 493 xmlnode *item_not_found = xmlnode_get_child(packet, "item-not-found"); | 493 xmlnode *item_not_found = xmlnode_get_child(packet, "item-not-found"); |
| 494 | 494 |
| 495 /* did we get a data element as result? */ | 495 /* did we get a data element as result? */ |
| 496 if (data_element) { | 496 if (data_element && type == JABBER_IQ_RESULT) { |
| 497 JabberData *data = jabber_data_create_from_xml(data_element); | 497 JabberData *data = jabber_data_create_from_xml(data_element); |
| 498 | 498 |
| 499 if (data) { | 499 if (data) { |
| 500 jabber_data_associate_remote(data); | 500 jabber_data_associate_remote(data); |
| 501 purple_conv_custom_smiley_write(conv, alt, | 501 purple_conv_custom_smiley_write(conv, alt, |