Mercurial > pidgin.yaz

comparison src/gtkblist.c @ 10504:1a97d5e88d12

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
[gaim-migrate @ 11796] Lots of things here: - Several memory leak fixes - A few invalid memory access fixes - Fix a yahoo crash going idle when away - Fix Add user in chats to actually fill in the screenname - Add gaim_account_{get,set}_enabled to perl - Fix command priorities (fixes /me in IRC) - Fix MSN notification server transfer to be quiet about it - Fix MSN blist sync if user has insane friendly name - Make the docklet less crash-happy if it fails to embed in 3 seconds - Only probe for native plugins with the correct file extension - 1 typo fix :) ... and quite possibly something else I forgot. committer: Tailor Script <tailor@pidgin.im>
author Stu Tomlinson <stu@nosnilmot.com>
date Tue, 11 Jan 2005 17:25:06 +0000
parents 4806967e093e
children 1044c0930e03
comparison
equal deleted inserted replaced
10503:776586d647e3 10504:1a97d5e88d12
2225 return FALSE; 2225 return FALSE;
2226 gtk_tree_model_get_iter(GTK_TREE_MODEL(gtkblist->treemodel), &iter, path); 2226 gtk_tree_model_get_iter(GTK_TREE_MODEL(gtkblist->treemodel), &iter, path);
2227 gtk_tree_model_get_value (GTK_TREE_MODEL(gtkblist->treemodel), &iter, NODE_COLUMN, &val); 2227 gtk_tree_model_get_value (GTK_TREE_MODEL(gtkblist->treemodel), &iter, NODE_COLUMN, &val);
2228 node = g_value_get_pointer(&val); 2228 node = g_value_get_pointer(&val);
2229 2229
2230 if(!GAIM_BLIST_NODE_IS_CONTACT(node)) 2230 if(!GAIM_BLIST_NODE_IS_CONTACT(node)) {
2231 gtk_tree_path_free(path);
2231 return FALSE; 2232 return FALSE;
2233 }
2232 2234
2233 gtknode = node->ui_data; 2235 gtknode = node->ui_data;
2234 2236
2235 if (!gtknode->contact_expanded) { 2237 if (!gtknode->contact_expanded) {
2236 GtkTreeIter i; 2238 GtkTreeIter i;
2276 return FALSE; 2278 return FALSE;
2277 gtk_tree_model_get_iter(GTK_TREE_MODEL(gtkblist->treemodel), &iter, path); 2279 gtk_tree_model_get_iter(GTK_TREE_MODEL(gtkblist->treemodel), &iter, path);
2278 gtk_tree_model_get_value (GTK_TREE_MODEL(gtkblist->treemodel), &iter, NODE_COLUMN, &val); 2280 gtk_tree_model_get_value (GTK_TREE_MODEL(gtkblist->treemodel), &iter, NODE_COLUMN, &val);
2279 node = g_value_get_pointer(&val); 2281 node = g_value_get_pointer(&val);
2280 2282
2283 gtk_tree_path_free(path);
2284
2281 if(!GAIM_BLIST_NODE_IS_CONTACT(node) && !GAIM_BLIST_NODE_IS_BUDDY(node) 2285 if(!GAIM_BLIST_NODE_IS_CONTACT(node) && !GAIM_BLIST_NODE_IS_BUDDY(node)
2282 && !GAIM_BLIST_NODE_IS_CHAT(node)) 2286 && !GAIM_BLIST_NODE_IS_CHAT(node))
2283 return FALSE; 2287 return FALSE;
2284 2288
2285 gtknode = node->ui_data; 2289 gtknode = node->ui_data;
2286
2287 gtk_tree_path_free(path);
2288 2290
2289 tooltiptext = gaim_get_tooltip_text(node); 2291 tooltiptext = gaim_get_tooltip_text(node);
2290 2292
2291 if(!tooltiptext) 2293 if(!tooltiptext)
2292 return FALSE; 2294 return FALSE;
3632 gaim_gtk_blist_hide_node(list, node); 3634 gaim_gtk_blist_hide_node(list, node);
3633 3635
3634 if(node->parent) 3636 if(node->parent)
3635 gaim_gtk_blist_update(list, node->parent); 3637 gaim_gtk_blist_update(list, node->parent);
3636 3638
3637 /* There's something I don't understand here */ 3639 /* There's something I don't understand here - Ethan */
3638 /* g_free(node->ui_data); 3640 /* Ethan said that back in 2003, but this g_free has been left commented
3639 node->ui_data = NULL; */ 3641 * out ever since. I can't find any reason at all why this is bad and
3642 * valgrind found several reasons why it's good. If this causes problems
3643 * comment it out again. Stu */
3644 g_free(node->ui_data);
3645 node->ui_data = NULL;
3640 } 3646 }
3641 3647
3642 static gboolean do_selection_changed(GaimBlistNode *new_selection) 3648 static gboolean do_selection_changed(GaimBlistNode *new_selection)
3643 { 3649 {
3644 GaimBlistNode *old_selection = NULL; 3650 GaimBlistNode *old_selection = NULL;