comparison libpurple/protocols/oscar/oscar.c @ 31693:3fe2bd895946

There is code above these lines, just before the start of the switch(), that validates that curitem->name is utf8. So we don't need to bother with oscar_utf8_try_convert() here. I know there has been some concern in the past about some people having non-utf8 names in their server list and wanting Pidgin to deal with that intelligently... all I can say is this commit shouldn't change the current functionality. It looks like we currently ignore groups from the server list if they're non-utf8, and it looks like it's been that way since at least 2.7.3, and more likely before then.

31692:e5cd15ee3e5d

					g_free(alias_utf8);
				}
			} break;

			case AIM_SSI_TYPE_GROUP: { /* Group */
				char *gname;
				char *gname_utf8;

				gname = curitem->name;
				gname_utf8 = oscar_utf8_try_convert(account, od, gname);

				if (gname_utf8 != NULL && purple_find_group(gname_utf8) == NULL) {
					g = purple_group_new(gname_utf8);
					purple_blist_add_group(g, NULL);
				}
				g_free(gname_utf8);
			} break;

			case AIM_SSI_TYPE_PERMIT: { /* Permit buddy (unless we're on ICQ) */
				if (!od->icq && curitem->name) {
					for (cur = account->permit; (cur && oscar_util_name_compare(curitem->name, cur->data)); cur = cur->next);

31693:3fe2bd895946

					g_free(alias_utf8);
				}
			} break;

			case AIM_SSI_TYPE_GROUP: { /* Group */
				if (curitem->name != NULL && purple_find_group(curitem->name) == NULL) {
					g = purple_group_new(curitem->name);
					purple_blist_add_group(g, NULL);
				}
			} break;

			case AIM_SSI_TYPE_PERMIT: { /* Permit buddy (unless we're on ICQ) */
				if (!od->icq && curitem->name) {
					for (cur = account->permit; (cur && oscar_util_name_compare(curitem->name, cur->data)); cur = cur->next);