comparison libpurple/dnssrv.c @ 32202:4739488955a7

dnssrv: Avoid a few extraneous iterations through the list. Refs #12647

32201:a40d1cb09beb

 * Only used as the callback for the ui ops.
 */
static void
purple_srv_query_resolved(PurpleSrvTxtQueryData *query_data, GList *records)
{
	GList *sorted_records, *l;
	PurpleSrvResponse *records_array;
	int i;

	g_return_if_fail(records != NULL);

	if (query_data->cb.srv == NULL) {
		purple_srv_txt_query_destroy(query_data);

		g_list_foreach(records, (GFunc)g_free, NULL);
		g_list_free(records);
		return;
	}

	sorted_records = purple_srv_sort(records);

	purple_debug_info("dnssrv", "SRV records resolved for %s, count: %d\n", query_data->query, g_list_length(sorted_records));

	records_array = g_new(PurpleSrvResponse, g_list_length(sorted_records));

	i = 0;

	for (l = sorted_records; l; l = l->next, i++) {
		records_array[i] = *(PurpleSrvResponse *)l->data;
	}

	query_data->cb.srv(records_array, i, query_data->extradata);

	purple_srv_txt_query_destroy(query_data);

	g_list_foreach(sorted_records, (GFunc)g_free, NULL);
	g_list_free(sorted_records);
}

/*
 * Only used as the callback for the ui ops.
 */

	/* the callback should g_free the entries.
	 */
	if (query_data->cb.txt != NULL)
		query_data->cb.txt(entries, query_data->extradata);
	else {
		g_list_foreach(entries, (GFunc)g_free, NULL);
		g_list_free(entries);
	}

	purple_srv_txt_query_destroy(query_data);
}

32202:4739488955a7

 * Only used as the callback for the ui ops.
 */
static void
purple_srv_query_resolved(PurpleSrvTxtQueryData *query_data, GList *records)
{
	GList *l;
	PurpleSrvResponse *records_array;
	int i = 0, length;

	g_return_if_fail(records != NULL);

	if (query_data->cb.srv == NULL) {
		purple_srv_txt_query_destroy(query_data);

		while (records) {
			g_free(records->data);
			records = g_list_delete_link(records, records);
		}
		return;
	}

	records = purple_srv_sort(records);
	length = g_list_length(records);

	purple_debug_info("dnssrv", "SRV records resolved for %s, count: %d\n",
	                            query_data->query, length);

	records_array = g_new(PurpleSrvResponse, length);
	for (l = records; l; l = l->next, i++) {
		records_array[i] = *(PurpleSrvResponse *)l->data;
	}

	query_data->cb.srv(records_array, length, query_data->extradata);

	purple_srv_txt_query_destroy(query_data);

	while (records) {
		g_free(records->data);
		records = g_list_delete_link(records, records);
	}
}

/*
 * Only used as the callback for the ui ops.
 */

	/* the callback should g_free the entries.
	 */
	if (query_data->cb.txt != NULL)
		query_data->cb.txt(entries, query_data->extradata);
	else {
		while (entries) {
			g_free(entries->data);
			entries = g_list_delete_link(entries, entries);
		}
	}

	purple_srv_txt_query_destroy(query_data);
}