comparison libpurple/upnp.c @ 15441:56a2a0bb290a

Fix a crash when a network_listen_range process is canceled before its UPnP port mapping completes, which occurs regularly on certain routers when file transfers are initiated and then quickly finished. Much thanks to Elliott Harris and Eric Richie for their hard work with me hunting this down and fixing it.

15439:a415922e2882

	gchar service_type[25];
	int retry_count;
	gchar *full_url;
} UPnPDiscoveryData;

typedef struct {
	unsigned short portmap;
	gchar protocol[4];
	gboolean add;
	GaimUPnPCallback cb;
	gpointer cb_data;
} UPnPMappingAddRemove;

static GaimUPnPControlInfo control_info = {
	GAIM_UPNP_STATUS_UNDISCOVERED,
	NULL, "\0", "\0", "\0", 0};

	control_info.status = GAIM_UPNP_STATUS_DISCOVERING;

	gaim_upnp_discover_send_broadcast(dd);
}

static void
gaim_upnp_generate_action_message_and_send(const gchar* actionName,
		const gchar* actionParams, GaimUtilFetchUrlCallback cb,
		gpointer cb_data)
{

	gchar* soapMessage;
	gchar* totalSendMessage;
	gchar* pathOfControl;
	gchar* addressOfControl;
	int port = 0;

		control_info.service_type, actionName,
		strlen(soapMessage), soapMessage);
	g_free(pathOfControl);
	g_free(soapMessage);

	gaim_util_fetch_url_request(control_info.control_url, FALSE, NULL, TRUE,
			totalSendMessage, TRUE, cb, cb_data);

	g_free(totalSendMessage);
	g_free(addressOfControl);
}

const gchar *
gaim_upnp_get_public_ip()
{

			action_params = g_strdup_printf(
				DELETE_PORT_MAPPING_PARAMS,
				ar->portmap, ar->protocol);
		}

		gaim_upnp_generate_action_message_and_send(action_name,
				action_params, done_port_mapping_cb, ar);

		g_free(action_params);
		return;
	}

{
	do_port_mapping_cb(FALSE, data);
	return FALSE;
}

void
gaim_upnp_set_port_mapping(unsigned short portmap, const gchar* protocol,
		GaimUPnPCallback cb, gpointer cb_data)
{
	UPnPMappingAddRemove *ar;

		 * the internal IP lookup won't be complete */
		discovery_callbacks = g_slist_append(
				discovery_callbacks, do_port_mapping_cb);
		discovery_callbacks = g_slist_append(
				discovery_callbacks, ar);
		return;
	}

	/* If we haven't had a successful UPnP discovery, check if 5 minutes has
	 * elapsed since the last try, try again */
	if(control_info.status == GAIM_UPNP_STATUS_UNDISCOVERED ||
			(control_info.status == GAIM_UPNP_STATUS_UNABLE_TO_DISCOVER
			 && (time(NULL) - control_info.lookup_time) > 300)) {
		gaim_upnp_discover(do_port_mapping_cb, ar);
		return;
	} else if(control_info.status == GAIM_UPNP_STATUS_UNABLE_TO_DISCOVER) {
		if (cb) {
			/* Asynchronously trigger a failed response */
			gaim_timeout_add(10, fire_port_mapping_failure_cb, ar);
		} else {
			/* No need to do anything if nobody expects a response*/
			g_free(ar);
		}
		return;
	}

	do_port_mapping_cb(TRUE, ar);
}

void
gaim_upnp_remove_port_mapping(unsigned short portmap, const char* protocol,
		GaimUPnPCallback cb, gpointer cb_data)
{
	UPnPMappingAddRemove *ar;

	if(control_info.status == GAIM_UPNP_STATUS_DISCOVERING) {
		discovery_callbacks = g_slist_append(
				discovery_callbacks, do_port_mapping_cb);
		discovery_callbacks = g_slist_append(
				discovery_callbacks, ar);
		return;
	}

	/* If we haven't had a successful UPnP discovery, check if 5 minutes has
	 * elapsed since the last try, try again */
	if(control_info.status == GAIM_UPNP_STATUS_UNDISCOVERED ||
			(control_info.status == GAIM_UPNP_STATUS_UNABLE_TO_DISCOVER
			 && (time(NULL) - control_info.lookup_time) > 300)) {
		gaim_upnp_discover(do_port_mapping_cb, ar);
		return;
	} else if(control_info.status == GAIM_UPNP_STATUS_UNABLE_TO_DISCOVER) {
		if (cb) {
			/* Asynchronously trigger a failed response */
			gaim_timeout_add(10, fire_port_mapping_failure_cb, ar);
		} else {
			/* No need to do anything if nobody expects a response*/
			g_free(ar);
		}
		return;
	}

	do_port_mapping_cb(TRUE, ar);
}

15441:56a2a0bb290a

	gchar service_type[25];
	int retry_count;
	gchar *full_url;
} UPnPDiscoveryData;

struct _UPnPMappingAddRemove
{
	unsigned short portmap;
	gchar protocol[4];
	gboolean add;
	GaimUPnPCallback cb;
	gpointer cb_data;
	guint tima; /* gaim_timeout_add handle */
	GaimUtilFetchUrlData *gfud;
};

static GaimUPnPControlInfo control_info = {
	GAIM_UPNP_STATUS_UNDISCOVERED,
	NULL, "\0", "\0", "\0", 0};

	control_info.status = GAIM_UPNP_STATUS_DISCOVERING;

	gaim_upnp_discover_send_broadcast(dd);
}

static GaimUtilFetchUrlData*
gaim_upnp_generate_action_message_and_send(const gchar* actionName,
		const gchar* actionParams, GaimUtilFetchUrlCallback cb,
		gpointer cb_data)
{
	GaimUtilFetchUrlData* gfud;
	gchar* soapMessage;
	gchar* totalSendMessage;
	gchar* pathOfControl;
	gchar* addressOfControl;
	int port = 0;

		control_info.service_type, actionName,
		strlen(soapMessage), soapMessage);
	g_free(pathOfControl);
	g_free(soapMessage);

	gfud = gaim_util_fetch_url_request(control_info.control_url, FALSE, NULL, TRUE,
				totalSendMessage, TRUE, cb, cb_data);

	g_free(totalSendMessage);
	g_free(addressOfControl);
	
	return gfud;
}

const gchar *
gaim_upnp_get_public_ip()
{

			action_params = g_strdup_printf(
				DELETE_PORT_MAPPING_PARAMS,
				ar->portmap, ar->protocol);
		}

		ar->gfud = gaim_upnp_generate_action_message_and_send(action_name,
						action_params, done_port_mapping_cb, ar);

		g_free(action_params);
		return;
	}

{
	do_port_mapping_cb(FALSE, data);
	return FALSE;
}

void gaim_upnp_cancel_port_mapping(UPnPMappingAddRemove *ar)
{
	GSList *l;

	/* Remove ar from discovery_callbacks if present; it was inserted after a cb.
	 * The same cb may be in the list multple times, so be careful to remove the one assocaited with ar. */
	l  = discovery_callbacks;
	while (l)
	{
		if (l->next && (l->next->data == ar)) {
			discovery_callbacks = g_slist_delete_link(discovery_callbacks, l->next);
			discovery_callbacks = g_slist_delete_link(discovery_callbacks, l);
		}

		l = l->next;
	}

	if (ar->tima > 0)
		gaim_timeout_remove(ar->tima);

	if (ar->gfud)
		gaim_util_fetch_url_cancel(ar->gfud);

	g_free(ar);
}

UPnPMappingAddRemove *
gaim_upnp_set_port_mapping(unsigned short portmap, const gchar* protocol,
		GaimUPnPCallback cb, gpointer cb_data)
{
	UPnPMappingAddRemove *ar;

		 * the internal IP lookup won't be complete */
		discovery_callbacks = g_slist_append(
				discovery_callbacks, do_port_mapping_cb);
		discovery_callbacks = g_slist_append(
				discovery_callbacks, ar);
		return ar;
	}

	/* If we haven't had a successful UPnP discovery, check if 5 minutes has
	 * elapsed since the last try, try again */
	if(control_info.status == GAIM_UPNP_STATUS_UNDISCOVERED ||
			(control_info.status == GAIM_UPNP_STATUS_UNABLE_TO_DISCOVER
			 && (time(NULL) - control_info.lookup_time) > 300)) {
		gaim_upnp_discover(do_port_mapping_cb, ar);
		return ar;
	} else if(control_info.status == GAIM_UPNP_STATUS_UNABLE_TO_DISCOVER) {
		if (cb) {
			/* Asynchronously trigger a failed response */
			ar->tima = gaim_timeout_add(10, fire_port_mapping_failure_cb, ar);
		} else {
			/* No need to do anything if nobody expects a response*/
			g_free(ar);
			ar = NULL;
		}
		return ar;
	}

	do_port_mapping_cb(TRUE, ar);
	return ar;
}

UPnPMappingAddRemove *
gaim_upnp_remove_port_mapping(unsigned short portmap, const char* protocol,
		GaimUPnPCallback cb, gpointer cb_data)
{
	UPnPMappingAddRemove *ar;

	if(control_info.status == GAIM_UPNP_STATUS_DISCOVERING) {
		discovery_callbacks = g_slist_append(
				discovery_callbacks, do_port_mapping_cb);
		discovery_callbacks = g_slist_append(
				discovery_callbacks, ar);
		return ar;
	}

	/* If we haven't had a successful UPnP discovery, check if 5 minutes has
	 * elapsed since the last try, try again */
	if(control_info.status == GAIM_UPNP_STATUS_UNDISCOVERED ||
			(control_info.status == GAIM_UPNP_STATUS_UNABLE_TO_DISCOVER
			 && (time(NULL) - control_info.lookup_time) > 300)) {
		gaim_upnp_discover(do_port_mapping_cb, ar);
		return ar;
	} else if(control_info.status == GAIM_UPNP_STATUS_UNABLE_TO_DISCOVER) {
		if (cb) {
			/* Asynchronously trigger a failed response */
			ar->tima = gaim_timeout_add(10, fire_port_mapping_failure_cb, ar);
		} else {
			/* No need to do anything if nobody expects a response*/
			g_free(ar);
			ar = NULL;
		}
		return ar;
	}

	do_port_mapping_cb(TRUE, ar);
	return ar;
}