Mercurial > pidgin.yaz
comparison src/conversation.c @ 4622:56dde5f7d3a8
[gaim-migrate @ 4913]
Fixed the "Closing a chat crashes gaim" bug, I think.
There was a double-free going on with the chat topic and the user who set
the topic. The first did checks to see if it was NULL, and if not, freed
it. The second just freed it. The second should NOT have existed!
Probably explains why I could only duplicate it in channels with no
topic.
Let me know if this still crashes for anybody. It stopped crashing here.
committer: Tailor Script <tailor@pidgin.im>
| author | Christian Hammond <chipx86@chipx86.com> |
|---|---|
| date | Thu, 27 Feb 2003 10:05:05 +0000 |
| parents | 69f028a6f357 |
| children | b58c08b7cbe4 |
comparison
equal
deleted
inserted
replaced
| 4621:69f028a6f357 | 4622:56dde5f7d3a8 |
|---|---|
| 1022 g_free(conv->u.chat->who); | 1022 g_free(conv->u.chat->who); |
| 1023 | 1023 |
| 1024 if (conv->u.chat->topic != NULL) | 1024 if (conv->u.chat->topic != NULL) |
| 1025 g_free(conv->u.chat->topic); | 1025 g_free(conv->u.chat->topic); |
| 1026 | 1026 |
| 1027 g_free(conv->u.chat->who); | |
| 1028 g_free(conv->u.chat->topic); | |
| 1029 g_free(conv->u.chat); | 1027 g_free(conv->u.chat); |
| 1030 | 1028 |
| 1031 chats = g_list_remove(chats, conv); | 1029 chats = g_list_remove(chats, conv); |
| 1032 } | 1030 } |
| 1033 | 1031 |