comparison libpurple/connection.c @ 21357:5a3242b676ad

rlaager suggested using the last element of the PurpleDisconnectReason enum for sanity checking, which sidesteps the "should NUM_REASONS be in or out of the enum?" problem.

21356:be75cb19f548

                                const char *description)
{
	PurpleConnectionUiOps *ops;

	g_return_if_fail(gc   != NULL);
	g_return_if_fail(reason < PURPLE_NUM_REASONS);

	if (description == NULL) {
		purple_debug_error("connection", "purple_connection_error_reason: check `description != NULL' failed\n");
		description = _("Unknown error");
	}

21357:5a3242b676ad

                                const char *description)
{
	PurpleConnectionUiOps *ops;

	g_return_if_fail(gc   != NULL);
	/* This sanity check relies on PURPLE_REASON_OTHER_ERROR being the
	 * last member of the PurpleDisconnectReason enum in connection.h; if
	 * other reasons are added after it, this check should be updated.
	 */
	if (reason > PURPLE_REASON_OTHER_ERROR) {
		purple_debug_error("connection",
			"purple_connection_error_reason: reason %u isn't a "
			"valid reason\n", reason);
		reason = PURPLE_REASON_OTHER_ERROR;
	}

	if (description == NULL) {
		purple_debug_error("connection", "purple_connection_error_reason: check `description != NULL' failed\n");
		description = _("Unknown error");
	}