pidgin.yaz: libgaim/protocols/qq/qq.c comparison

comparison libgaim/protocols/qq/qq.c @ 14629:6b8bc59414f0

[gaim-migrate @ 17375] Get rid of these useless checks. committer: Tailor Script <tailor@pidgin.im>

author	Mark Huetsch <markhuetsch>
date	Tue, 26 Sep 2006 22:54:24 +0000
parents	8ed6ef220b2d
children	a33d179d5508

comparison

equal deleted inserted replaced

-:58202142e9ad
+:6b8bc59414f0
 {
 	gint type, to_uid;
 	gchar *msg, *msg_with_qq_smiley;
 	qq_data *qd;
-	g_return_val_if_fail(gc != NULL && gc->proto_data != NULL && who != NULL, -1);
+	g_return_val_if_fail(who != NULL, -1);
 	qd = (qq_data *) gc->proto_data;
 	g_return_val_if_fail(strlen(message) <= QQ_MSG_IM_MAX, -E2BIG);
 static int _qq_chat_send(GaimConnection *gc, int channel, const char *message, GaimMessageFlags flags)
 {
 	gchar *msg, *msg_with_qq_smiley;
 	qq_group *group;
-	g_return_val_if_fail(gc != NULL && message != NULL, -1);
+	g_return_val_if_fail(message != NULL, -1);
 	g_return_val_if_fail(strlen(message) <= QQ_MSG_IM_MAX, -E2BIG);
 	group = qq_group_find_by_channel(gc, channel);
 	g_return_val_if_fail(group != NULL, -1);
 static void _qq_get_info(GaimConnection *gc, const gchar *who)
 {
 	guint32 uid;
 	qq_data *qd;
-	g_return_if_fail(gc != NULL && gc->proto_data != NULL);
 	qd = gc->proto_data;
 	uid = gaim_name_to_uid(who);
 	if (uid <= 0) {
 		gaim_debug(GAIM_DEBUG_ERROR, "QQ", "Not valid QQid: %s\n", who);
 static void _qq_menu_modify_my_info(GaimPluginAction *action)
 {
 	GaimConnection *gc = (GaimConnection *) action->context;
 	qq_data *qd;
-	g_return_if_fail(gc != NULL && gc->proto_data != NULL);
 	qd = (qq_data *) gc->proto_data;
 	qq_prepare_modify_info(gc);
 }
 static void _qq_change_face_cb(GaimConnection *gc, GaimRequestFields *fields)
 {
 	qq_data *qd;
 	GaimRequestField *field;
 	gint suffix;
-	g_return_if_fail(gc != NULL && gc->proto_data != NULL);
 	qd = (qq_data *) gc->proto_data;
 	field = gaim_request_fields_get_field(fields, "face_num");
 	suffix = get_icon_offset(gc);
 	qd->my_icon = gaim_request_field_choice_get_value(field) * 3 + suffix;
 	g_return_if_fail(GAIM_BLIST_NODE_IS_BUDDY(node));
 	buddy = (GaimBuddy *) node;
 	gc = gaim_account_get_connection(buddy->account);
 	who = buddy->name;
-	g_return_if_fail(gc != NULL && who != NULL);
+	g_return_if_fail(who != NULL);
 	uid = gaim_name_to_uid(who);
 	g_return_if_fail(uid > 0);
 	g = g_new0(gc_and_uid, 1);
 {
 	GaimConnection *gc = (GaimConnection *) action->context;
 	qq_data *qd;
 	GString *info;
-	g_return_if_fail(gc != NULL && gc->proto_data != NULL);
 	qd = (qq_data *) gc->proto_data;
 	info = g_string_new("<html><body>\n");
 	g_string_append_printf(info, _("<b>Current Online</b>: %d<br>\n"), qd->all_online);
 	g_string_append_printf(info, _("<b>Last Refresh</b>: %s<br>\n"), ctime(&qd->last_get_online));
 /*
 static void _qq_menu_create_permanent_group(GaimPluginAction * action)
 {
 	GaimConnection *gc = (GaimConnection *) action->context;
-	g_return_if_fail(gc != NULL);
 	gaim_request_input(gc, _("Create QQ Qun"),
 			   _("Input Qun name here"),
 			   _("Only QQ member can create permanent Qun"),
 			   "OpenQ", FALSE, FALSE, NULL,
 			   _("Create"), G_CALLBACK(qq_group_create_with_name), _("Cancel"), NULL, gc);
 	GaimConnection *gc = gaim_account_get_connection(chat->account);
 	GHashTable *components = chat -> components;
 	g_return_if_fail(GAIM_BLIST_NODE_IS_CHAT(node));
-	g_return_if_fail(gc != NULL && components != NULL);
+	g_return_if_fail(components != NULL);
 	qq_group_exit(gc, components);
 }
 /*
 static void _qq_menu_manage_group(GaimBlistNode * node)
 	GaimConnection *gc = gaim_account_get_connection(chat->account);
 	GHashTable *components = chat -> components;
 	g_return_if_fail(GAIM_BLIST_NODE_IS_CHAT(node));
-	g_return_if_fail(gc != NULL && components != NULL);
+	g_return_if_fail(components != NULL);
 	qq_group_manage_group(gc, components);
 }
 */
 /* TODO: re-enable this
 	gchar tmp[15];
 	qq_data *qd;
 	gc = (GaimConnection *) action->context;
 	qd = (qq_data *) gc->proto_data;
-	g_return_if_fail(gc != NULL && qd != NULL);
 	fields = gaim_request_fields_new();
 	group = gaim_request_field_group_new(_("Basic Elements"));
 	gaim_request_fields_add_group(fields, group);
 	g_snprintf(tmp, sizeof(tmp), "%04X", QQ_CLIENT);
 {
 	qq_group *group;
 	qq_data *qd;
 	GList *list;
-	g_return_if_fail(gc != NULL);
 	if (NULL == (qd = (qq_data *) gc->proto_data))
 		return;
 	list = qd->groups;
 	while (list != NULL) {
 /* convert chat nickname to qq-uid to get this buddy info */
 /* who is the nickname of buddy in QQ chat-room (Qun) */
 static void _qq_get_chat_buddy_info(GaimConnection *gc, gint channel, const gchar *who)
 {
 	gchar *gaim_name;
-	g_return_if_fail(gc != NULL && gc->proto_data != NULL && who != NULL);
+	g_return_if_fail(who != NULL);
 	gaim_name = chat_name_to_gaim_name(who);
 	if (gaim_name != NULL)
 		_qq_get_info(gc, gaim_name);
 }
 /* convert chat nickname to qq-uid to invite individual IM to buddy */
 /* who is the nickname of buddy in QQ chat-room (Qun) */
 static gchar *_qq_get_chat_buddy_real_name(GaimConnection *gc, gint channel, const gchar *who)
 {
-	g_return_val_if_fail(gc != NULL && gc->proto_data != NULL && who != NULL, NULL);
+	g_return_val_if_fail(who != NULL, NULL);
 	return chat_name_to_gaim_name(who);
 }
 void qq_function_not_implemented(GaimConnection *gc)
 {

Mercurial > pidgin.yaz

comparison libgaim/protocols/qq/qq.c @ 14629:6b8bc59414f0