comparison src/protocols/oscar/peer.c @ 13968:6fc412e59214

[gaim-migrate @ 16525] A bunch of little things * Use GAIM_CONNECTION_IS_VALID(gc) in a lot of places where we were doing g_list_find(gaim_connections_get_all(), gc) * Get rid of a lot of places where we were doing g_list_find(gaim_connections_get_all(), gc). The handle used by the request API ensures that the ok and cancel callback functions won't be called if the gc is destroyed. However, GAIM_CONNECTION_IS_VALID(gc) is still very important for callback functions where we can't cancel the request. For example, gaim_proxy_connect() callback functions. * "Added" a function to Yahoo! that should help us notice when our buddies change their buddy icon/display picture * Some comments in a few places * Changed GAIM_CONNECTION_IS_VALID(gc) to only look through the list of "all" connections and not the list of "connecting" connections. Some time ago we changed how this was done so that the list of "all" connections now includes the "connection" connections. committer: Tailor Script <tailor@pidgin.im>
author Mark Doliner <mark@kingant.net>
date Thu, 20 Jul 2006 08:11:54 +0000
parents e5c3bfc208a9
children 10e8eb6a4910
comparison
equal deleted inserted replaced
13967:99b9b58b19dd 13968:6fc412e59214
479 new_conn_data = data; 479 new_conn_data = data;
480 gc = new_conn_data->gc; 480 gc = new_conn_data->gc;
481 conn = new_conn_data->conn; 481 conn = new_conn_data->conn;
482 g_free(new_conn_data); 482 g_free(new_conn_data);
483 483
484 if (!g_list_find(gaim_connections_get_all(), gc)) 484 if (!GAIM_CONNECTION_IS_VALID(gc))
485 { 485 {
486 if (source >= 0) 486 if (source >= 0)
487 close(source); 487 close(source);
488 return; 488 return;
489 } 489 }
571 new_conn_data = data; 571 new_conn_data = data;
572 gc = new_conn_data->gc; 572 gc = new_conn_data->gc;
573 conn = new_conn_data->conn; 573 conn = new_conn_data->conn;
574 g_free(new_conn_data); 574 g_free(new_conn_data);
575 575
576 if (!g_list_find(gaim_connections_get_all(), gc)) 576 if (!GAIM_CONNECTION_IS_VALID(gc))
577 { 577 {
578 if (listenerfd != -1) 578 if (listenerfd != -1)
579 close(listenerfd); 579 close(listenerfd);
580 return; 580 return;
581 } 581 }