pidgin.yaz: pidgin/gtkutils.c comparison

comparison pidgin/gtkutils.c @ 16381:72dc611f3257

Fix the custom icon stuff, and various memory leaks. At this point, custom icons work properly, EXCEPT FOR A SERIOUS LEAK which I haven't fixed yet because I'm seeing weird memory allocation issues. Once I deal with that, it's just the account icon stuff that's left.

author	Richard Laager <rlaager@wiktel.com>
date	Tue, 24 Apr 2007 17:00:22 +0000
parents	391a79778f89
children	24bbd7e46bfe

comparison

equal deleted inserted replaced

-:6c97924af83b
+:72dc611f3257
 				return TRUE;
 	return FALSE;
 }
 #endif
-char *
+gpointer
-pidgin_convert_buddy_icon(PurplePlugin *plugin, const char *path)
+pidgin_convert_buddy_icon(PurplePlugin *plugin, const char *path, size_t *len)
 {
 	PurplePluginProtocolInfo *prpl_info;
 #if GTK_CHECK_VERSION(2,2,0)
 	char **prpl_formats;
 	int width, height;
 	char **pixbuf_formats = NULL;
-	struct stat st;
 	GdkPixbufFormat *format;
 	GdkPixbuf *pixbuf;
 #if !GTK_CHECK_VERSION(2,4,0)
 	GdkPixbufLoader *loader;
 #endif
 #endif
 	gchar *contents;
 	gsize length;
-	const char *dirname;
-	char *random;
-	char *filename;
 	prpl_info = PURPLE_PLUGIN_PROTOCOL_INFO(plugin);
 	g_return_val_if_fail(prpl_info->icon_spec.format != NULL, NULL);
-	dirname = purple_buddy_icons_get_cache_dir();
-	if (!g_file_test(dirname, G_FILE_TEST_IS_DIR)) {
-		purple_debug_info("buddyicon", "Creating icon cache directory.\n");
-		if (g_mkdir(dirname, S_IRUSR | S_IWUSR | S_IXUSR) < 0) {
-			purple_debug_error("buddyicon",
-							 "Unable to create directory %s: %s\n",
-							 dirname, strerror(errno));
-			return NULL;
-		}
-	}
-	random = g_strdup_printf("%x", g_random_int());
-	filename = g_build_filename(dirname, random, NULL);
 #if GTK_CHECK_VERSION(2,2,0)
 #if GTK_CHECK_VERSION(2,4,0)
 	format = gdk_pixbuf_get_file_info(path, &width, &height);
 #else
 		   prpl_info->icon_spec.max_width >= width &&
 		   prpl_info->icon_spec.min_height <= height &&
 		   prpl_info->icon_spec.max_height >= height)))                   /* The icon is the correct size */
 #endif
 	{
-		FILE *image;
 #if GTK_CHECK_VERSION(2,2,0)
 		g_strfreev(prpl_formats);
 		g_strfreev(pixbuf_formats);
 #endif
+		/* We don't need to scale the image. */
-		/* We don't need to scale the image, so copy it to the cache folder verbatim */
 		contents = NULL;
-		if (!g_file_get_contents(path, &contents, &length, NULL) ||
+		if (!g_file_get_contents(path, &contents, &length, NULL))
-		    (image = g_fopen(filename, "wb")) == NULL)
 		{
-			g_free(random);
-			g_free(filename);
 			g_free(contents);
-#if GTK_CHECK_VERSION(2,2,0) && !GTK_CHECK_VERSION(2,4,0)
-			g_object_unref(G_OBJECT(pixbuf));
-#endif
-			return NULL;
-		}
-		if (fwrite(contents, 1, length, image) != length)
-		{
-			fclose(image);
-			g_unlink(filename);
-			g_free(random);
-			g_free(filename);
-			g_free(contents);
-#if GTK_CHECK_VERSION(2,2,0) && !GTK_CHECK_VERSION(2,4,0)
-			g_object_unref(G_OBJECT(pixbuf));
-#endif
-			return NULL;
-		}
-		fclose(image);
-		g_free(contents);
 #if GTK_CHECK_VERSION(2,2,0) && !GTK_CHECK_VERSION(2,4,0)
 		g_object_unref(G_OBJECT(pixbuf));
 #endif
+			return NULL;
+		}
 	}
 #if GTK_CHECK_VERSION(2,2,0)
 	else
 	{
 		int i;
 		GError *error = NULL;
 		GdkPixbuf *scale;
 		gboolean success = FALSE;
+		char *filename = NULL;
 		g_strfreev(pixbuf_formats);
 		pixbuf = gdk_pixbuf_new_from_file(path, &error);
 		if (error) {
 			purple_debug_error("buddyicon", "Could not open icon for conversion: %s\n", error->message);
 			g_error_free(error);
-			g_free(random);
-			g_free(filename);
 			g_strfreev(prpl_formats);
 			return NULL;
 		}
 		if ((prpl_info->icon_spec.scale_rules & PURPLE_ICON_SCALE_SEND) &&
 			g_object_unref(G_OBJECT(pixbuf));
 			pixbuf = scale;
 		}
 		for (i = 0; prpl_formats[i]; i++) {
+			FILE *fp;
+			g_free(filename);
+			fp = purple_mkstemp(&filename, TRUE);
+			if (!fp)
+			{
+				g_free(filename);
+				return NULL;
+			}
+			fclose(fp);
 			purple_debug_info("buddyicon", "Converting buddy icon to %s as %s\n", prpl_formats[i], filename);
 			/* The "compression" param wasn't supported until gdk-pixbuf 2.8.
 			 * Using it in previous versions causes the save to fail (and an assert message).  */
 			if ((gdk_pixbuf_major_version > 2 || (gdk_pixbuf_major_version == 2
 						&& gdk_pixbuf_minor_version >= 8))
 		}
 		g_strfreev(prpl_formats);
 		g_object_unref(G_OBJECT(pixbuf));
 		if (!success) {
 			purple_debug_error("buddyicon", "Could not convert icon to usable format.\n");
-			g_free(random);
+			return NULL;
+		}
+		contents = NULL;
+		if (!g_file_get_contents(filename, &contents, &length, NULL))
+		{
+			purple_debug_error("buddyicon",
+					"Could not read '%s', which we just wrote to disk.\n",
+					filename);
+			g_free(contents);
 			g_free(filename);
 			return NULL;
 		}
-	}
+		g_unlink(filename);
-	if (g_stat(filename, &st) != 0) {
-		purple_debug_error("buddyicon",
-				"Could not stat '%s', which we just wrote to disk: %s\n",
-				filename, strerror(errno));
-		g_free(random);
 		g_free(filename);
-		return NULL;
+	}
-	}
+	/* Check the image size */
-	/* Check the file size */
 	/*
 	 * TODO: If the file is too big, it would be cool if we checked if
 	 *       the prpl supported jpeg, and then we could convert to that
 	 *       and use a lower quality setting.
 	 */
 	if ((prpl_info->icon_spec.max_filesize != 0) &&
-		(st.st_size > prpl_info->icon_spec.max_filesize))
+	    (length > prpl_info->icon_spec.max_filesize))
 	{
 		gchar *tmp;
 		tmp = g_strdup_printf(_("The file '%s' is too large for %s.  Please try a smaller image.\n"),
 				path, plugin->info->name);
 		purple_notify_error(NULL, _("Icon Error"),
 				_("Could not set icon"), tmp);
 		purple_debug_info("buddyicon",
 				"'%s' was converted to an image which is %" G_GSIZE_FORMAT
 				" bytes, but the maximum icon size for %s is %" G_GSIZE_FORMAT
-				" bytes\n", path, st.st_size, plugin->info->name,
+				" bytes\n", path, length, plugin->info->name,
 				prpl_info->icon_spec.max_filesize);
 		g_free(tmp);
-		g_free(random);
-		g_free(filename);
 		return NULL;
 	}
-	g_free(filename);
+	if (len)
-	return random;
+		*len = length;
+	return contents;
 #else
 	/*
 	 * The chosen icon wasn't the right size, and we're using
 	 * GTK+ 2.0 so we can't scale it.
 	 */
 }
 #endif /* ! Gtk 2.6.0 */
 void pidgin_set_custom_buddy_icon(PurpleAccount *account, const char *who, const char *filename)
 {
-	PurpleConversation *conv;
 	PurpleBuddy *buddy;
-	PurpleBlistNode *node;
+	PurpleContact *contact;
-	char *path = NULL;
+	gpointer data = NULL;
+	size_t len = 0;
 	buddy = purple_find_buddy(account, who);
 	if (!buddy) {
 		purple_debug_info("custom-icon", "You can only set custom icon for someone in your buddylist.\n");
 		return;
 	}
-	node = (PurpleBlistNode*)purple_buddy_get_contact(buddy);
+	contact = purple_buddy_get_contact(buddy);
-	path = (char*)purple_blist_node_get_string(node, "custom_buddy_icon");
-	if (path) {
-		struct stat st;
-		if (g_stat(path, &st) == 0)
-			g_unlink(path);
-		path = NULL;
-	}
 	if (filename) {
-		char *newfile;
+		const char *prpl_id = purple_account_get_protocol_id(account);
+		PurplePlugin *prpl = purple_find_prpl(prpl_id);
-		newfile = pidgin_convert_buddy_icon(purple_find_prpl(purple_account_get_protocol_id(account)),
-						filename);
+		data = pidgin_convert_buddy_icon(prpl, filename, &len);
-		path = purple_buddy_icons_get_full_path(newfile);
-		g_free(newfile);
+		/* We don't want to delete the old icon if the new one didn't load. */
-	}
+		if (data == NULL)
+			return;
-	purple_blist_node_set_string(node, "custom_buddy_icon", path);
+	}
-	g_free(path);
+	purple_buddy_icons_set_custom_icon(contact, data, len);
-	/* Update the conversation */
-	conv = purple_find_conversation_with_account(PURPLE_CONV_TYPE_IM, who, account);
-	if (conv)
-		purple_conversation_update(conv, PURPLE_CONV_UPDATE_ICON);
-	/* Update the buddylist */
-	if (buddy)
-		purple_blist_update_buddy_icon(buddy);
 }
 char *pidgin_make_pretty_arrows(const char *str)
 {
 	char *ret;

Mercurial > pidgin.yaz

comparison pidgin/gtkutils.c @ 16381:72dc611f3257