Mercurial > pidgin.yaz
comparison pidgin/gtkmenutray.c @ 23047:76ae43c5e745
*** Plucked rev 69b22e32f7ada182101e0746f02891389ceb0c52 (sadrul@pidgin.im):
The text iterators need to be properly ordered here. Taking the iterators
from the x/y coordinates doesn't ensure the correct order, especially when
RTL languages are involved. Thanks to thefox in #pidgin for reporting the
bug.
*** Plucked rev 777e7e6c4fb02c0b0f0dc557554cfc83b92544ae (sadrul@pidgin.im):
Small leak fix.
author | Sadrul Habib Chowdhury <imadil@gmail.com> |
---|---|
date | Sat, 21 Jun 2008 14:41:18 +0000 |
parents | 9a810bee2ffd |
children | 13a9b56f83b0 |
comparison
equal
deleted
inserted
replaced
23046:cae9ac6cb1a0 | 23047:76ae43c5e745 |
---|---|
82 break; | 82 break; |
83 } | 83 } |
84 } | 84 } |
85 | 85 |
86 static void | 86 static void |
87 pidgin_menu_tray_finalize(GObject *obj) { | 87 pidgin_menu_tray_finalize(GObject *obj) |
88 { | |
89 PidginMenuTray *tray = PIDGIN_MENU_TRAY(obj); | |
88 #if 0 | 90 #if 0 |
89 /* This _might_ be leaking, but I have a sneaking suspicion that the widget is | 91 /* This _might_ be leaking, but I have a sneaking suspicion that the widget is |
90 * getting destroyed in GtkContainer's finalize function. But if were are | 92 * getting destroyed in GtkContainer's finalize function. But if were are |
91 * leaking here, be sure to figure out why this causes a crash. | 93 * leaking here, be sure to figure out why this causes a crash. |
92 * -- Gary | 94 * -- Gary |
93 */ | 95 */ |
94 PidginMenuTray *tray = PIDGIN_MENU_TRAY(obj); | |
95 | 96 |
96 if(GTK_IS_WIDGET(tray->tray)) | 97 if(GTK_IS_WIDGET(tray->tray)) |
97 gtk_widget_destroy(GTK_WIDGET(tray->tray)); | 98 gtk_widget_destroy(GTK_WIDGET(tray->tray)); |
98 #endif | 99 #endif |
100 | |
101 if (tray->tooltips) | |
102 g_object_ref_sink(G_OBJECT(tray->tooltips)); | |
99 | 103 |
100 G_OBJECT_CLASS(parent_class)->finalize(obj); | 104 G_OBJECT_CLASS(parent_class)->finalize(obj); |
101 } | 105 } |
102 | 106 |
103 static void | 107 static void |