Mercurial > pidgin.yaz
comparison src/gtkft.c @ 4617:858979ab3867
[gaim-migrate @ 4908]
Big Changes:
-Rewrote some of the perl stuff so perl scripts can change a few of their
parameters
-Receiving a file with AIM over oscar works pretty well
Now, the "nitty gritty":
Very minor change to prefs.c: In the plugins details tab, I changed "URL"
to "Web Site." I was just going to fix the tabbing, but silvestrij
suggested changing it to "Web site," and I thought that sounded good.
I think it fits better, too. I dunno, maybe that's just me.
"Get Capabilities" has stopped working for some reason. I'm just going to
blame AOL. It's really not important anyway, and some people wanted it
taken off. It is now #ifdef 0'ed out. I'll remove it completely if it
continues to no longer function.
I took out a few plugin_event calls from oscar.c and put them in core code.
"event_error" should be, uh, "evented" when there is an error signing on.
Hopefully no one was using this. It's really pretty useless. The parameter
is now the reason for not being able to connect rather than the archaic
toc error code.
I screwed around with how perl functions are called some. There was way the
hell too much malloc'ing going on here. I think all in all it's an
improvement, though I'm still not a big fan of how changes to parameters
propagate to the actual memory.
I really think it would be nice if the perl stuff was made into a C plugin.
It's just so much cleaner. Especially if someone wanted to write, say, a
python or tcl interpreter. That's how xchat2 does it. I just think that
would be really slick. Like butter. Or ice. Very unlike Velcro.
I added a "Change Password" Protocol Action for ICQ over oscar. This was
really pretty easy. I'd like to thank my housemate Andrew for complaining
a lot that having to use Windows ICQ to change his password was a pain.
I rewrote a lot of the oscar file transfer stuff to use Christian's new
xfer interface. This involved moving a few functions from ft.c to im.c,
where they belong. I also removed all the #if 0'ed getfile functions.
I'll be rewritting them soonish. Receiving a file should work perfectly,
aside from maybe a small memleak when stuff is canceled. Sending a file is
currently disabled. No ETA on when I'll have that working.
I renamed pretty much all of the functions in im.c so they have kind of a
scheme now. They should all be aim_im_bleh, since "im" is the family
name. There comes a time when you must break the crap out of any clients
that might be using libfaim in order to make stuff cleaner. Maybe.
I got rid of the snac destructor stuff for now. I'll probably add it back
later. I wasn't entirely comfortable with how it was done.
committer: Tailor Script <tailor@pidgin.im>
author | Mark Doliner <mark@kingant.net> |
---|---|
date | Wed, 26 Feb 2003 05:01:37 +0000 |
parents | 8742023570be |
children | 440d3d870b84 |
comparison
equal
deleted
inserted
replaced
4616:767093a2ddaf | 4617:858979ab3867 |
---|---|
1114 gaim_gtkxfer_update_progress(struct gaim_xfer *xfer, double percent) | 1114 gaim_gtkxfer_update_progress(struct gaim_xfer *xfer, double percent) |
1115 { | 1115 { |
1116 gaim_gtkxfer_dialog_update_xfer(xfer_dialog, xfer); | 1116 gaim_gtkxfer_dialog_update_xfer(xfer_dialog, xfer); |
1117 | 1117 |
1118 /* See if it's removed. */ | 1118 /* See if it's removed. */ |
1119 if (xfer->ui_data == NULL) | 1119 /* XXX - This caused some bad stuff, and I don't see a point to it */ |
1120 gaim_xfer_destroy(xfer); | 1120 /* if (xfer->ui_data == NULL) |
1121 gaim_xfer_destroy(xfer); */ | |
1121 } | 1122 } |
1122 | 1123 |
1123 static void | 1124 static void |
1124 gaim_gtkxfer_cancel(struct gaim_xfer *xfer) | 1125 gaim_gtkxfer_cancel(struct gaim_xfer *xfer) |
1125 { | 1126 { |
1126 gaim_gtkxfer_dialog_cancel_xfer(xfer_dialog, xfer); | 1127 gaim_gtkxfer_dialog_cancel_xfer(xfer_dialog, xfer); |
1127 | 1128 |
1128 /* See if it's removed. */ | 1129 /* See if it's removed. */ |
1129 if (xfer->ui_data == NULL) | 1130 /* XXX - This caused some looping, and I don't see a point to it */ |
1130 gaim_xfer_destroy(xfer); | 1131 /* if (xfer->ui_data == NULL) |
1132 gaim_xfer_destroy(xfer); */ | |
1131 } | 1133 } |
1132 | 1134 |
1133 struct gaim_xfer_ui_ops ops = | 1135 struct gaim_xfer_ui_ops ops = |
1134 { | 1136 { |
1135 gaim_gtkxfer_destroy, | 1137 gaim_gtkxfer_destroy, |