Mercurial > pidgin.yaz
comparison src/multi.c @ 4617:858979ab3867
[gaim-migrate @ 4908]
Big Changes:
-Rewrote some of the perl stuff so perl scripts can change a few of their
parameters
-Receiving a file with AIM over oscar works pretty well
Now, the "nitty gritty":
Very minor change to prefs.c: In the plugins details tab, I changed "URL"
to "Web Site." I was just going to fix the tabbing, but silvestrij
suggested changing it to "Web site," and I thought that sounded good.
I think it fits better, too. I dunno, maybe that's just me.
"Get Capabilities" has stopped working for some reason. I'm just going to
blame AOL. It's really not important anyway, and some people wanted it
taken off. It is now #ifdef 0'ed out. I'll remove it completely if it
continues to no longer function.
I took out a few plugin_event calls from oscar.c and put them in core code.
"event_error" should be, uh, "evented" when there is an error signing on.
Hopefully no one was using this. It's really pretty useless. The parameter
is now the reason for not being able to connect rather than the archaic
toc error code.
I screwed around with how perl functions are called some. There was way the
hell too much malloc'ing going on here. I think all in all it's an
improvement, though I'm still not a big fan of how changes to parameters
propagate to the actual memory.
I really think it would be nice if the perl stuff was made into a C plugin.
It's just so much cleaner. Especially if someone wanted to write, say, a
python or tcl interpreter. That's how xchat2 does it. I just think that
would be really slick. Like butter. Or ice. Very unlike Velcro.
I added a "Change Password" Protocol Action for ICQ over oscar. This was
really pretty easy. I'd like to thank my housemate Andrew for complaining
a lot that having to use Windows ICQ to change his password was a pain.
I rewrote a lot of the oscar file transfer stuff to use Christian's new
xfer interface. This involved moving a few functions from ft.c to im.c,
where they belong. I also removed all the #if 0'ed getfile functions.
I'll be rewritting them soonish. Receiving a file should work perfectly,
aside from maybe a small memleak when stuff is canceled. Sending a file is
currently disabled. No ETA on when I'll have that working.
I renamed pretty much all of the functions in im.c so they have kind of a
scheme now. They should all be aim_im_bleh, since "im" is the family
name. There comes a time when you must break the crap out of any clients
that might be using libfaim in order to make stuff cleaner. Maybe.
I got rid of the snac destructor stuff for now. I'll probably add it back
later. I wasn't entirely comfortable with how it was done.
committer: Tailor Script <tailor@pidgin.im>
author | Mark Doliner <mark@kingant.net> |
---|---|
date | Wed, 26 Feb 2003 05:01:37 +0000 |
parents | 972af41f277c |
children | 5cdfd20daa07 |
comparison
equal
deleted
inserted
replaced
4616:767093a2ddaf | 4617:858979ab3867 |
---|---|
1621 static void hide_login_progress_common(struct gaim_connection *gc, | 1621 static void hide_login_progress_common(struct gaim_connection *gc, |
1622 char *details, | 1622 char *details, |
1623 char *title, | 1623 char *title, |
1624 char *prologue) | 1624 char *prologue) |
1625 { | 1625 { |
1626 char buf[2048]; | 1626 gchar *buf; |
1627 struct kick_dlg *k = find_kick_dlg(gc->account); | 1627 struct kick_dlg *k = find_kick_dlg(gc->account); |
1628 struct signon_meter *meter = find_signon_meter(gc); | 1628 struct signon_meter *meter = find_signon_meter(gc); |
1629 sprintf(buf, _("%s\n%s: %s"), full_date(), prologue, details); | 1629 buf = g_strdup_printf(_("%s\n%s: %s"), full_date(), prologue, details); |
1630 if (k) | 1630 if (k) |
1631 gtk_widget_destroy(k->dlg); | 1631 gtk_widget_destroy(k->dlg); |
1632 k = g_new0(struct kick_dlg, 1); | 1632 k = g_new0(struct kick_dlg, 1); |
1633 k->account = gc->account; | 1633 k->account = gc->account; |
1634 k->dlg = do_error_dialog(title, buf, GAIM_ERROR); | 1634 k->dlg = do_error_dialog(title, buf, GAIM_ERROR); |
1637 if (meter) { | 1637 if (meter) { |
1638 kill_meter(meter); | 1638 kill_meter(meter); |
1639 meters = g_slist_remove(meters, meter); | 1639 meters = g_slist_remove(meters, meter); |
1640 g_free(meter); | 1640 g_free(meter); |
1641 } | 1641 } |
1642 g_free(buf); | |
1642 } | 1643 } |
1643 | 1644 |
1644 void hide_login_progress(struct gaim_connection *gc, char *why) | 1645 void hide_login_progress(struct gaim_connection *gc, char *why) |
1645 { | 1646 { |
1646 char buf[2048]; | 1647 gchar *buf; |
1647 | 1648 |
1648 sprintf(buf, _("%s was unable to sign on"), gc->username); | 1649 plugin_event(event_error, gc, why); |
1650 buf = g_strdup_printf(_("%s was unable to sign on"), gc->username); | |
1649 hide_login_progress_common(gc, why, _("Signon Error"), buf); | 1651 hide_login_progress_common(gc, why, _("Signon Error"), buf); |
1652 g_free(buf); | |
1650 } | 1653 } |
1651 | 1654 |
1652 /* | 1655 /* |
1653 * Like hide_login_progress(), but for informational, not error/warning, | 1656 * Like hide_login_progress(), but for informational, not error/warning, |
1654 * messages. | 1657 * messages. |
1664 * | 1667 * |
1665 */ | 1668 */ |
1666 void hide_login_progress_error(struct gaim_connection *gc, char *why) | 1669 void hide_login_progress_error(struct gaim_connection *gc, char *why) |
1667 { | 1670 { |
1668 char buf[2048]; | 1671 char buf[2048]; |
1672 | |
1673 plugin_event(event_error, gc, why); | |
1669 g_snprintf(buf, sizeof(buf), _("%s has been signed off"), gc->username); | 1674 g_snprintf(buf, sizeof(buf), _("%s has been signed off"), gc->username); |
1670 hide_login_progress_common(gc, why, _("Connection Error"), buf); | 1675 hide_login_progress_common(gc, why, _("Connection Error"), buf); |
1671 } | 1676 } |
1672 | 1677 |
1673 void signoff_all() | 1678 void signoff_all() |