Mercurial > pidgin.yaz
comparison src/protocols/oscar/conn.c @ 4617:858979ab3867
[gaim-migrate @ 4908]
Big Changes:
-Rewrote some of the perl stuff so perl scripts can change a few of their
parameters
-Receiving a file with AIM over oscar works pretty well
Now, the "nitty gritty":
Very minor change to prefs.c: In the plugins details tab, I changed "URL"
to "Web Site." I was just going to fix the tabbing, but silvestrij
suggested changing it to "Web site," and I thought that sounded good.
I think it fits better, too. I dunno, maybe that's just me.
"Get Capabilities" has stopped working for some reason. I'm just going to
blame AOL. It's really not important anyway, and some people wanted it
taken off. It is now #ifdef 0'ed out. I'll remove it completely if it
continues to no longer function.
I took out a few plugin_event calls from oscar.c and put them in core code.
"event_error" should be, uh, "evented" when there is an error signing on.
Hopefully no one was using this. It's really pretty useless. The parameter
is now the reason for not being able to connect rather than the archaic
toc error code.
I screwed around with how perl functions are called some. There was way the
hell too much malloc'ing going on here. I think all in all it's an
improvement, though I'm still not a big fan of how changes to parameters
propagate to the actual memory.
I really think it would be nice if the perl stuff was made into a C plugin.
It's just so much cleaner. Especially if someone wanted to write, say, a
python or tcl interpreter. That's how xchat2 does it. I just think that
would be really slick. Like butter. Or ice. Very unlike Velcro.
I added a "Change Password" Protocol Action for ICQ over oscar. This was
really pretty easy. I'd like to thank my housemate Andrew for complaining
a lot that having to use Windows ICQ to change his password was a pain.
I rewrote a lot of the oscar file transfer stuff to use Christian's new
xfer interface. This involved moving a few functions from ft.c to im.c,
where they belong. I also removed all the #if 0'ed getfile functions.
I'll be rewritting them soonish. Receiving a file should work perfectly,
aside from maybe a small memleak when stuff is canceled. Sending a file is
currently disabled. No ETA on when I'll have that working.
I renamed pretty much all of the functions in im.c so they have kind of a
scheme now. They should all be aim_im_bleh, since "im" is the family
name. There comes a time when you must break the crap out of any clients
that might be using libfaim in order to make stuff cleaner. Maybe.
I got rid of the snac destructor stuff for now. I'll probably add it back
later. I wasn't entirely comfortable with how it was done.
committer: Tailor Script <tailor@pidgin.im>
author | Mark Doliner <mark@kingant.net> |
---|---|
date | Wed, 26 Feb 2003 05:01:37 +0000 |
parents | 34878f660804 |
children | a964972cb361 |
comparison
equal
deleted
inserted
replaced
4616:767093a2ddaf | 4617:858979ab3867 |
---|---|
170 free((*deadconn)->priv); | 170 free((*deadconn)->priv); |
171 | 171 |
172 /* | 172 /* |
173 * This will free ->internal if it necessary... | 173 * This will free ->internal if it necessary... |
174 */ | 174 */ |
175 if ((*deadconn)->type == AIM_CONN_TYPE_RENDEZVOUS) | 175 if ((*deadconn)->type == AIM_CONN_TYPE_CHAT) |
176 aim_conn_kill_rend(sess, *deadconn); | |
177 else if ((*deadconn)->type == AIM_CONN_TYPE_CHAT) | |
178 aim_conn_kill_chat(sess, *deadconn); | 176 aim_conn_kill_chat(sess, *deadconn); |
179 | 177 |
180 if ((*deadconn)->inside) { | 178 if ((*deadconn)->inside) { |
181 aim_conn_inside_t *inside = (aim_conn_inside_t *)(*deadconn)->inside; | 179 aim_conn_inside_t *inside = (aim_conn_inside_t *)(*deadconn)->inside; |
182 | 180 |
322 if (deadconn->fd >= 3) | 320 if (deadconn->fd >= 3) |
323 close(deadconn->fd); | 321 close(deadconn->fd); |
324 deadconn->fd = -1; | 322 deadconn->fd = -1; |
325 if (deadconn->handlerlist) | 323 if (deadconn->handlerlist) |
326 aim_clearhandlers(deadconn); | 324 aim_clearhandlers(deadconn); |
327 if (deadconn->type == AIM_CONN_TYPE_RENDEZVOUS) | |
328 aim_conn_close_rend((aim_session_t *)deadconn->sessv, deadconn); | |
329 | 325 |
330 return; | 326 return; |
331 } | 327 } |
332 | 328 |
333 /** | 329 /** |