comparison pidgin/gtkconv.c @ 22153:8f78d223d24e

Fix the bug where removing the typing notification would cause the text to scroll *up* by 2 pixels. I have also added a define 'RESERVE_LINE' which will always reserve a blank line at the end (of the buffer, not of the view) for the typing notification. We can switch to using that if people use it and like it better, (or hate it less ;) )

22152:6e2dc21a33cb

		gtk_text_buffer_get_iter_at_mark(buffer, &start, stmark);
		gtk_text_buffer_get_iter_at_mark(buffer, &end, enmark);
		gtk_text_buffer_delete_mark(buffer, stmark);
		gtk_text_buffer_delete_mark(buffer, enmark);
		gtk_text_buffer_delete(buffer, &start, &end);
	} else if (message && *message == '\n' && !*(message + 1))
		message = NULL;

	if (message) {
		GtkTextIter iter;
		gtk_text_buffer_get_end_iter(buffer, &iter);
		gtk_text_buffer_create_mark(buffer, "typing-notification-start", &iter, TRUE);

	if (im == NULL)
		return;

	if (purple_conv_im_get_typing_state(im) == PURPLE_NOT_TYPING) {
		update_typing_message(gtkconv, "\n");
		return;
	}

	if (purple_conv_im_get_typing_state(im) == PURPLE_TYPING) {
		message = g_strdup_printf(_("\n%s is typing..."), purple_conversation_get_title(conv));

22153:8f78d223d24e

		gtk_text_buffer_get_iter_at_mark(buffer, &start, stmark);
		gtk_text_buffer_get_iter_at_mark(buffer, &end, enmark);
		gtk_text_buffer_delete_mark(buffer, stmark);
		gtk_text_buffer_delete_mark(buffer, enmark);
		gtk_text_buffer_delete(buffer, &start, &end);
	} else if (message && *message == '\n' && message[1] == ' ' && message[2] == '\0')
		message = NULL;

#ifdef RESERVE_LINE
	if (!message)
		message = "\n ";   /* The blank space is required to avoid a GTK+/Pango bug */
#endif

	if (message) {
		GtkTextIter iter;
		gtk_text_buffer_get_end_iter(buffer, &iter);
		gtk_text_buffer_create_mark(buffer, "typing-notification-start", &iter, TRUE);

	if (im == NULL)
		return;

	if (purple_conv_im_get_typing_state(im) == PURPLE_NOT_TYPING) {
#ifdef RESERVE_LINE
		update_typing_message(gtkconv, NULL);
#else
		update_typing_message(gtkconv, "\n ");
#endif
		return;
	}

	if (purple_conv_im_get_typing_state(im) == PURPLE_TYPING) {
		message = g_strdup_printf(_("\n%s is typing..."), purple_conversation_get_title(conv));