comparison libpurple/plugin.c @ 15901:ab2f466b6a13

Get rid of an unnecessary strdup

15900:9cfe41743c65

		purple_debug_error("plugins", "%s is not loadable: The UI requirement is not met.\n", plugin->path);
		plugin->unloadable = TRUE;
		return plugin;
	}

	/* 
 	 * Check to make sure a plugin has defined an id.
 	 * Not having this check caused purple_plugin_unload to
 	 * enter an infinite loop in certain situations by passing
 	 * purple_find_plugin_by_id a NULL value. -- ecoffey
 	 */
	if (!plugin->info->id || !strcmp(plugin->info->id, ""))
	{
		plugin->error = g_strdup_printf(_("This plugin has not defined an ID."));
		purple_debug_error("plugins", "%s is not loadable: info->id is not defined.\n", plugin->path);
		plugin->unloadable = TRUE;

		if (dep_plugin != NULL && purple_plugin_is_loaded(dep_plugin))
		{
			if (!purple_plugin_unload(dep_plugin))
			{
				char *translated_name = g_strdup(_(dep_plugin->info->name));
				char *tmp;

				tmp = g_strdup_printf(_("The dependent plugin %s failed to unload."),
				                      translated_name);
				g_free(translated_name);

				purple_notify_error(NULL, NULL,
				                  _("There were errors unloading the plugin."), tmp);
				g_free(tmp);
			}

15901:ab2f466b6a13

		purple_debug_error("plugins", "%s is not loadable: The UI requirement is not met.\n", plugin->path);
		plugin->unloadable = TRUE;
		return plugin;
	}

	/*
	 * Check to make sure a plugin has defined an id.
	 * Not having this check caused purple_plugin_unload to
	 * enter an infinite loop in certain situations by passing
	 * purple_find_plugin_by_id a NULL value. -- ecoffey
	 */
	if (!plugin->info->id || !strcmp(plugin->info->id, ""))
	{
		plugin->error = g_strdup_printf(_("This plugin has not defined an ID."));
		purple_debug_error("plugins", "%s is not loadable: info->id is not defined.\n", plugin->path);
		plugin->unloadable = TRUE;

		if (dep_plugin != NULL && purple_plugin_is_loaded(dep_plugin))
		{
			if (!purple_plugin_unload(dep_plugin))
			{
				char *tmp;

				tmp = g_strdup_printf(_("The dependent plugin %s failed to unload."),
				                      _(dep_plugin->info->name));

				purple_notify_error(NULL, NULL,
				                  _("There were errors unloading the plugin."), tmp);
				g_free(tmp);
			}