comparison src/protocols/oscar/snac.c @ 3752:b32474e522fa

[gaim-migrate @ 3890] From: "William T. Mahan" <[e-mail]> This patch, against CVS HEAD, fixes three bugs in Oscar File Transfer support. I can split it up further if desired. * Send a null checksum when initiating a file transfer, which fixes "files don't match" warnings produced by some versions of WinAIM; add a compile-time option to actually compute the checksum, which is slow but necessary when sending to some Mac clients. * Don't allow sending files to oneself, because it causes all kinds of subtle problems and it's not useful. * Don't crash when there is an error writing to the output file when receiving. From: "William T. Mahan" <[e-mail]> This patch 2 of 3, which applies on top of the first, adds support for reverse connections for Oscar File Transfer, the lack of which has been the biggest complaint so far. Reverse connections are used by newer AIM clients when there is difficulty verifying the IP of the sender. From: "William T. Mahan" <[e-mail]> This patch 3 of 3, which applies on top of the first 2, removes the alarm() and sigaction() calls that were added by my original FT patch to detect transfer timeouts. Besides apparently not working on Windows, they involved a lot of ugly code to handle a special case. My new approach is to add destructors that can called when SNACs are freed; a timeout is detected when a request SNAC is cleaned up before the transfer is accepted. Although this touches several files, it is more generic than the old method. I tried to implement this in an unintrusive manner, so that there is little preformance penalty for SNACs that do not use destructors. My first two patches should work fine without this. If there are any objections to the third patch, I ask that the first two patches be applied, in which case I will set up a SourceForge page for this one. committer: Tailor Script <[e-mail]>

3751:e25577506dec

	index = id % FAIM_SNAC_HASH_SIZE;

	for (prev = (aim_snac_t **)&sess->snac_hash[index]; (cur = *prev); ) {
		if (cur->id == id) {
			*prev = cur->next;
			return cur;
		} else
			prev = &cur->next;
	}

	return cur;
}

/*
 * This is for cleaning up old SNACs that either don't get replies or
 * a reply was never received for.  Garabage collection. Plain and simple.
 *

		for (prev = (aim_snac_t **)&sess->snac_hash[i]; (cur = *prev); ) {
			if ((curtime - cur->issuetime) > maxage) {

				*prev = cur->next;

				/* XXX should we have destructors here? */
				free(cur->data);
				free(cur);

			} else
				prev = &cur->next;
		}
	}

3752:b32474e522fa

	index = id % FAIM_SNAC_HASH_SIZE;

	for (prev = (aim_snac_t **)&sess->snac_hash[index]; (cur = *prev); ) {
		if (cur->id == id) {
			*prev = cur->next;
			if (cur->flags & AIM_SNACFLAGS_DESTRUCTOR) {
				struct aim_snac_destructor *asd = cur->data;
				cur->data = asd->data;
				free(asd);
			}
			return cur;
		} else
			prev = &cur->next;
	}

	return cur;
}

/* Free a SNAC, and call the appropriate destructor if necessary.
 * XXX perhaps this should be inline? -- wtm
 */
faim_internal void aim_cleansnac(aim_session_t *sess, aim_snac_t *snac)
{
	aim_module_t *cur;

	if (snac->flags & AIM_SNACFLAGS_DESTRUCTOR) {
		struct aim_snac_destructor *d = snac->data;
		aim_modsnac_t modsnac;

		modsnac.id = snac->id;
		modsnac.subtype = snac->type;
		modsnac.family = snac->family;
		modsnac.flags = snac->flags;

		for (cur = (aim_module_t *)sess->modlistv; cur; cur = cur->next)
		{
			if (!cur->snacdestructor)
				continue;
			if (!(cur->flags & AIM_MODFLAG_MULTIFAMILY) &&
				(cur->family != modsnac.family))
				continue;
			if (cur->snacdestructor(sess, d->conn, &modsnac,
						d->data))
				break;
		}
		free(d->data);
		free(d);
	}

	free(snac->data);
	free(snac);
}


/*
 * This is for cleaning up old SNACs that either don't get replies or
 * a reply was never received for.  Garabage collection. Plain and simple.
 *

		for (prev = (aim_snac_t **)&sess->snac_hash[i]; (cur = *prev); ) {
			if ((curtime - cur->issuetime) > maxage) {

				*prev = cur->next;

				aim_cleansnac(sess, cur);
			} else
				prev = &cur->next;
		}
	}